Ed Sanders
a4636d39fc
Move #getTranscludedFrom from parser to ThreadItem
...
Also requires moving getTitleFromUrl to CommentUtils
Change-Id: I9cb83a3fdd456eba66899433b866ce7a7f00eeb5
2020-07-20 15:56:48 +01:00
Ed Sanders
7ae5bbf384
Move #getAuthors from parser to ThreadItem
...
Change-Id: I16e513000e5366b3044b17a99da07d8d0f47a61f
2020-07-20 15:13:59 +01:00
Ed Sanders
b32f991913
Documentation fixes
...
Change-Id: I2c7ccecbf8a50bd4d658b0f17f4a21fe90a3c399
2020-07-20 13:34:08 +01:00
Ed Sanders
092cfd6075
Parser: Replace findTimestamps with findTimestamp
...
Instead of doing a separate tree walk and finding all timestamps
separately, make it part of the getComments tree walk, and find
timestamps one at a time.
Change-Id: I47f466eaf228504faa189fd99e07493bc7f022cd
2020-07-15 21:34:22 +02:00
Bartosz Dziewoński
308c2747b0
CommentParser.php: Use tree walking instead of XPath
...
This is similar to what the JS version does.
The TreeWalker and NodeFilter classes are adapted from
https://github.com/Krinkle/dom-TreeWalker-polyfill
(MIT license).
This makes #getComments twice as fast on en-big-oldparser.html
Change-Id: I2441f33e6e7bad753ac830d277e6a2e81ee8c93d
2020-07-15 16:40:50 +00:00
Ed Sanders
ed70d49285
CommentParser.php: Fix URL parsing
...
Change-Id: I406fd98b308dd4d975ea974f2369737a7052b556
2020-07-01 17:06:02 +01:00
Ed Sanders
d5376e28fc
Improve ThreadItem documentation
...
Change-Id: Ia266fc22b02af0edbb32f356b4e0d92fe3a4da5f
2020-06-26 14:56:19 +02:00
James D. Forrester
d6c3df31f5
Remove various phan suppressions and fix issues
...
Change-Id: I73b535f284566a0a8876a3198b9784b47567fac6
2020-06-12 20:35:59 +01:00
Ed Sanders
7be0cc3209
Create ThreadItem classes
...
Change-Id: Id2c5324d74eccb1209ccb76768c557722c6d9400
2020-06-12 20:35:59 +01:00
Umherirrender
48e860916a
build: Add mediawiki/mediawiki-phan-config
...
Replace phan-taint-check-plugin by phan, it is now included
Change-Id: I0e682a83afd30faa8967e3c586431be4ae9a29b3
2020-06-10 22:21:07 +02:00
Ed Sanders
da433037a3
Move getTranscludedFromElement to Utils
...
Change-Id: I8bdd757f949c013ba426150a192d71243fadf45d
2020-06-01 22:32:23 +01:00
Bartosz Dziewoński
79ae8a32c5
Support parsing when timestamp is wrapped in a link
...
Bug: T252059
Change-Id: Ib8952fb80503bad407e8d0fe725103a0fae12a6a
2020-05-27 22:47:17 +02:00
Bartosz Dziewoński
01b4a8f4f4
Support replying when timestamp is template-generated
...
* Move modifier#getFullyCoveredWrapper to utils
* Use that method to find the node where we start searching for
template wrappers, rather than using endContainer
Bug: T252058
Change-Id: I55de58102f3468fce01290bd413a7fdc96d322d6
2020-05-27 21:16:03 +02:00
Ed Sanders
b3ca37c1c5
Create ImmutableRange class in PHP
...
TODO: Create one in JS as well
Change-Id: I6c9dc2455afcb8d0b68674a2985c5e43dd94b6fb
2020-05-22 15:01:09 +01:00
Bartosz Dziewoński
515af82061
Reduce duplication between PHP parser and data gen for JS parser
...
Also, make the handling of TranslateNumerals and digitsRegexp the same
between PHP and JS.
Change-Id: I1d81343d0b59ab3ecd59ba1c2ad99a729d983ac4
2020-05-19 20:54:44 +02:00
jenkins-bot
366aca2ccd
Merge "Stop printing console warnings"
2020-05-18 22:52:30 +00:00
Bartosz Dziewoński
219339551c
Stop printing console warnings
...
It was useful when I was debugging those parts of the code, but now
it's usually annoying.
The warnings can still sometimes be useful for understanding how the
tool parses some discussion, though. To keep that functionality, add
displaying warnings for each comment in the debug mode.
Change-Id: I2d218a8a394f179bcc0990ff988a0567c275ccf2
2020-05-18 23:37:37 +02:00
Ed Sanders
607440498e
Spell check pass
...
Change-Id: Ia20da358297126bd52a968bd77c960f81fe82b8f
2020-05-18 21:24:14 +00:00
Bartosz Dziewoński
c848d8a90e
Parser tweaks
...
Follow-up to Ic1438d516e223db462cb227f6668e856672f538c.
Minor corrections and comment improvements in PHP parser,
and "backporting" some changes to JS parser that I like.
Change-Id: I5e54121914ec6b323e556dd133bcb71b3aefbb61
2020-05-18 19:53:26 +00:00
Ed Sanders
b1427163af
Parser.php: Add tests for getTranscludedFrom
...
Requires an implementation of unwrapParsoidSections
Change-Id: I96c929b1117ba652dbd5af6a1ee37a5f9e87ed1e
2020-05-18 19:53:01 +00:00
Ed Sanders
bc437fc43f
PHP: More missing typehints
...
Change-Id: I483c9e70b65dcd685436b4099bcfc4925c65b002
2020-05-16 16:46:25 +01:00
jenkins-bot
9cc665a8bc
Merge "Add missing use MWException"
2020-05-15 21:46:21 +00:00
jenkins-bot
a6fcb965ea
Merge "Fix return type of callable"
2020-05-15 21:46:20 +00:00
Reedy
ac6cd26ca0
Don't call non static functions statically
...
Change-Id: I2db66a8da3ab325f2bbabb37afd276d4a62077e9
2020-05-15 22:02:57 +01:00
Reedy
70c5a1e435
Fix return type of callable
...
Change-Id: I7e594a9f9f6f9d4737fd880e449c43b9b2cf24fb
2020-05-15 22:01:21 +01:00
Reedy
c3a7ba1d13
Add missing use MWException
...
Change-Id: I4d00106718c0f7e32060d23aaa2bc8c74a4d6d1f
2020-05-15 22:00:30 +01:00
Ed Sanders
e6e0b1ead9
PHP: Add missing typehints
...
Change-Id: I5639f8cbdae9aaa9cfa06136e19cc94f9fad10ea
2020-05-15 22:04:47 +02:00
Ed Sanders
b78fb3f4c1
Move all PHP to the MediaWiki\Extension\DiscussionTools namespace
...
Change-Id: I654ebb3e646a6d8d62f7bd14d48805e39f836d7e
2020-05-15 21:57:13 +02:00