wikimedia/mediawiki-extensions-DiscussionTools

Fork 0

mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 08:23:52 +00:00

Commit graph

Author	SHA1	Message	Date
David Lynch	4b370a8971	ThreadItem jsonSerialize: make sure callback is applied last This changes a vast number of test expected-outputs because it affects the order of the keys when serialized. Bug: T315400 Change-Id: I6ad2cded6ba7cb2cc5e5ba37ea60f4b18ecc26be	2022-08-30 09:11:46 -05:00
Bartosz Dziewoński	880f9755e0	Separate ContentThreadItem and DatabaseThreadItem etc. Rename ThreadItem to ContentThreadItem, then create a new ThreadItem interface containing only the methods that we'll be able to implement using only the persistently stored data (no parsing), then create a DatabaseThreadItem. Do the same for CommentItem and HeadingItem. ThreadItemSet gets a similar treatment, but it's basically only for Phan's type checking. (This is sad.) Change-Id: I1633049befe8ec169753b82eb876459af1f63fe8	2022-07-04 23:35:50 +02:00

Author

SHA1

Message

Date

David Lynch

4b370a8971

ThreadItem jsonSerialize: make sure callback is applied last

This changes a vast number of test expected-outputs because it affects
the order of the keys when serialized.

Bug: T315400
Change-Id: I6ad2cded6ba7cb2cc5e5ba37ea60f4b18ecc26be

2022-08-30 09:11:46 -05:00

Bartosz Dziewoński

880f9755e0

Separate ContentThreadItem and DatabaseThreadItem etc.

Rename ThreadItem to ContentThreadItem, then create a new ThreadItem
interface containing only the methods that we'll be able to implement
using only the persistently stored data (no parsing), then create a
DatabaseThreadItem. Do the same for CommentItem and HeadingItem.

ThreadItemSet gets a similar treatment, but it's basically only for
Phan's type checking. (This is sad.)

Change-Id: I1633049befe8ec169753b82eb876459af1f63fe8

2022-07-04 23:35:50 +02:00

2 commits