wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-24 10:58:20 +00:00
Code Issues Packages Projects Releases Wiki Activity
659 commits 138 branches 0 tags 114 MiB
Commit graph

125 commits

Author SHA1 Message Date
Bartosz Dziewoński c8d06f6bd6 Add a test case for replies to top-level comments with mixed indentation 
The bug was accidentally fixed in 569db3603c.

Bug: T252702
Change-Id: I0020ac41adcf111b8496d3d4bce65740faf9e7ef
 2020-07-30 01:46:45 +02:00
Ed Sanders 5d8f3b9051 Create a 'transcludedfrom' API endpoint 
Bug: T252558
Change-Id: I2220f26dc2b744f03feeee9124f6936858dda3eb
 2020-07-27 21:20:01 +01:00
Ed Sanders 8829a1a412 Edit API for replies 
Bug: T252558
Change-Id: Iac43b5bb0315ceaad7698fb2b708b7c3cde403f8
 2020-07-27 21:19:58 +01:00
Bartosz Dziewoński 31e371e944 Better handle HTML comments following replies 
Bug: T257651
Change-Id: I07e995beca4f031be062958ff7d75727afa8e606
 2020-07-23 18:18:21 +02:00
jenkins-bot 889de1bcdf Merge "Improve detecting typed signatures" 2020-07-22 01:43:40 +00:00
jenkins-bot 7eff952cb2 Merge "Signature handling in visual mode" 2020-07-22 01:42:47 +00:00
jenkins-bot 3db53080e8 Merge "Don't allow switching when unsupported content used" 2020-07-21 23:14:08 +00:00
Bartosz Dziewoński 80e52e1155 Improve detecting typed signatures 
* Remove the existing approach for detecting signatures that only
  worked in source mode; remove autoSignWikitext()

* Use the same approach for auto-signing in source mode as we have
  already used in visual

* In both modes, detect whether the user has already typed a signature
  at the end of their comment in the modifier, and if so, don't add a
  signature

* Add test cases for the detection

Bug: T255738
Change-Id: I791d3035cb1ffc33ce3966d4617a25d08700c35b
 2020-07-22 00:00:53 +02:00
jenkins-bot 79195b9fb7 Merge "Refactor CommentParser" 2020-07-21 21:40:29 +00:00
Ed Sanders a2431fe006 Refactor CommentParser 
* Pass rootNode to the constructor
* Rename getters to match CommentItem/HeadingItem/ThreadItem
  value classes.
* Always build the thread tree so CommentItem's always have
  and ID and replies/parent.

Change-Id: I508be9534de59016ff806e3d84edcbb1c76cb0c6
 2020-07-20 23:38:10 +01:00
jenkins-bot e89f58eddf Merge "Customise abandon edit dialog copy" 2020-07-20 18:29:12 +00:00
jenkins-bot 271124d5cb Merge "Create a PingNode so user pings are single focusable nodes" 2020-07-20 17:13:32 +00:00
Ed Sanders 7ae5bbf384 Move #getAuthors from parser to ThreadItem 
Change-Id: I16e513000e5366b3044b17a99da07d8d0f47a61f
 2020-07-20 15:13:59 +01:00
Ed Sanders e6f7a9e679 Create a PingNode so user pings are single focusable nodes 
Bug: T252083
Change-Id: I168e036d201b924e7fc9bda2f2f58e48ad2dbac0
 2020-07-17 23:17:41 +01:00
Ed Sanders 854c8e4b28 Customise abandon edit dialog copy 
Bug: T257069
Change-Id: I2770b53f826b5af689051cc681a75f9608e85de9
 2020-07-17 23:04:44 +01:00
Bartosz Dziewoński ee69365b82 Signature handling in visual mode 
Load 'ext.visualEditor.mwsignature' (which implements VE's existing
handling for signatures), then subclass and override a bunch of things
in order to:

* Replace the context menu with a note that you don't need to type the
  signature when commenting using the reply widget

* Override the sequence/command to insert signature so that it selects
  it afterwards and thus displays the context menu

* Treat signatures as signature nodes when switching from wikitext,
  instead of the normal pre-save transform turning them into regular
  links and text

Bug: T255738
Change-Id: Icb542451c2307ab51e56bd627804096c7b5552c8
 2020-07-16 01:32:19 +02:00
Ed Sanders 00042d8499 Remove DiscussionToolsEnableVisual config 
Defaults to true and has no need to be disabled anymore.

Change-Id: I3cf9b5accea0fd1f175c75057641657742d8fa1b
 2020-07-13 15:51:47 +01:00
Ed Sanders 58aa412fa3 Don't allow switching when unsupported content used 
Bug: T256150
Change-Id: I9b57996f069a1c0c05ef396cfe0ed81495a1d9ec
 2020-07-09 13:05:09 +01:00
Ed Sanders 6459e7dc82 Move wikitext modifiers to modifier.js 
Re-create methods in PHP.

Change-Id: Iae6117b65e3b8f50ecc68e1e3ea17c8359bdcb06
 2020-07-01 17:06:02 +01:00
jenkins-bot 475cb40aa3 Merge "Set DiscussionToolsEnableVisual to true by default" 2020-06-29 11:54:25 +00:00
Ed Sanders 03665de09e Move VE components to dt-ve 
Change-Id: I4fba23e83d9ace833b55e67d1c3ef8b8da5ed19f
 2020-06-22 20:09:18 +02:00
jenkins-bot c678fffd49 Merge "Add user mention tool" 2020-06-15 19:46:19 +00:00
Ed Sanders 21b5ad037c Set DiscussionToolsEnableVisual to true by default 
At some point in the near future we can delete this config.

Bug: T251654
Change-Id: I87270af14fb0edf931ce98ae8a3b049a669487d4
 2020-06-15 19:44:50 +01:00
Ed Sanders 7be0cc3209 Create ThreadItem classes 
Change-Id: Id2c5324d74eccb1209ccb76768c557722c6d9400
 2020-06-12 20:35:59 +01:00
Ed Sanders 38d85268f0 Add user mention tool 
Uses userAvatar for now while we wait on userAdd to be upstreamed.

Bug: T254366
Change-Id: Ifa512c518efa9740a138d3d42fc607f2840b4040
 2020-06-11 20:53:49 +01:00
Ed Sanders c794e49df0 Increase VE dependency 
Depends-On: I382aee3563cdcccd2f872c0f1b0ebd0feff6859c
Change-Id: I183ecd36699505ddd9a4adaacbfc216fd32b2753
 2020-06-04 22:37:31 +01:00
David Lynch 068ff29e88 Depend on Linter 
Depends-On: I8b183d816748245722ca1a459203333614f58f32
Change-Id: If2252d54a39a9d12744ccdee08e334a211f41d46
 2020-06-04 18:23:57 +02:00
jenkins-bot 431ba1c87f Merge "Make signature prefix customisable" 2020-06-01 17:18:04 +00:00
Ed Sanders dada23e0f4 Make signature prefix customisable 
Bug: T249861
Change-Id: I506a0c1b803275f5505fdf8ee29cc535814d7742
 2020-06-01 18:55:04 +02:00
Bartosz Dziewoński 43a7e82ed0 Tests covering fr.wp unsigned comment templates 
Bug: T252058
Bug: T252059
Change-Id: Ica7426055e73562a98b99d6ea06e257df77b7493
 2020-05-28 00:13:07 +02:00
jenkins-bot c53cecac10 Merge "Create a user preference to store visual/source mode" 2020-05-21 16:21:34 +00:00
Ed Sanders 5feb69612f Create a user preference to store visual/source mode 
Bug: T250523
Depends-On: I5b3b47feeeca2085fcd283d55d7e9ceafa73be70
Change-Id: I18f5d38f9d694b12e5f983be7b3b165f135a890d
 2020-05-20 22:16:19 +01:00
Bartosz Dziewoński c64bb6b5b7 Add the test for getAuthors() in JS too 
Change-Id: Id7dabc535b6bb688602c0d55fc3696f662cb10c7
 2020-05-19 21:13:52 +02:00
Bartosz Dziewoński e12aea2f77 Add test case for unwrapParsoidSections() 
Covers the bug fixed in I9133d4365a71d6db1fa58b69ae3b970166d15c1e.

Depends-On: I9133d4365a71d6db1fa58b69ae3b970166d15c1e
Bug: T252238
Change-Id: I92831696864e04384eb514ab69f14563cceafc19
 2020-05-18 21:36:48 +00:00
Ed Sanders c5d1029b25 Move /cases and /data up to /tests 
Theses are no longer QUnit specific.

Change-Id: I5f3cca1ff686922e0cdaaedb80858f37df04799a
 2020-05-18 21:47:17 +01:00
Ed Sanders b1427163af Parser.php: Add tests for getTranscludedFrom 
Requires an implementation of unwrapParsoidSections

Change-Id: I96c929b1117ba652dbd5af6a1ee37a5f9e87ed1e
 2020-05-18 19:53:01 +00:00
Ed Sanders b78fb3f4c1 Move all PHP to the MediaWiki\Extension\DiscussionTools namespace 
Change-Id: I654ebb3e646a6d8d62f7bd14d48805e39f836d7e
 2020-05-15 21:57:13 +02:00
Ed Sanders 340572bc05 Create a Utils class in PHP 
Also move htmlTrim to utils in JS.

Change-Id: Ia5356d713c1c5d521c396cc28bcd4ecc7ee5bbbb
 2020-05-15 00:25:32 +01:00
Ed Sanders a3889fd400 Port modifier.js to PHP 
Change-Id: I03b9e4377cb3ce6a5ca9d06e49dca9b2516f4979
 2020-05-15 00:20:41 +01:00
Ed Sanders 745101c02b PHP tests: Move some test utils to a parent class 
Change-Id: I6ae5aa85f8aaa02e1b9323820a841c06c5d62b64
 2020-05-12 12:33:04 +01:00
Roan Kattouw 7b7a2cd69c The Great Parser JS to PHP port of 2020!* 
* Not to be confused with the Parsing Team's
"Great Parser JS to PHP port of 2019"

Gasp as OR hacks are changed to null coalescing operators.
Applaud as variable declarations are dropped.
Cheer as parameters and return values are type-hinted.
Shudder as DomNodeLists have no indexOf method.

Moving discussion parsing to the server should allow
us to implement much cleaner APIs for commenting.

Bug: T252252
Co-authored-by: Ed Sanders <esanders@wikimedia.org>
Change-Id: Ic1438d516e223db462cb227f6668e856672f538c
 2020-05-12 12:33:04 +01:00
Ed Sanders 4397bda8cb Modifier: Separate out test data 
Change-Id: I63d868a47daebee180c229b424311d10b80d2e89
 2020-05-11 16:58:00 +01:00
Ed Sanders 41d5aa1d37 Separate out more data from parser.tests.js 
Change-Id: Ib1c3ec30796dd6bff36835e4555b6974e2a5b376
 2020-05-08 12:12:11 +01:00
jenkins-bot f0f457562d Merge "Handle &nbsp; and other entities in the timestamp/timezone" 2020-05-07 19:44:12 +00:00
Ed Sanders 9fab4add17 Config: Separate useVisualEditor into enableVisual and use2017Wikitext 
Currently use2017Wikitext is missing some implementations.

Change-Id: Ib5f9bcc588561a80ca11de85518e6fae64e5b104
 2020-05-06 18:03:36 +01:00
Ed Sanders 56d8721fd7 Switching between VE & wikitext (plain) 
Bug: T234403
Change-Id: I84a639ab8e31ec9f683a63b0ecf184f426df09dd
 2020-05-06 18:03:36 +01:00
Bartosz Dziewoński 0269626adc Handle &nbsp; and other entities in the timestamp/timezone 
Bug: T251838
Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
 2020-05-05 22:38:16 +02:00
David Lynch b7ad053105 @Username completion in VE (source or visual) mode 
Bug: T232601
Depends-On: I075cac9aa195574c3d416a40bbdc5ec2d64424e2
Change-Id: Ie605e783b333be0f81099d8d953725c38eb4cee1
 2020-05-05 09:44:08 -05:00
Ed Sanders 5271b3eafd Move CommentController to separate file 
Change-Id: I6dbf16801058e7e41d38a0ce5753c298d380b780
 2020-04-30 17:05:04 +01:00
jenkins-bot 922443f68f Merge "ConfirmEdit CAPTCHA support" 2020-04-29 12:04:44 +00:00