Commit graph

3555 commits

Author SHA1 Message Date
Ed Sanders 79a62f539d ThreadItem: Add display names to getAuthorsBelow
Change-Id: I4195f982d7071fea0d0334908535639a11cdcae9
2023-02-23 23:03:35 +00:00
Ed Sanders b82af45735 CommentParser: Output display name if different to username
The only normalisation we apply for comparison is lowercasing.

Change-Id: Id3d57c2066429fcedc7dcc091e74ed46e17060f1
2023-02-23 23:03:32 +00:00
Bartosz Dziewoński cf6c18f364 Remove unused CSS for .ext-discussiontools-init-replylink-divider
Not used anywhere, not even in gadgets. I guess it was for other
planned features, but it can be added back when needed.

Change-Id: I858e8854567ffae6ff11ba61d99b4b09b12dc7d7
2023-02-23 23:26:03 +01:00
Amir Sarabadani a1ee2d6daf Use the new method of getting database object
Bug: T326274
Change-Id: I40c6efee0d13ebb6f345ac9f13d243d730b146b9
2023-02-23 12:57:16 +01:00
Translation updater bot 1c1edc2b46 Localisation updates from https://translatewiki.net.
Change-Id: If98b15f6809bad0fe6619c019cc4f2c575ad3cd8
2023-02-23 08:38:54 +01:00
Translation updater bot cd9e3ae82e Localisation updates from https://translatewiki.net.
Change-Id: I09966485da3f1876fdc48b203bc52b9168537506
2023-02-22 09:00:24 +01:00
Translation updater bot 74a5f2ae15 Localisation updates from https://translatewiki.net.
Change-Id: I31371db37252f4ea176e28141c66e80684fac120
2023-02-21 08:20:56 +01:00
Translation updater bot 3b5925d0de Localisation updates from https://translatewiki.net.
Change-Id: Icb79b6f2a6eb3aa171171f8e83ac6680a00f9f61
2023-02-20 09:46:19 +01:00
Translation updater bot 76a303b2c6 Localisation updates from https://translatewiki.net.
Change-Id: Ic989867ccf148ea6a1e01db45e5d52ba8d10a74f
2023-02-17 08:55:49 +01:00
jenkins-bot b384a7ffc6 Merge "LedeSectionDialog: Fix double scrollbars in some cases" 2023-02-16 20:03:12 +00:00
jenkins-bot d3c451097b Merge "Special case opening new topic tool when VE or 2017WTE is open" 2023-02-16 16:47:16 +00:00
jenkins-bot 763796c58c Merge "Prompt IP users that they can be notified of replies if they sign in" 2023-02-16 16:24:53 +00:00
Translation updater bot 8a7e0052f8 Localisation updates from https://translatewiki.net.
Change-Id: I6646eb7a6fd40a98c6b9e8eb8ac84904ae37d5c5
2023-02-16 08:46:18 +01:00
Bartosz Dziewoński 4b7ba72c83 LedeSectionDialog: Fix double scrollbars in some cases
There's no need for this PanelLayout to be scrollable, as the dialog
body itself is scrollable, and this is causing an unnecessary
horizontal scrollbar to appear on some pages (for example
https://de.m.wikipedia.org/wiki/Wikipedia_Diskussion:Hauptseite).

Change-Id: I516cae8ca006b57360fe85a2eba099913b38ce84
2023-02-16 01:04:14 +01:00
MarcoAurelio eccb927956 Add Spanish aliases
Change-Id: I661cc6e01bc1bdadc72a0e837d2c8047a25c01b0
2023-02-15 18:35:52 +00:00
Bartosz Dziewoński 5af3e90fec Support '&preload=...' etc. in new topic tool when '&dtpreload=1' is set
To avoid affecting existing preload forms, the new topic tool is only
used when the 'dtpreload' query parameter is also set.

Bug: T269310
Change-Id: I4ee024cc4760542790319f302f42b1b2389ac897
2023-02-15 16:39:38 +01:00
Translation updater bot 0814fd89ee Localisation updates from https://translatewiki.net.
Change-Id: Ia416c2527c881d940e4bb3d421842d61560b0061
2023-02-15 08:25:34 +01:00
Lectrician1 3e109725b7 Prompt IP users that they can be notified of replies if they sign in
Changes the notice IP users see when creating a reply or or a new topic to include that they can be notified of replies if they sign in

Bug: T328951
Change-Id: I91470092c92f47da36fc613de2fdb838fbc68d2e
2023-02-15 05:00:17 +00:00
Bartosz Dziewoński e6681772da Avoid unneeded queries in isAvailableForTitle()
Don't check the 'newsectionlink' property if we don't need it.

Also improve comments.

Change-Id: I50a84ba5e21ffd22859e770329522babf6e729c8
2023-02-14 16:53:48 +00:00
Bartosz Dziewoński 445b8caca0 persistRevisionThreadItems: Avoid listing non-discussion pages
Bug: T329627
Change-Id: I52a9f5dfa583d8dc2e0a315844a2a40e538f6a8c
2023-02-14 17:53:27 +01:00
Translation updater bot 7cea0c2b04 Localisation updates from https://translatewiki.net.
Change-Id: I2f28d296248a2687bc04c2098bd806b51fc56f89
2023-02-14 08:31:27 +01:00
Bartosz Dziewoński 93f8d338c8 Disable on LiquidThreads pages
Bug: T329423
Change-Id: Id8995e4d35083b740806499c545d1b308a9a1722
2023-02-14 00:50:07 +01:00
Bartosz Dziewoński 55b0167868 ReplyLinksController: Fix teardown failing when reloading
Follow-up to 06919f9444 - applies the
same workaround in more places.

Bug: T329523
Change-Id: I265945b6ba44d735482e51e805319702a239a442
2023-02-13 15:46:58 +01:00
Translation updater bot 526c836ec7 Localisation updates from https://translatewiki.net.
Change-Id: I794fc551a90346ea55ee2c0b9a84696a19bda9d2
2023-02-13 08:29:55 +01:00
Bartosz Dziewoński 5d3d3cf687 Use setExtensionData() instead of marker comments where possible (2/3)
We started using marker comments (HTML comments with special content
inserted into the page) for the reply buttons back in the day, because
we needed to indicate their location in the HTML. Later we used the
same idea for things which aren't actually tied to a specific location
in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a
better way to do this.

This commit starts reading from ParserOutput::getExtensionData(),
which was generated by the previous commit, and should be present
in all cached ParserOutput objects by the time we merge this.

Bug: T328980
Change-Id: I9f7a907836b86f25567fd4b352464d62d76e20e4
(cherry picked from commit 0ac420ecbc)
2023-02-11 21:16:03 -06:00
jenkins-bot f7e14aa719 Merge "Revert "Use setExtensionData() instead of marker comments where possible (2/3)"" 2023-02-12 03:12:41 +00:00
jenkins-bot 1439e2f2e2 Merge "Revert "Use setExtensionData() instead of marker comments where possible (3/3)"" 2023-02-12 03:07:28 +00:00
DLynch fb08abe062 Revert "Use setExtensionData() instead of marker comments where possible (2/3)"
This reverts commit 0ac420ecbc.

Reason for revert: this was supposed to be merged later; revert it now and reapply in a bit

Change-Id: I33fb07856152c2401b3a071c143f27f1e9753287
2023-02-12 02:57:31 +00:00
DLynch fc64dd29f7 Revert "Use setExtensionData() instead of marker comments where possible (3/3)"
This reverts commit ab40ef62c0.

Reason for revert: this was supposed to be merged later; revert it now and reapply in a bit

Change-Id: I7a1107143121f1f50bf25cb7a239cf9a76293d01
2023-02-12 02:56:55 +00:00
jenkins-bot 8322aa5d81 Merge "Use setExtensionData() instead of marker comments where possible (3/3)" 2023-02-12 01:09:16 +00:00
jenkins-bot 84ea64e752 Merge "Use setExtensionData() instead of marker comments where possible (2/3)" 2023-02-12 01:09:10 +00:00
jenkins-bot 7452f9ae32 Merge "Use setExtensionData() instead of marker comments where possible (1/3)" 2023-02-12 01:08:07 +00:00
jenkins-bot 5a9cb0c358 Merge "Move TOC metadata generation to a post-processing step" 2023-02-12 01:06:57 +00:00
Bartosz Dziewoński ab40ef62c0 Use setExtensionData() instead of marker comments where possible (3/3)
We started using marker comments (HTML comments with special content
inserted into the page) for the reply buttons back in the day, because
we needed to indicate their location in the HTML. Later we used the
same idea for things which aren't actually tied to a specific location
in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a
better way to do this.

This commit stop writing the HTML comments, which are no longer used,
and cleans up the tests.

Bug: T328980
Change-Id: Ic0d336dfbeb932134ec94bc0e86bc2a26921d440
2023-02-11 20:35:06 +01:00
Bartosz Dziewoński 0ac420ecbc Use setExtensionData() instead of marker comments where possible (2/3)
We started using marker comments (HTML comments with special content
inserted into the page) for the reply buttons back in the day, because
we needed to indicate their location in the HTML. Later we used the
same idea for things which aren't actually tied to a specific location
in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a
better way to do this.

This commit starts reading from ParserOutput::getExtensionData(),
which was generated by the previous commit, and should be present
in all cached ParserOutput objects by the time we merge this.

Bug: T328980
Change-Id: I4bf81ef3fd904f4d920d0756370c9bfa0a10a774
2023-02-11 19:33:20 +00:00
Bartosz Dziewoński 8fb467896f Use setExtensionData() instead of marker comments where possible (1/3)
We started using marker comments (HTML comments with special content
inserted into the page) for the reply buttons back in the day, because
we needed to indicate their location in the HTML. Later we used the
same idea for things which aren't actually tied to a specific location
in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a
better way to do this.

This commit starts writing data to ParserOutput::setExtensionData(),
which will be used in a later commit to be merged separately to avoid
issues with cached ParserOutput objects.

Bug: T328980
Change-Id: Ieb7bc3f83a402f9ebb096ed63336c77073bd2e7c
2023-02-11 20:19:55 +01:00
Translation updater bot 543dc77259 Localisation updates from https://translatewiki.net.
Change-Id: Ie542772b2aa6c492293f4d20d83a08948c2e3a40
2023-02-10 08:43:48 +01:00
Translation updater bot cf65033dee Localisation updates from https://translatewiki.net.
Change-Id: I9d2e31086acb0be1e7df158f06523a5dd532707e
2023-02-09 10:11:33 +01:00
Translation updater bot f19fb989b2 Localisation updates from https://translatewiki.net.
Change-Id: I5aa724d03340f2fec95b89bac5110611ce559df4
2023-02-08 08:39:39 +01:00
Bartosz Dziewoński 8eadff3b0d Optimize selectors in mobile hacks
See T328452#8587912

Bug: T328452
Change-Id: I584ef836d84cfa52ed003aae217c5c3b4e4ddbdd
2023-02-07 02:56:05 +01:00
Bartosz Dziewoński fce317ace4 Move TOC metadata generation to a post-processing step
Instead of generating the TOC HTML additions immediately, store
the data we need using ParserOutput::setExtensionData(), and use
the OutputPageParserOutput hook to fetch it and generate the HTML.

We check that the stored data is present before using it to avoid
issues with cached ParserOutput objects.

Bug: T328122
Change-Id: I7d4988cd568f10b7995a4d744e0ec6e7ce081b0e
2023-02-07 02:39:11 +01:00
Bartosz Dziewoński d0fb22a686 Special case opening new topic tool when VE or 2017WTE is open
Depends-On: Ica75f8334ef32ffbcc59109a46624acdf271847d
Bug: T317035
Change-Id: I87dc4b85df8deae5b16ae30a2ed054bfdcfdaa73
2023-02-06 23:04:10 +00:00
jenkins-bot daff9f6c27 Merge "Special:TopicSubscriptions: Perform unsubscribe asynchronously" 2023-02-06 23:01:01 +00:00
Ed Sanders a00d1b7a87 Hide (un)subscribe buttons when JS disabled
These buttons require JS to do anything. We can consider
providing a fallback action for subscriptions at a later date.

Change-Id: I9da546b2968e06d80c515eb5a05656a462b8201d
2023-02-06 22:36:14 +00:00
Translation updater bot 6907b603d2 Localisation updates from https://translatewiki.net.
Change-Id: I692393095c97e568bcd264ce2943eec0598b597d
2023-02-06 08:44:48 +01:00
Ed Sanders 15a8074002 Special:TopicSubscriptions: Perform unsubscribe asynchronously
Bug: T327662
Change-Id: Ib7f5cf8b075f44ac06c0a014aa1e200ccda8fe26
2023-02-04 14:30:14 +00:00
Translation updater bot e89840cbae Localisation updates from https://translatewiki.net.
Change-Id: Ib77ead8a89895d79c9e3a411ee43a63f656f1bfb
2023-02-03 08:47:38 +01:00
jenkins-bot f42b6db413 Merge "Always reset ReplyLinksController before re-initializing" 2023-02-02 18:04:11 +00:00
jenkins-bot c5ac63f921 Merge "Add comments about unwrapping Parsoid sections" 2023-02-02 17:57:53 +00:00
jenkins-bot d7f30dcd19 Merge "Restore autosave for new topic when only title was provided" 2023-02-02 17:57:02 +00:00