wikimedia/mediawiki-extensions-DiscussionTools

Fork 0

mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-17 05:10:50 +00:00

Commit graph

Author	SHA1	Message	Date
Bartosz Dziewoński	1c3fada1fb	Make CommentUtilsTest a proper unit test Documentation: https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests_for_extensions#Two_types_of_tests We can do this because the tested methods do not depend on any globals or on MediaWiki being installed. In addition to being the new hotness, MediaWikiUnitTestCase allows the test classes that use it instead of MediaWikiTestCase to start up much faster. In my testing, running this test case individually now takes 0.35s, compared to 1.1s before. Try: * With new code: time php tests/phpunit/phpunit.php extensions/DiscussionTools/tests/phpunit/unit/CommentUtilsTest.php * With old code: time php tests/phpunit/phpunit.php extensions/DiscussionTools/tests/phpunit/CommentUtilsTest.php Change-Id: I771b1f3d101a394ee869e42547d9ae7839397752	2021-02-02 15:37:17 +01:00
Bartosz Dziewoński	a29c49ae70	Better way to update expected test outputs Use an environment variable "DISCUSSIONTOOLS_OVERWRITE_TESTS". Change-Id: I017112b7d6b1df9497f01f3f97f34e0935ca16f8	2020-10-19 23:53:30 +02:00
Bartosz Dziewoński	a1dc3a4896	Correctly generate timezone abbreviations for parsing Also, add tests covering this and the previous bug fixes in this code (T259818, T261706). Note that the test data added in tests/cases/ doesn't exactly match the entire configuration of the wiki, only the parts we want to cover. This is unlike the data in tests/data/, which was literally copied from the relevant wikis, and which is used as input for other tests. Bug: T265500 Change-Id: I29a59a5952f6dc9fb5910434bb6bcc9dcdaa01a9	2020-10-15 12:11:25 +00:00

Author

SHA1

Message

Date

Bartosz Dziewoński

1c3fada1fb

Make CommentUtilsTest a proper unit test

Documentation:
https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests_for_extensions#Two_types_of_tests

We can do this because the tested methods do not depend on any globals
or on MediaWiki being installed.

In addition to being the new hotness, MediaWikiUnitTestCase allows the
test classes that use it instead of MediaWikiTestCase to start up much
faster. In my testing, running this test case individually now takes
0.35s, compared to 1.1s before.

Try:
* With new code:
  time php tests/phpunit/phpunit.php extensions/DiscussionTools/tests/phpunit/unit/CommentUtilsTest.php
* With old code:
  time php tests/phpunit/phpunit.php extensions/DiscussionTools/tests/phpunit/CommentUtilsTest.php

Change-Id: I771b1f3d101a394ee869e42547d9ae7839397752

2021-02-02 15:37:17 +01:00

Bartosz Dziewoński

a29c49ae70

Better way to update expected test outputs

Use an environment variable "DISCUSSIONTOOLS_OVERWRITE_TESTS".

Change-Id: I017112b7d6b1df9497f01f3f97f34e0935ca16f8

2020-10-19 23:53:30 +02:00

Bartosz Dziewoński

a1dc3a4896

Correctly generate timezone abbreviations for parsing

Also, add tests covering this and the previous bug fixes in this code
(T259818, T261706).

Note that the test data added in tests/cases/ doesn't exactly match
the entire configuration of the wiki, only the parts we want to cover.
This is unlike the data in tests/data/, which was literally copied
from the relevant wikis, and which is used as input for other tests.

Bug: T265500
Change-Id: I29a59a5952f6dc9fb5910434bb6bcc9dcdaa01a9

2020-10-15 12:11:25 +00:00

3 commits