wikimedia/mediawiki-extensions-DiscussionTools

Fork 0

mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-29 02:25:44 +00:00

Commit graph

Author	SHA1	Message	Date
Bartosz Dziewoński	2d3fe47ac1	Fix parsing localised digits in PHP discussion parser The PHP code incorrectly assumed that the digits are single-byte in UTF-8, which is never the case (except for 0-9). The JS code worked correctly because it uses UTF-16 strings, so the bug would only affect non-BMP digits there. This was noted in a TODO comment, but we overlooked it when reimplementing in PHP. Instead of a string of 10 characters, use an array of 10 single-character strings. Bug: T261706 Change-Id: Ic5421382474c88f003424799c53ff473d99cce92	2020-09-01 01:50:33 +02:00
Ed Sanders	c5d1029b25	Move /cases and /data up to /tests Theses are no longer QUnit specific. Change-Id: I5f3cca1ff686922e0cdaaedb80858f37df04799a	2020-05-18 21:47:17 +01:00

Author

SHA1

Message

Date

Bartosz Dziewoński

2d3fe47ac1

Fix parsing localised digits in PHP discussion parser

The PHP code incorrectly assumed that the digits are single-byte in
UTF-8, which is never the case (except for 0-9).

The JS code worked correctly because it uses UTF-16 strings, so the
bug would only affect non-BMP digits there. This was noted in a TODO
comment, but we overlooked it when reimplementing in PHP.

Instead of a string of 10 characters, use an array of 10
single-character strings.

Bug: T261706
Change-Id: Ic5421382474c88f003424799c53ff473d99cce92

2020-09-01 01:50:33 +02:00

Ed Sanders

c5d1029b25

Move /cases and /data up to /tests

Theses are no longer QUnit specific.

Change-Id: I5f3cca1ff686922e0cdaaedb80858f37df04799a

2020-05-18 21:47:17 +01:00

2 commits