wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-22 21:03:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
3986 commits 13 branches 4 tags 131 MiB
Commit graph

3986 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bartosz Dziewoński a1dc3a4896 Correctly generate timezone abbreviations for parsing 
Also, add tests covering this and the previous bug fixes in this code
(T259818, T261706).

Note that the test data added in tests/cases/ doesn't exactly match
the entire configuration of the wiki, only the parts we want to cover.
This is unlike the data in tests/data/, which was literally copied
from the relevant wikis, and which is used as input for other tests.

Bug: T265500
Change-Id: I29a59a5952f6dc9fb5910434bb6bcc9dcdaa01a9
 2020-10-15 12:11:25 +00:00
Bartosz Dziewoński fe520ab175 ImmutableRange: Remove unused variable 
The only use was removed in code review, but we missed this.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/596813/70..71/includes/ImmutableRange.php

Change-Id: Ia761a6a350711c32f0bd4c8af48c7c1a35a4afb4
 2020-10-15 11:23:43 +00:00
Translation updater bot 806340ab4c Localisation updates from https://translatewiki.net. 
Change-Id: I14b9b8542f10c90f932ad154d6f94dd6b1087eee
 2020-10-15 08:38:03 +02:00
jenkins-bot eaedf91fc0 Merge "tests: Fix some typos" 2020-10-14 22:49:38 +00:00
Bartosz Dziewoński c464d995c3 tests: Fix some typos 
Change-Id: I99b14b8aae7416bd7a25f563fb07e35dc98a39e7
 2020-10-14 22:14:59 +02:00
Translation updater bot 27139da557 Localisation updates from https://translatewiki.net. 
Change-Id: Ifc982df583b0522ec75009172bc890a82967044f
 2020-10-14 08:27:50 +02:00
jenkins-bot 8716fbf9e2 Merge "Add reply links on the server" 2020-10-13 20:46:53 +00:00
Translation updater bot b29124e30b Localisation updates from https://translatewiki.net. 
Change-Id: I4358f2e90fef9bb8b4124ba38f6e7c642472b5f9
 2020-10-13 08:42:12 +02:00
Translation updater bot 7ac0c82fd9 Localisation updates from https://translatewiki.net. 
Change-Id: I4a6891126a538ab70b9dfaea36f13fc35a02f3b8
 2020-10-12 08:34:53 +02:00
Ed Sanders 64392af485 Add reply links on the server 
Bug: T252555
Change-Id: I4e60fdbc098c1a74757d6e60fec6bcf8e5db37c1
 2020-10-08 13:27:08 +01:00
Ed Sanders dfdadee481 Simplify edit summary selection logic 
Always select the default reply if it looks unchanged, i.e.
we see '...*/ Reply' at the end of the summary.

Bug: T263062
Change-Id: I0a79d9e5072d9d9df16c93435502f67524e2d2bc
 2020-10-07 18:56:17 +01:00
jenkins-bot 485f9a4f8c Merge "Add 'id' attributes in the "wrappers" test case" 2020-10-06 22:39:42 +00:00
jenkins-bot f9276d6b84 Merge "Ignore other empty-ish things at the beginning of comments" 2020-10-06 00:34:31 +00:00
jenkins-bot 6d5b41ad2c Merge "Remove number when reading heading node" 2020-10-05 23:22:35 +00:00
Ed Sanders eeefd985d6 Remove number when reading heading node 
Bug: T264561
Change-Id: I0e6235f6b7169665e403fd6db1812fe90e8932b0
 2020-10-05 21:58:51 +01:00
Bartosz Dziewoński 9775a60ace Add 'id' attributes in the "wrappers" test case 
Change-Id: I40ca69586a915590e36dea45a90ab3f332931656
 2020-10-02 23:47:47 +02:00
Bartosz Dziewoński be2ec55114 Work around Chromium bug with triple-click selection and reply links 
Through trial and error, I found that adding `display: inline-flex;`
avoids the issue, and does not seem to have any negative effects in
Chromium or other browsers.

Bug: T260072
Change-Id: I9a9ca1fdb57bb7dd6c1a0a70e330a2a503c8ec8e
 2020-10-02 19:17:34 +02:00
Translation updater bot db328e3571 Localisation updates from https://translatewiki.net. 
Change-Id: I48bef47a30b39a0a71ac728cf7d7be3006b1416a
 2020-10-01 08:30:04 +02:00
Bartosz Dziewoński ed17f640b6 Ignore other empty-ish things at the beginning of comments 
Follow-up to 432a959436.

Bug: T264116
Change-Id: I0685cafab70c7e9d22f504f1a1309c9a28d6f2e1
 2020-09-30 23:42:47 +02:00
jenkins-bot 91e87eb09a Merge "Fix detecting username from the wrong links sometimes" 2020-09-30 18:18:02 +00:00
jenkins-bot f7c7ba3c44 Merge "Ignore empty paragraphs at the beginning of comments" 2020-09-30 18:16:36 +00:00
jenkins-bot 5c61b23be1 Merge "Update test case to match actual output" 2020-09-30 18:16:35 +00:00
jenkins-bot ff9137353c Merge "Ignore HTML comments which are more than two lines from a reply" 2020-09-29 23:18:11 +00:00
Bartosz Dziewoński 17b7a481a2 Fix detecting username from the wrong links sometimes 
When a timestamp directly followed a `<div>…</div>` tag (or perhaps
some other wrapper containing lots of content), we would detect the
username from the earliest links in the wrapper (furthest from the
timestamp), rather than the latest links (closest to the timestamp).

Bug: T262573
Change-Id: Id16449a86a731b13dc79846bb30ecf6554e26f1d
 2020-09-29 22:31:24 +02:00
Bartosz Dziewoński 432a959436 Ignore empty paragraphs at the beginning of comments 
The wikitext parser outputs `<p><br></p>` for empty paragraphs, so we
need to ignore `<br>` tags when searching for an "interesting" node
that marks the beginning of a comment. Otherwise the empty paragraphs
mess up the detection of indentation levels.

Bug: T264116
Change-Id: I84a97ab577baa7336b78935ccdc48041ecfc231a
 2020-09-29 22:22:35 +02:00
Bartosz Dziewoński 385a5c1622 Update test case to match actual output 
The tests pass either way because this trivial difference is ignored,
but it's annoying when trying to update changed tests.

Change-Id: I7ad1acad43e30a63843cfda4d0d08ff663ef3252
 2020-09-29 22:22:35 +02:00
Ed Sanders 6b8312e610 Ignore HTML comments which are more than two lines from a reply 
Bug: T264026
Change-Id: I989132d7599a7fa156dba46d87a9ed4b76322c0c
 2020-09-29 11:30:03 +01:00
Translation updater bot eaa0f2a5f0 Localisation updates from https://translatewiki.net. 
Change-Id: Ic9f54087244c1ce2e7f398f695e8e1e3aabb1963
 2020-09-29 08:19:24 +02:00
Translation updater bot 2eb5f853d8 Localisation updates from https://translatewiki.net. 
Change-Id: If80bf001d19d8000c59a992746e52c678840fb6f
 2020-09-28 08:29:05 +02:00
jenkins-bot 75a3a62f0a Merge "ReplyWidget: Pass initial config values to #setup, not to constructor" 2020-09-25 21:51:20 +00:00
jenkins-bot c6e69d586f Merge "Fix vertical alignment of action buttons when logged out" 2020-09-25 18:18:43 +00:00
Bartosz Dziewoński 48d5a67d41 ReplyWidget: Pass initial config values to #setup, not to constructor 
The same ReplyWidget instance can be re-used when the user cancels
replying and then starts replying again to the same comment.

Previously, the initial values passed to the constructor (when switching
modes) would still persist in this case, even if they were incorrect.

Bug: T263061
Change-Id: I3dff007456bfd4f3149c718ae72fbf373a2e2913
 2020-09-25 20:00:00 +02:00
Ed Sanders 06d42957a5 Fix vertical alignment of action buttons when logged out 
Bug: T263871
Change-Id: Id2c39b630ddbbd6232f67a161de3f74f36a7cd6b
 2020-09-25 17:54:00 +00:00
jenkins-bot 197f103081 Merge "Disable find-and-replace" 2020-09-25 16:58:17 +00:00
jenkins-bot e555f13a21 Merge "Fix debug mode after language variant changes" 2020-09-25 14:21:04 +00:00
Ed Sanders 6790e5c41c Disable find-and-replace 
Bug: T263570
Change-Id: I075c1696f179eed2e0143c12082cee048c200227
 2020-09-25 15:17:15 +01:00
Translation updater bot 6f59891196 Localisation updates from https://translatewiki.net. 
Change-Id: Ie953242e2130f54632a1970a7d4c5f8554c4afcc
 2020-09-25 08:21:19 +02:00
libraryupgrader 6daa4d37c9 build: Updating mediawiki/mediawiki-phan-config to 0.10.3 
Additional changes:
* Dropped .php5 files from .phpcs.xml (T200956).

Change-Id: I9380c9cf278caf91529c38a35a316bffbaef9d5a
 2020-09-25 00:22:53 +00:00
Bartosz Dziewoński ca41a405ec Fix debug mode after language variant changes 
Follow-up to 329df8c953.

Change-Id: I49f7d580a7e7c5dde7c234ca8905157e6a0f4f5d
 2020-09-24 19:49:04 +02:00
Translation updater bot 670bd1d2c3 Localisation updates from https://translatewiki.net. 
Change-Id: Ieb27a144fa3ea485624a10d032b790d8db8c5714
 2020-09-24 08:28:35 +02:00
Ed Sanders 2a03b6e420 Add JSON serialize methods 
Change-Id: Iaa24c39842cbe76370aaeba01eab2c991d290b8c
 2020-09-23 20:35:57 +01:00
Translation updater bot 221f5c5884 Localisation updates from https://translatewiki.net. 
Change-Id: Idd361065128c023458b75de9590880152f0e9e78
 2020-09-22 08:34:18 +02:00
jenkins-bot b1804fbb8b Merge "Add content getters to Thread/Comment items" 2020-09-21 22:35:24 +00:00
jenkins-bot 101dda4200 Merge "Implement cloneContents on ImmutableRange" 2020-09-21 22:35:23 +00:00
jenkins-bot e7206488a8 Merge "Collapse advanced drawer when clearing" 2020-09-21 21:08:03 +00:00
jenkins-bot db82dce31f Merge "Only reset summaryPrefixLength on user event" 2020-09-21 21:06:29 +00:00
jenkins-bot e4fa3d3593 Merge "Always send edit summary, regardless of visibility" 2020-09-21 21:06:28 +00:00
Ed Sanders e6b91ced43 Collapse advanced drawer when clearing 
Bug: T263061
Change-Id: Ibcd95ce1c86548962b9b7ff7b62bd0d127f53b76
 2020-09-21 20:52:47 +01:00
Ed Sanders f98c487f0b Update link in error message 
This page was moved from the Extension to the Help namespace.

Change-Id: I670e7535357d93414cf5abd14cd78dad4e53dca7
 2020-09-21 20:40:31 +01:00
Ed Sanders 9d3eea5fdf Only reset summaryPrefixLength on user event 
Bug: T263062
Change-Id: I323ce4dab0a430e2aeb906ae9cd5d6b48a179cff
 2020-09-21 20:39:21 +01:00