David Lynch
72680471ef
VisualEditorFeatureUse: trackdebug logging consistent with EditAttemptStep
...
The defaults weren't being included in the log output.
Change-Id: I455370cdb40e300efa6f41902b434affd32dc405
2020-07-20 17:26:53 -05:00
jenkins-bot
e89f58eddf
Merge "Customise abandon edit dialog copy"
2020-07-20 18:29:12 +00:00
jenkins-bot
6dcbaca9c1
Merge "Disable blockquote command"
2020-07-20 17:13:34 +00:00
jenkins-bot
271124d5cb
Merge "Create a PingNode so user pings are single focusable nodes"
2020-07-20 17:13:32 +00:00
jenkins-bot
187e3706b6
Merge "Move #getTranscludedFrom from parser to ThreadItem"
2020-07-20 17:13:31 +00:00
jenkins-bot
de2d54eab0
Merge "Move #getAuthors from parser to ThreadItem"
2020-07-20 17:13:30 +00:00
jenkins-bot
f845febf34
Merge "Documentation fixes"
2020-07-20 16:51:29 +00:00
Ed Sanders
a4636d39fc
Move #getTranscludedFrom from parser to ThreadItem
...
Also requires moving getTitleFromUrl to CommentUtils
Change-Id: I9cb83a3fdd456eba66899433b866ce7a7f00eeb5
2020-07-20 15:56:48 +01:00
Ed Sanders
7ae5bbf384
Move #getAuthors from parser to ThreadItem
...
Change-Id: I16e513000e5366b3044b17a99da07d8d0f47a61f
2020-07-20 15:13:59 +01:00
Ed Sanders
b32f991913
Documentation fixes
...
Change-Id: I2c7ccecbf8a50bd4d658b0f17f4a21fe90a3c399
2020-07-20 13:34:08 +01:00
Translation updater bot
d90a2de6af
Localisation updates from https://translatewiki.net .
...
Change-Id: I466afdd294493e1908ac784c68923e94c6cd2920
2020-07-20 09:00:57 +02:00
libraryupgrader
528f40151f
build: Updating grunt to 1.2.1
...
Change-Id: If40a827eee0af7de74c2a52f845ceb1ead2b4931
2020-07-18 05:12:33 +00:00
Ed Sanders
e4c11035a7
Disable blockquote command
...
Bug: T258194
Change-Id: I600abe0767f53c51e6f78f11a8087a6e29d4877f
2020-07-17 23:25:15 +01:00
Ed Sanders
e6f7a9e679
Create a PingNode so user pings are single focusable nodes
...
Bug: T252083
Change-Id: I168e036d201b924e7fc9bda2f2f58e48ad2dbac0
2020-07-17 23:17:41 +01:00
Ed Sanders
854c8e4b28
Customise abandon edit dialog copy
...
Bug: T257069
Change-Id: I2770b53f826b5af689051cc681a75f9608e85de9
2020-07-17 23:04:44 +01:00
jenkins-bot
e2573f7787
Merge "Increase padding around warning icon"
2020-07-17 15:51:53 +00:00
Translation updater bot
bc5e9b312e
Localisation updates from https://translatewiki.net .
...
Change-Id: Iadc2d38e28d3d1266547c0a0dee1cc6540cf9e1f
2020-07-16 08:21:02 +02:00
Bartosz Dziewoński
ee69365b82
Signature handling in visual mode
...
Load 'ext.visualEditor.mwsignature' (which implements VE's existing
handling for signatures), then subclass and override a bunch of things
in order to:
* Replace the context menu with a note that you don't need to type the
signature when commenting using the reply widget
* Override the sequence/command to insert signature so that it selects
it afterwards and thus displays the context menu
* Treat signatures as signature nodes when switching from wikitext,
instead of the normal pre-save transform turning them into regular
links and text
Bug: T255738
Change-Id: Icb542451c2307ab51e56bd627804096c7b5552c8
2020-07-16 01:32:19 +02:00
Ed Sanders
092cfd6075
Parser: Replace findTimestamps with findTimestamp
...
Instead of doing a separate tree walk and finding all timestamps
separately, make it part of the getComments tree walk, and find
timestamps one at a time.
Change-Id: I47f466eaf228504faa189fd99e07493bc7f022cd
2020-07-15 21:34:22 +02:00
Ed Sanders
981d3326aa
Add ime-position-inside ULS class to reply widgets
...
Bug: T255191
Depends-On: Ibcf7a4f076ceb86b91e81310bcb2fa64abc551dd
Change-Id: I0729933551cf5b73ca99718d54635caefdd0ee94
2020-07-15 18:27:02 +01:00
Bartosz Dziewoński
308c2747b0
CommentParser.php: Use tree walking instead of XPath
...
This is similar to what the JS version does.
The TreeWalker and NodeFilter classes are adapted from
https://github.com/Krinkle/dom-TreeWalker-polyfill
(MIT license).
This makes #getComments twice as fast on en-big-oldparser.html
Change-Id: I2441f33e6e7bad753ac830d277e6a2e81ee8c93d
2020-07-15 16:40:50 +00:00
Bartosz Dziewoński
08b467bf9f
tests: Fix wrong $rootNode in some tests using CommentParser::getComments()
...
Rather than the <body> node, we were passing <body>'s first child.
Current implementation of CommentParser::getComments() doesn't fail
the tests in spite of this because the XPath query incorrectly returns
results relative to the document's real root node, but these tests
would start failing after I2441f33e6e7bad753ac830d277e6a2e81ee8c93d.
Follow-up to 3e6ab2c4d2
.
Change-Id: Ic26e0a1ee4443987e215c5f26ef1f084ccd0b40b
2020-07-15 16:40:30 +00:00
jenkins-bot
01ce5afaa9
Merge "Fix highlighter styles: match sig/timestamps border sizes"
2020-07-15 15:29:33 +00:00
Translation updater bot
3a79aa25d6
Localisation updates from https://translatewiki.net .
...
Change-Id: Ie552f73317452df823d10b69152034777dcb63fd
2020-07-15 09:03:56 +02:00
Ed Sanders
3ef4c30e63
Fix highlighter styles: match sig/timestamps border sizes
...
Change-Id: Ie7b9809ca21c72a88487f208b9a9c41f65d4fe11
2020-07-14 23:17:29 +01:00
Ed Sanders
00042d8499
Remove DiscussionToolsEnableVisual config
...
Defaults to true and has no need to be disabled anymore.
Change-Id: I3cf9b5accea0fd1f175c75057641657742d8fa1b
2020-07-13 15:51:47 +01:00
Nikerabbit
4cf9e06974
Revert "Localisation updates from https://translatewiki.net ."
...
This reverts commit e6e5193a32
.
Reason for revert: Broken export
Change-Id: Ic7e2bf9db21ea60d47a180d6120c753146b8b0a2
2020-07-13 11:42:08 +00:00
Translation updater bot
e6e5193a32
Localisation updates from https://translatewiki.net .
...
Change-Id: I7ed83b0b65bf712a264245b6af65267c715e874c
2020-07-13 08:42:02 +02:00
Translation updater bot
5bb9d0194a
Localisation updates from https://translatewiki.net .
...
Change-Id: I688801d1d05713d7ac00dc0e48cfc1bae8603cb8
2020-07-10 08:25:36 +02:00
Ed Sanders
58aa412fa3
Don't allow switching when unsupported content used
...
Bug: T256150
Change-Id: I9b57996f069a1c0c05ef396cfe0ed81495a1d9ec
2020-07-09 13:05:09 +01:00
libraryupgrader
5d7aa9eea5
build: Updating lodash to 4.17.19
...
* https://npmjs.com/advisories/1523
* CVE-2019-10744
Change-Id: Ie3486b0814772427800c7b38b79ca7d8da59a0a5
2020-07-09 07:11:48 +00:00
Translation updater bot
66b0cc392b
Localisation updates from https://translatewiki.net .
...
Change-Id: I94c72dc720b7842b89374704c27c9ba90a1624d6
2020-07-06 09:51:15 +02:00
jenkins-bot
0bd5371737
Merge "Add getHeading method to CommentItem"
2020-07-03 03:23:16 +00:00
jenkins-bot
e1a85a4edd
Merge "CommentParser.php: Fix URL parsing"
2020-07-03 03:23:15 +00:00
jenkins-bot
0be56305fe
Merge "Move wikitext modifiers to modifier.js"
2020-07-03 03:23:14 +00:00
jenkins-bot
0f184c42b5
Merge "Move createCommentContainer to modifier"
2020-07-03 03:23:12 +00:00
jenkins-bot
c716ca9c7b
Merge "Move some postReply logic to modifier.js"
2020-07-03 03:23:11 +00:00
jenkins-bot
ddee6b600d
Merge "CommentController: Refactor postReply"
2020-07-03 03:23:09 +00:00
jenkins-bot
92481deeac
Merge "Wait for API response before updating suggestion list"
2020-07-02 16:38:49 +00:00
Ed Sanders
f650440445
Don't calculate call getValue on every keystroke in visual mode
...
This is a regression from when we added a wikitext parameter to
preparePreview. Calling getValue in visual mode converts the whole
DM to HTML, which is fairly expensive, especially as there are
no previews in visual mode.
Change-Id: Ieed61b0d7741e7204a942a7181923da0502981cd
2020-07-02 16:36:57 +01:00
Ed Sanders
c15399568f
Wait for API response before updating suggestion list
...
We can update the local filtered list before then, but then we would
have to do two updates for each keystroke, one to do an instant local
filter and another to back-fill the list when the remote results
become available. Currently CompletionAction is not set up for this,
and this might be confusing behaviour.
Bug: T256974
Change-Id: I6194cdcd6459be17fb142e644d73c9ec4036ba08
2020-07-02 15:12:30 +01:00
Ed Sanders
94511c6bad
Add getHeading method to CommentItem
...
Change-Id: I14ccdbb432e835fe74760a52f07de172df2aba27
2020-07-01 17:21:15 +01:00
Ed Sanders
ed70d49285
CommentParser.php: Fix URL parsing
...
Change-Id: I406fd98b308dd4d975ea974f2369737a7052b556
2020-07-01 17:06:02 +01:00
Ed Sanders
6459e7dc82
Move wikitext modifiers to modifier.js
...
Re-create methods in PHP.
Change-Id: Iae6117b65e3b8f50ecc68e1e3ea17c8359bdcb06
2020-07-01 17:06:02 +01:00
Ed Sanders
978eae5547
Move createCommentContainer to modifier
...
Refactor and create PHP versions.
Change-Id: I0ae9785e5fa86bcc1ac6eef9bce4088d7507dd33
2020-07-01 17:06:02 +01:00
Ed Sanders
fb0d2cbe7f
Move some postReply logic to modifier.js
...
Re-create the function in PHP
Change-Id: I1c8b505542c3b82c10b7b258e48054bc59cb4836
2020-07-01 17:06:02 +01:00
Ed Sanders
6d4d0962ef
CommentController: Refactor postReply
...
Separate out conversion to DOM nodes, and update
now that postReply doesn't need to return a promise.
Change-Id: Iab6192ba252244009d2374c9423d14279e8d1c4f
2020-07-01 17:06:02 +01:00
Translation updater bot
be9b43fd19
Localisation updates from https://translatewiki.net .
...
Change-Id: I54a8e13292ca19d9132e3344d47e42f54e5cf14b
2020-07-01 08:43:26 +02:00
Ed Sanders
b1fe481324
Increase padding around warning icon
...
Bug: T255558
Change-Id: Ie9c384a3233e5079dcb49fbf295a8c81596dc83d
2020-06-30 15:19:13 +01:00
Translation updater bot
e9ca361ee4
Localisation updates from https://translatewiki.net .
...
Change-Id: I4e00b4454ecaa5d9835310f156d0a55370c30689
2020-06-29 16:25:51 +02:00