wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-30 19:16:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
2388 commits 11 branches 4 tags 128 MiB
Commit graph

22 commits

Author SHA1 Message Date
Bartosz Dziewoński 2bc76dabd7 Enable transformations in preview mode 
We remove the [reply] and [subscribe] links when they should not be
visible (controlled by 'enableSectionEditLinks' option, which is
disabled when previewing).

Bug: T309423
Change-Id: Ie0d3fba2c4d166daac3ea2e117a246c9584284ca
 2022-07-07 23:37:56 +01:00
C. Scott Ananian 8e09b67c0d Move cache expiry update from ParserAfterParse to ParserAfterTidy 
The ParserAfterParse hook will likely be deprecated, as Parsoid can't
properly support it as-is.  Luckily, DiscussionTools isn't doing
anything in ParserAfterParse that couldn't happen in the (supported)
ParserAfterTidy hook.

Bug: T303630
Change-Id: If72feb1e277c09f4ea0df339f2dd097a9b329d71
 2022-03-15 12:19:57 -04:00
Ed Sanders 34011b7a07 Parser: Pass in title of page being parsed 
Will be used to parse selflinks in the future.

Change-Id: I2bc29d1c5c69cb6309f582f162f9af7d96ce8913
 2022-01-12 21:17:59 +00:00
Bartosz Dziewoński 695a966a41 Remove unused non-parser-cache mode 
Change-Id: Ief9f4153898b09a1ce15ccfdc8656dfad4642269
 2021-10-07 17:59:10 +02:00
Bartosz Dziewoński dbb8b00ec7 Remove parser cache splitting ('dtreply' option) 
Bug: T280599
Change-Id: I08b52874d575619308b5b83a39acfb6353c5b7b5
 2021-10-07 17:59:10 +02:00
Bartosz Dziewoński e3af0bc65b Replace marker comment with limit report data 
We always do our processing in the parser now, so we don't need the
marker comment to detect whether we've already processed the page.

Bonus: include the time taken by our processing in the limit report.

Bug: T291831
Change-Id: Ife7ddffbad1b1495b004739212002a98fdebe6c0
 2021-10-07 17:59:10 +02:00
Bartosz Dziewoński 4a824abd0d Apply page transformations only when viewing pages 
Follow-up to e634701460. We didn't need
this previously, because we relied on the ArticleParserOptions hook
only being called when viewing pages.

Context from code reviews a year ago:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/641837/comment/15ee0218_e4ab602f/
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/641837/comment/b62d4327_5ebc2e02/

Bug: T291459
Bug: T291460
Change-Id: I64f0be170719d874f5460934462917f4f13af6c1
 2021-09-21 10:19:42 +02:00
Bartosz Dziewoński e634701460 Always apply DiscussionTools page transformations 
Bug: T273072
Bug: T280599
Change-Id: I0b39ef2f9ede15905951a54c043dd228bd5ace9f
 2021-09-08 00:16:30 +02:00
Bartosz Dziewoński ce899aaadd Inject services in hook handlers where possible 
Change-Id: Ie5c36cabd90412d2299b00d2b0c3c3bdf9ffc6d6
 2021-09-07 22:51:35 +02:00
Bartosz Dziewoński 3e19fce67a Load styles in ParserOutput too 
We load them in OutputPage, because we need that to handle the
query parameter 'dtenable=1', but do it here as well just in case
the pages are somehow shown without involving OutputPage.

Per code review:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/713681/1/includes/Hooks/ParserHooks.php#90

Change-Id: I3f287a9e146de7fd4d37c47dfa47eeb03eeb8cf1
 2021-08-20 18:49:04 +02:00
vladshapik 613b0a9b27 Avoid using deprecated ParserOptions::getUser 
Bug: T287858
Change-Id: I13ef6ef128a8316f699c6e038adf82d18bf81b96
 2021-08-10 16:43:11 +03:00
libraryupgrader b0884b177c build: Updating dependencies 
composer:
* mediawiki/mediawiki-codesniffer: 36.0.0 → 37.0.0

npm:
* postcss: 7.0.35 → 7.0.36
  * https://npmjs.com/advisories/1693 (CVE-2021-23368)
* glob-parent: 5.1.1 → 5.1.2
  * https://npmjs.com/advisories/1751 (CVE-2020-28469)
* trim-newlines: 3.0.0 → 3.0.1
  * https://npmjs.com/advisories/1753 (CVE-2021-33623)

Change-Id: I7a71e23da561599da417db3b3077b78d91173bbc
 2021-07-22 16:29:04 +00:00
jenkins-bot ea98787f41 Merge "Apply transformations in ParserCache for all CommentFormatter features" 2021-06-01 19:24:04 +00:00
Timo Tijhof 54eb6691fa Allow talk pages to have a different ParserCache expiry 
Using `updateCacheExpiry()` in this way appears to be established
with examples of other use in WMF production such as:
- CategortyTree extension:
  custom cache expiry for pages with `<categorytree>`.
- RSS extension:
  custom cache expiry for pages with `<rss>`.
- intersection extension:
  custom cache expiry for pages with `<DynamicPageList>`.
- Math extension:
  custom cache expiry if `<math>` failed.
- Wikibase extension, Flow extension:
  no caching for certain namespaces or content types.
- Graph extension, Kartographer extension:
  via onParserAfterParse hook, no caching if on preview.

Bug: T280605
Change-Id: Iea41ab8599ffae4622c97d682258b1b64eaf9ba2
 2021-05-14 16:59:09 +00:00
Ed Sanders 911f1a68bd Apply transformations in ParserCache for all CommentFormatter features 
i.e. for topic subscriptions as well as the reply tool.

Change-Id: I0a9e1a15e5a11adce0e1c55481fef0f4549360a6
 2021-05-03 15:05:35 +01:00
Ed Sanders 888d554ecf Don't split parser cache when reply tool is enabled by default 
Bug: T279864
Change-Id: I16f1546e1373311563b8a90d6a025b0b45ffb793
 2021-04-21 11:57:37 +00:00
Ed Sanders 722a4e5198 Avoid splitting ParserCache on user language 
Bug: T280295
Change-Id: I87eab83803d24c11db4d723377bf7b40390b2e70
 2021-04-21 11:57:30 +00:00
Bartosz Dziewoński 4bbfe6cb5d Rename CommentFormatter::addReplyLinks 
Bug: T280351
Change-Id: I0d7627d63407e11cca6091f78e4d440eec6efa91
 2021-04-21 11:24:03 +00:00
Ed Sanders f6c9508001 Create constants for feature strings 
Change-Id: I2d7bf18faf6345a4816c2ebef9744c4e6f62cc40
 2021-04-12 14:40:51 +00:00
Ed Sanders 6c3dd3aaa9 Move Hooks to HookUtils 
Now that all the real hooks have been separated out

Change-Id: Ibdb42f98614fc551068f8f8e5297dcc99251ab46
 2021-02-01 22:35:11 +00:00
Ed Sanders 2908c2808d Move Hooks::addReplyLinks to CommentFormatter 
Change-Id: I9f5483cd801f48efff22cba045ae6851da9719fd
 2021-02-01 22:35:04 +00:00
Ed Sanders bf51f1f65c Use new HookHandler system and group hooks by purpose 
Bug: T273303
Change-Id: I2d940e1944a9d7686bf7bc544a318c88c0b2afad
 2021-02-01 22:34:57 +00:00