Commit graph

4216 commits

Author SHA1 Message Date
Bartosz Dziewoński e3e36e11ac Remove client-side timeout when saving pages
Bug: T249071
Change-Id: I367c5931c05cf944bfad0f9fff69f06b32880411
2020-04-20 23:29:10 +02:00
Ed Sanders 0f7eb2e36a Add "watch this page" checkbox
Bug: T245222
Depends-On: I1e0e9bb9da53a62f8a20126e579dcd6300bd2376
Change-Id: If966d2fa97648452a50a2318988a8b64d7c449cd
2020-04-20 12:40:44 +01:00
Translation updater bot 8fe44239f0 Localisation updates from https://translatewiki.net.
Change-Id: Ia01d569301438dc2ac350d287b2534b68d7b9b16
2020-04-20 08:41:17 +02:00
Ed Sanders 5565c7e4f0 Enable on all ExtraSignaturesNamespaces
For most Wikimedia wikis, this is Project (Wikipedia) and Help.

Bug: T249036
Change-Id: I535240dc5232b78f11d5003d1141ad8114f01be2
2020-04-19 14:53:40 +01:00
libraryupgrader 3b049210f0 build: Updating grunt-banana-checker to 0.9.0
Change-Id: Iea10293c46ef9f83fb68b634dc25fa5921da1a98
2020-04-19 03:36:51 +00:00
Translation updater bot 6f0e5d86f4 Localisation updates from https://translatewiki.net.
Change-Id: I32ab26e3fbd2819d651c4dc3b14ce7abecba8f40
2020-04-17 09:06:35 +02:00
Translation updater bot c6e365d332 Localisation updates from https://translatewiki.net.
Change-Id: I995ded03f89a2a56ff8336681e7b70485f6c423b
2020-04-16 08:50:31 +02:00
Translation updater bot e23b4ef3f3 Localisation updates from https://translatewiki.net.
Change-Id: Iad64b71f1d12f3295f16713125278d27632159d5
2020-04-15 08:23:40 +02:00
Ed Sanders ba89657994 Add a share feedback link
Bug: T249016
Change-Id: I64abeebeea332a7a4a37fd4bfd6d5f9a5defc8b5
2020-04-14 23:04:18 +00:00
Ed Sanders d40e427b5b Remove extra linebreaks from wikitext
Extra lines currently render empty list items which are invisible.
Remove these as the user probably didn't intend from them to appear
in the wikiext.

Bug: T249867
Change-Id: I75c1192a94b918783d362d38cd91a508bb169d56
2020-04-14 20:29:38 +00:00
Ed Sanders f04abd02d4 Improve autosign handling of 3/5 tilde sigs and add tests
3 or 5 tilde signatures will be assumed to be erroneous and fixed
to 4 tilde signatures. This will be visible in the preview so shouldn't
come as a suprise to users.

Bug: T245628
Change-Id: I741f0761a6fb10c99cf3239ac5c6c7e1a2b872c7
2020-04-14 20:29:31 +00:00
Ed Sanders 5597787eb4 ReplyWidget: Replace .mode with #getMode
.mode was only set the end of the constructor.

Change-Id: I1a14167d1b2e524742da31f78c6cbfaf96aec667
2020-04-14 19:42:29 +00:00
jenkins-bot c5e9185ae7 Merge "DiscussionToolsHooks: Only enable when viewing pages" 2020-04-14 15:29:04 +00:00
Translation updater bot d118f82003 Localisation updates from https://translatewiki.net.
Change-Id: If723b84c780154f9a10cdf348dd38ac03378c12a
2020-04-14 08:23:29 +02:00
jenkins-bot 3886ae6398 Merge "Add override config for instrumentation rates" 2020-04-13 20:15:28 +00:00
David Lynch e38aad96e4 Add override config for instrumentation rates
Bug: T250086
Change-Id: I32fbf3d6562fb0a93698a24bbd8177149a19fed3
2020-04-13 12:38:40 -05:00
Translation updater bot 850018b1c6 Localisation updates from https://translatewiki.net.
Change-Id: Ic5ccea73dd013f401e1e1591ab8f5bdeb8fb188a
2020-04-13 09:00:15 +02:00
Translation updater bot 7ba060dcd7 Localisation updates from https://translatewiki.net.
Change-Id: I58aba493b8b87feb3de07eef52dc2a88c47f6e41
2020-04-10 09:51:19 +02:00
Translation updater bot 371722ea40 Localisation updates from https://translatewiki.net.
Change-Id: Icecd16835884d14b0b9d1d1289051ddde01e3d84
2020-04-09 08:38:39 +02:00
Translation updater bot 784eb23736 Localisation updates from https://translatewiki.net.
Change-Id: I9f794e39700d102dc84ff44bcfb2042b98e925c3
2020-04-08 08:23:17 +02:00
Translation updater bot fa279f7507 Localisation updates from https://translatewiki.net.
Change-Id: I34c1046e79e104c957a0ab44d151e0f3b75c546d
2020-04-07 08:39:27 +02:00
Translation updater bot daadf25964 Localisation updates from https://translatewiki.net.
Change-Id: I34741fbe3c8eddeffe157e3936978c00ed57c478
2020-04-06 09:01:44 +02:00
Bartosz Dziewoński 55b43a70d4 Fix skipping to the end of the paragraph when there is no wrapper
Bug: T249217
Change-Id: I77847901d98f56dbcbcf379c6c17f41e06a3a939
2020-04-03 18:11:59 +00:00
jenkins-bot 660c9421f7 Merge "Remove Parsoid section wrappers before finding transclusions" 2020-04-03 14:07:46 +00:00
jenkins-bot 6b70d7b652 Merge "Remove dependency on 'ext.visualEditor.core.utils'" 2020-04-03 14:07:46 +00:00
jenkins-bot fecc23ecd7 Merge "Rename tests/qunit/utils.js to .../testUtils.js" 2020-04-03 14:07:45 +00:00
jenkins-bot 6020bef2b6 Merge "Save the reply directly to the transcluded page" 2020-04-03 14:07:44 +00:00
Translation updater bot 6c20d878fa Localisation updates from https://translatewiki.net.
Change-Id: Iffc943c6b0a966711642b90a87815a3b6ecc9e63
2020-04-03 08:28:20 +02:00
jenkins-bot dd8eee7b38 Merge "Treat pages with __NEWSECTIONLINK__ as talk pages" 2020-04-02 21:37:14 +00:00
Ed Sanders 13777278ff Bump MW dependency to 1.35
For example we are using Id7565018.

Change-Id: Idc453dd6b770e4a67e88b0d576dfa06ffcc136f0
2020-04-02 19:17:21 +01:00
Translation updater bot 47947d72d5 Localisation updates from https://translatewiki.net.
Change-Id: I618048edc612a5e5e4e5c9ead43b3fc2ef7eace8
2020-04-02 08:24:23 +02:00
Bartosz Dziewoński 3bd513374e DiscussionToolsHooks: Only enable when viewing pages
Previously we'd also run on action=history, action=info etc. (which did nothing).

Change-Id: I4bd10311a91433f357a6f5506c65364d399f3915
2020-04-01 22:48:51 +02:00
Ed Sanders bcd3fbfe9a Treat pages with __NEWSECTIONLINK__ as talk pages
Bug: T245890
Change-Id: Ibb9f6c675ce26c5a0e6e7934bd4659f5aaae6a25
2020-04-01 14:34:05 +01:00
jenkins-bot f92e07687f Merge "parser: Make #getTranscludedFrom return page title in text form" 2020-03-31 13:26:38 +00:00
libraryupgrader d3a5508f1b build: Updating gonzales-pe to 4.3.0
* https://npmjs.com/advisories/1179

Change-Id: I29b834bff150c980753e67db04066b17d449b13e
2020-03-31 02:29:52 +00:00
jenkins-bot f048b3fc50 Merge "Localisation updates from https://translatewiki.net." 2020-03-30 07:25:02 +00:00
Translation updater bot e79e8adf73 Localisation updates from https://translatewiki.net.
Change-Id: I218a77e9dfeb6d84045cf193096e462c7d9e8651
2020-03-30 09:13:36 +02:00
Translation updater bot e7a70661c3 Localisation updates from https://translatewiki.net.
Change-Id: I7252cd98b885e0af536d7f7357a7fc379ac75421
2020-03-30 08:38:53 +02:00
Bartosz Dziewoński a14293c8e7 Remove Parsoid section wrappers before finding transclusions
The section wrappers can be marked as template-affected when the
previous or next section is transcluded, causing comments to be
unnecessarily uneditable. The new test case demonstrates this.

Depends-On: I03bc455d5484a6c51f3fa2397c64936b829fe7e3
Change-Id: I895a04990d79a3475d778b4fef054ea0bb076f0b
2020-03-24 23:31:21 +01:00
Bartosz Dziewoński bb2b2f2648 Remove dependency on 'ext.visualEditor.core.utils'
We only need ve.resolveUrl, which has been moved
to 'ext.visualEditor.core.utils.parsing'
in Ib2911aaed02250e79a2238ce0a6080a34165d636.

Depends-On: Ib2911aaed02250e79a2238ce0a6080a34165d636
Change-Id: I054026fbfd67f9a64cc0d748b57693fc2237ff08
2020-03-24 22:30:02 +00:00
Bartosz Dziewoński 216516f719 Rename tests/qunit/utils.js to .../testUtils.js
We now also have modules/utils.js and I found the identical name confusing.

Change-Id: I6895748528241e0368a79eab9dcf3123afaf5f87
2020-03-24 22:29:48 +00:00
Bartosz Dziewoński 807afd1ec0 Save the reply directly to the transcluded page
* When we discover the comment comes from a transcluded page, follow
  the transclusion to find the source page. We follow transclusions
  recursively, up to an arbitrary limit of 10.
* In the reply widget, display the title of the page where we will
  save the reply, to avoid users confused why their edit won't show up
  in the history. In the wikitext workflow this is done by redirecting
  the user to the edited page at the end, but it seems less surprising
  to stay on the current page.
* After saving the reply, we must purge the current page, otherwise
  the new content will not be immediately visible on it.

Bug: T247535
Change-Id: I1c6631aa65a2fce6c1c2f0dd4a8c7aa6389caf94
2020-03-24 22:29:42 +00:00
Bartosz Dziewoński dab37fd7b4 parser: Make #getTranscludedFrom return page title in text form
It's more convenient for display or comparing it with other things.

Depends-On: I03bc455d5484a6c51f3fa2397c64936b829fe7e3
Change-Id: I88d7aa68977210b16860075ed52983a5e99ee0f7
2020-03-24 22:29:35 +00:00
Translation updater bot be609d1f9a Localisation updates from https://translatewiki.net.
Change-Id: I79cd0552ede738de728c9cecbce2f0fff3cf70a0
2020-03-24 08:49:00 +01:00
Translation updater bot 672e678598 Localisation updates from https://translatewiki.net.
Change-Id: If299b4f38c4c26adbb136d1d713a79c5023e92ff
2020-03-23 09:02:54 +01:00
libraryupgrader 19b8d8ef3f build: Updating npm dependencies
* mkdirp: 0.5.1 → 0.5.3
  * https://npmjs.com/advisories/1179
* eslint: 6.5.1 → 6.8.0
  * https://npmjs.com/advisories/1179

Change-Id: I50ea09f3d841ff08810d6a5371112edd7227cc39
2020-03-20 22:13:16 +00:00
jenkins-bot 85472b7e31 Merge "ReplyWidget: Double-check that we can post before posting" 2020-03-20 19:37:48 +00:00
jenkins-bot 5b8b801989 Merge "Use 'baserevid' instead of 'basetimestamp' for edit conflict detection" 2020-03-20 19:30:15 +00:00
Bartosz Dziewoński 7fcd880fa5 controller: Fix minor issues with error popup
The rejection handling callback was accidentally resolving the
promise, which resulted in an error like 'TypeError: Cannot read
property '$element' of undefined' when the resolution value was
used.

Fixing this reveals that we weren't removing the placeholder list
element correctly. This wasn't immediately visible because of the
.empty() call in the next resolution callback, but it would have
caused something similar to T245574.

Follow-up to 6964f0c965.

Change-Id: I3aeb9a86046c4ccaa6c39301edc7285d02b0320c
2020-03-20 19:01:03 +00:00
jenkins-bot 1705e61adf Merge "Also update 'jsconfigvars' when previewing" 2020-03-20 11:26:50 +00:00