wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-01 03:26:28 +00:00
Code Issues Packages Projects Releases Wiki Activity
2351 commits 11 branches 4 tags 128 MiB
Commit graph

14 commits

Author SHA1 Message Date
Ed Sanders 0ad9b4c6b2 Move placeholder heading level (99) to a constant 
Change the HeadingItem constructor to take a 'null' headingLevel
and store this internally with the constant. Change the JSON
serializer to convert this back to null.

Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
 2022-06-14 22:51:49 +01:00
David Lynch 71049f4ce8 Add item name to the JSON output of HeadingItem 
The name is needed for the topic subscription API

Bug: T285971
Change-Id: Iedbebdfd65d03ab01b22b35781803655749aa269
 2022-03-25 11:45:50 +00:00
David Lynch 7275377b3c Talk API for apps 
Exposed as DiscussionToolsPageInfo prop threaditemshtml. It returns a
version of the output of CommentParser, lightly adjusted to provide a
nested comment structure rather than a pure flat list.

Bug: T285971
Change-Id: I2f8503d4ed740a04fb2f1e3a37ae4db649b3faba
 2022-03-21 16:40:45 -05:00
Bartosz Dziewoński 08c79142fb ImmutableRange: Add @property annotations for magic props 
Phan can analyze them now and reports some issues with types.

* Add some assertions on types where we're sure that we're using an
  Element or non-null, but Phan can't prove it
* Fix incorrect type hints on getFullyCoveredSiblings() and
  getCoveredSiblings(), luckily it was harmless

Change-Id: I8cc12450378efa7434c4d66882378b715edd4a70
 2022-03-08 23:29:40 +00:00
Bartosz Dziewoński eb1fe7a8fb CommentParser: Fix redundant uses of getHeadlineNodeAndOffset() 
We call CommentUtils::getHeadlineNodeAndOffset() before constructing
the HeadingItem in CommentParser, so the range's startContainer
is always the headline node.

Change-Id: I2afb6ba9100e785cd91f31d82f4cea59fa8b5443
 2022-03-08 23:29:34 +00:00
Bartosz Dziewoński 8f937eb9da Prevent assertion failure caused by empty headings 
Follow-up to 8de940b587.
See also 8b426c7e5c.

Bug: T299583
Change-Id: Ibd2c459330cfc7664bd36d7840209779450d72d4
 2022-01-20 18:56:32 +00:00
Bartosz Dziewoński 8b426c7e5c Fix placeholder headings causing exceptions in getTranscludedFrom() 
Follow-up to 8de940b587.

Change-Id: Iddf045105fac6ab8cdaa933fd2abcf6dbbd37d42
 2022-01-11 23:24:45 +00:00
Bartosz Dziewoński 0ae97ef550 Deduplicate logic for subscribable headings 
Change-Id: I1cd96cf0bcce2101455702f1350d8a4336c60790
 2021-09-07 21:38:35 +00:00
libraryupgrader b0884b177c build: Updating dependencies 
composer:
* mediawiki/mediawiki-codesniffer: 36.0.0 → 37.0.0

npm:
* postcss: 7.0.35 → 7.0.36
  * https://npmjs.com/advisories/1693 (CVE-2021-23368)
* glob-parent: 5.1.1 → 5.1.2
  * https://npmjs.com/advisories/1751 (CVE-2020-28469)
* trim-newlines: 3.0.0 → 3.0.1
  * https://npmjs.com/advisories/1753 (CVE-2021-33623)

Change-Id: I7a71e23da561599da417db3b3077b78d91173bbc
 2021-07-22 16:29:04 +00:00
Ed Sanders 79c91c3cfc Move ID->title logic into HeadingItem 
Change-Id: I03408d2404a99b5bc7795c1c4bf214d4b5fea1e0
 2020-11-05 16:10:39 +00:00
Bartosz Dziewoński 3137d76f40 Connect sub-threads to their parent threads 
Our threads now also contain all replies to their sub-threads.
This is similar to how sections work in MediaWiki, where the parent
section also contains the content of all the lower-level sections.
We're going to need this for notifications about replies in a thread.

Bug: T264478
Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
 2020-10-22 02:05:02 +02:00
Ed Sanders 2a03b6e420 Add JSON serialize methods 
Change-Id: Iaa24c39842cbe76370aaeba01eab2c991d290b8c
 2020-09-23 20:35:57 +01:00
Ed Sanders d5376e28fc Improve ThreadItem documentation 
Change-Id: Ia266fc22b02af0edbb32f356b4e0d92fe3a4da5f
 2020-06-26 14:56:19 +02:00
Ed Sanders 7be0cc3209 Create ThreadItem classes 
Change-Id: Id2c5324d74eccb1209ccb76768c557722c6d9400
 2020-06-12 20:35:59 +01:00