4 commits

Author	SHA1	Message	Date
Ed Sanders	664d5d041a	Fix fetching of oldest comment in a thread ... The implementation in Parser doesn't descend into sub-thread. Re-use the getThreadSummary method in ThreadItem and traverse the thread properly. Bug: T298617 Change-Id: I318d9012eb83f37ccbe463923524ef2e9f995ced	2022-09-01 21:22:09 +00:00
Bartosz Dziewoński	ddd391b6db	Ignore "tracked" templates at the beginning of comments ... This improves the behavior when replying to these comments and the message snippets shown in notifications. Bug: T313097 Change-Id: Ia10400472c9e999fa526c7437a03b72461c37b74	2022-07-31 03:56:36 +02:00
Bartosz Dziewoński	91e1bb15cc	Use Sanitizer::stripAllTags() when generating notification snippets ... It adds white-space between block tags and strips invisible tags. It may be slightly slower (it takes HTML as input rather than DOM, so we need to serialize the HTML first and then call it, rather than only find and concatenate text nodes), but the difference is negligible, and it seems better to use this method than to try to re-implement it. Test runtime went from ~9.0s to ~9.5s locally, when testing using: php tests/phpunit/phpunit.php \ extensions/DiscussionTools/tests/phpunit/ThreadItemTest.php \ --filter getText Bug: T219138 Change-Id: I0cb89ebd2160e1ef499b78573c6688f493a4c42f	2022-02-10 22:23:24 +01:00
Bartosz Dziewoński	a6a547f2b2	Add some tests covering ThreadItem::getHTML() and related methods ... * ThreadItem::getText * CommentItem::getBodyText (used when generating notifications) * ThreadItem::getHTML (may soon be used in API) * CommentItem::getBodyHTML (may soon be used in API) * ImmutableRange::cloneContents (the common implementation for all of the above) The outputs are only lightly reviewed. This is mostly meant to document the current behavior rather than the expected behavior, to avoid making unintentional changes while refactoring. Change-Id: I14471ee4969aa3d0b5577d9de2a6d4462fab4d09	2021-08-24 07:54:09 +02:00