Ed Sanders
f895d9426e
Add !important rule to mobile margin overrides
...
An upstream change in specificity caused a bottom
margin of 0.5em to start applying.
Bug: T381651
Change-Id: If68464b431202b657102223b61342eaa4c50f24a
2024-12-06 11:35:49 +00:00
jenkins-bot
8c5dad68a2
Merge "Don't prevent default on mobile heading clicks"
2024-11-28 21:43:37 +00:00
jenkins-bot
b26d84bfd6
Merge "CommentController/NewTopicController: Always use replyWidgetPromise"
2024-11-27 03:56:11 +00:00
Ed Sanders
042c0a1a40
Don't prevent default on mobile heading clicks
...
This greatly increases the size of the click target
for exanding a section, which is the most common
action to be taken.
Bug: T380896
Change-Id: Ib88e90f6eeee03f7559c78c0ef3dde3956cfd125
2024-11-26 17:20:34 +00:00
Ed Sanders
a4a335e6a9
CommentController/NewTopicController: Always use replyWidgetPromise
...
Remove the replyWidget property so users always have to use the
replyWidgetPromise.
Assume that the controller is setup immediately and so the
replyWidgetPromise will always be available.
Change-Id: Ib63952d745033721cac448feda9310e691c60090
2024-11-26 11:58:03 +00:00
Ed Sanders
61a79ecb5e
Remove unnecessary context variable
...
Change-Id: Ibfc0fc82f13f8268b8f4d48fd7d5f435c2e402f6
2024-11-25 17:15:58 +00:00
Bartosz Dziewoński
d516f625c7
Fix forwarding promise rejection arguments
...
Follow-up to arrow functions refactoring
(a74c00ba8c
2024-11-14 22:32:05 +01:00
Bartosz Dziewoński
8037be606b
Do not embed the "You have been subscribed" popup image
...
The image is somewhat heavy and only rarely shown (once per user).
Also move the dark mode styles to the same place.
Change-Id: I1f0d37e3f4e1161190ce6ffa549bfa52ced9b0e6
2024-10-11 22:35:48 +02:00
matr1x-101
2f4d87df77
Add dark mode version of SVG image for "You have been subscribed" popup
...
Bug: T369834
Change-Id: I2a73b02e2f5f737ff521c6f21d32aae72a83b322
2024-10-11 20:31:30 +00:00
James D. Forrester
0bfecf9118
build: Provide SVGO for crunching SVG files
...
Stolen from Codex's version.
Change-Id: Iee6408c42ae2ef13eeadbbf74ec3132c77974279
2024-10-10 18:17:01 -04:00
jenkins-bot
17c33d17b2
Merge "Simplify direction specific styles using margin-inline"
2024-10-07 19:27:59 +00:00
Ed Sanders
31dc9b4e1c
CommentController: Merge (mode, hideErrors, suppressNotifications) into options
...
Change-Id: Ib8b75fd44fcf560d30e2a6a6f79a9e833c0e5200
2024-10-07 13:39:10 +01:00
Ebrahim Byagowi
ba6ce4f7aa
Simplify direction specific styles using margin-inline
...
Bug: T371265
Change-Id: I25046b9982954f47a417a40f8a39c8a4e2f4c6a8
2024-10-07 00:34:25 +03:30
jenkins-bot
376e862288
Merge "Use standard font sizing for DT advanced toggle menu and license description"
2024-10-01 11:11:26 +00:00
jenkins-bot
b7251a9412
Merge "Support modern message box markup"
2024-10-01 00:09:38 +00:00
Jon Robson
b0cf419f19
Support modern message box markup
...
The class mw-message-box-warning was replaced with
cdx-message--warning.
Change-Id: I6862aab8980e76372e8f5d974e37ee6f5358e22c
2024-09-30 23:41:59 +00:00
Iniquity
b35ea7c65d
Use standard font sizing for DT advanced toggle menu and license description
...
Bug: T356574
Change-Id: I30d635b0fb24fb6ad2761a4970c0cb2586481efe
2024-09-30 17:39:19 +00:00
Ed Sanders
293cd13018
Fix margins in footer
...
Vector 2022 increased paragraph bottom margin to 1em.
Reset this to 0.5em.
Also don't append an empty links list.
Change-Id: I18b17824cc1093dbf61b354309144be8d9d74643
2024-09-26 17:24:15 +01:00
jenkins-bot
f5f94a9456
Merge "Fix some dark mode issues on mobile"
2024-09-17 01:38:21 +00:00
David Lynch
bb418d6b60
Don't startPoll if there's not a subscribable heading, i.e. New Topic
...
Any save errors wouldn't be shown -- most visibly, this meant any new
topic requiring a captcha couldn't be submitted.
Follow-up to 890cec73b6
2024-09-16 19:26:25 -05:00
Taavi Väänänen
53b77ea9ac
Fix some dark mode issues on mobile
...
Change-Id: I2f2c9da258467a3b1610c25661baa9fdb064f8fd
2024-09-15 11:30:24 +03:00
Ed Sanders
f52841a9e2
Use fixed font size for UI components in Vector 22
...
Bug: T373875
Change-Id: If0e71a7aaf1ea1e0315fc80999541019b3990bb0
2024-09-06 14:53:02 +01:00
Bartosz Dziewoński
890cec73b6
Pause polling for new replies while saving
...
Also fix stopPoll() not really stopping the polling if a request was
in progress while it was called.
Bug: T333576
Change-Id: Ie8f6f006c6fd23971e53586e6219992db23f48fc
2024-08-28 18:55:30 +02:00
Bartosz Dziewoński
f76e47a3ef
Keep sending CAPTCHA info if an unrelated save error happens
...
Bug: T371041
Change-Id: I72c73b0e323c794578edb14efcc9cc06e46a194b
2024-08-27 23:55:15 +02:00
Bartosz Dziewoński
4ff5bf253d
Reattempt the save when something already created a temporary account
...
Bug: T368263
Change-Id: I2adcb83017daff578627aa02b04934be21eade44
2024-08-27 23:49:48 +02:00
Bartosz Dziewoński
5bb03b9e7f
Fix missing definition of setSaveErrorMessage too
...
Follow-up to 6a17f6121c4ec197a8cb
2024-08-27 23:15:06 +02:00
David Lynch
4ec197a8cb
CommentController: fix a call to a missing setSaveErrorMessage
...
Follow-up to 6a17f6121c
2024-08-26 09:15:21 -05:00
jenkins-bot
182c247930
Merge "Show confirmation prompt if trying to submit a new topic without a title"
2024-08-12 17:02:08 +00:00
Jon Robson
f065c46e6b
Dark mode styles should not apply to printed content
...
Bug: T371331
Change-Id: I5bd5e530d1262c7e52e1725959e07776ff9f3704
2024-08-08 20:32:16 +00:00
jenkins-bot
8c9ec66df3
Merge "Fix attachment of toolbar dialogs"
2024-08-06 20:27:30 +00:00
David Lynch
da47997ef4
Fix attachment of toolbar dialogs
...
getToolbarDialogs defaults to the `side` position, but we actually want
the `above` one here.
Bug: T371341
Change-Id: Ib42f6a4877d3b0efb87199f60cce7a7416ce9b8a
2024-08-06 11:39:44 -05:00
Ed Sanders
d8f564fe71
Show confirmation prompt if trying to submit a new topic without a title
...
Bug: T334163
Change-Id: Ib961632636d5b7134219cddde1638c6962209001
2024-08-06 09:44:27 -05:00
Ed Sanders
6a17f6121c
Move reply widget controlling logic to CommentController
...
Some of what happens when you click reply happens in
CommentController (in #save) and some error handling
happens in ReplyWidget (in #onReplyClick).
Move most of the logic to CommenController.
Change-Id: Ib6208c0b8d2ddbbcf08adfcca7875ab8b026f598
2024-08-06 09:44:27 -05:00
Hannah Okwelum
4403887e88
Prepare Less styles for math=parens-division
...
Bug: T368921
Change-Id: I4c6db2d39883d31cf4216da0e3d79136287bf960
2024-07-31 20:12:15 +01:00
Sjoerd de Bruin
f986dc1924
Apply word-wrap:break-word; to .ext-discussiontools-init-pageframe-latestcomment
...
Bug: T369599
Change-Id: I3b1739e4e0ed257dd149d29d9d112983204dde0b
2024-07-09 19:37:30 +02:00
Bartosz Dziewoński
eb497b00c7
permalinks: Only handle unmodified left clicks
...
Allow using Ctrl+click to open the link in a new tab, or Alt+click to
select the text, without annoying side effects.
Change-Id: I3ab4c1ec3d5fc6c69e7f44489bbe63c536a64b91
2024-07-02 10:38:42 +02:00
jenkins-bot
6796c26cc9
Merge "Fix color contrast issues in DiscussionToolsDebug in night theme"
2024-07-01 15:59:54 +00:00
jenkins-bot
1be8a4e281
Merge "Use green rather than yellow for newly posted messages"
2024-07-01 15:59:52 +00:00
jenkins-bot
76dad90e28
Merge "Fixes background of talk page highlights in dark mode"
2024-07-01 15:59:51 +00:00
Jon Robson
b3bb486e30
Fix color contrast issues in DiscussionToolsDebug in night theme
...
Visual change: tokens are switched out for closest available.
Bug: T366524
Change-Id: I185bf496e3b2974ec4cb873719327e6898ca57db
2024-06-28 17:12:52 +00:00
David Lynch
edb23dc849
Permalink copying: fix another reference to e.target
...
Bug: T368701
Change-Id: Iae20e4573dfc12ea9d4010390fe2acb135e1b1cd
2024-06-28 11:05:11 -05:00
David Lynch
cd39c267b5
Permalink copying: use currentTarget to avoid conflicts with userscripts
...
Bug: T368701
Change-Id: I70b1cbf8aaf917ed843f003eec7bbd61db39ecc7
2024-06-28 10:17:27 -05:00
Jon Robson
f81739f8b4
Use green rather than yellow for newly posted messages
...
Use @background-color-success-subtle following discussion
Bug: T368086
Change-Id: I216fdb576ee9066df0c3cd3bc62d424f258fe265
2024-06-27 15:45:34 -07:00
Jon Robson
6896c8c879
Fixes background of talk page highlights in dark mode
...
Bug: T368086
Change-Id: I6ca92afeba448f953d1ef5f54d7f1e966c017b48
2024-06-27 15:45:34 -07:00
bwang
e830713b64
Fix white on white text in source preview
...
Bug: T367432
Change-Id: I2beabfe21e0c7402804a6968d983b8ef96b5329b
2024-06-27 09:51:06 -05:00
Ed Sanders
66ddcf5b64
Remove A/B test code
...
It's unlikely we'll do another feature A/B test any time soon.
Bug: T322492
Bug: T341491
Depends-On: Ia3712e2930fcd971bce44f568430602ce3949f23
Change-Id: I1ef4191f9466b7420a2fead571615ed6d49f873e
2024-06-21 21:08:15 +00:00
jenkins-bot
fb4d4d77a5
Merge "Trim whitespace from truncated heading titles in IDs"
2024-06-20 02:20:23 +00:00
Ed Sanders
9e9ad65f2b
build: Update eslint-config-wikimedia to 0.28.2
...
Change-Id: Ifb0eb261325544fceeb16d13be31bbf303e64124
2024-06-13 17:28:06 +01:00
jenkins-bot
a3adda8ed7
Merge "Remove jquery.makeCollapsible workarounds for mobile"
2024-06-10 19:29:49 +00:00
Ed Sanders
e9f412f4c0
eslint: Remove no-op config
...
Change-Id: Idcc2f4e4edeb57d1fb11deb4e798529f14466c9b
2024-06-06 16:30:49 +01:00
