wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-23 16:06:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "PreferenceHooks: Avoid referring to the field of disabled feature"

Browse source
This commit is contained in:
jenkins-bot 2022-09-24 23:30:44 +00:00 committed by Gerrit Code Review
parent 63acbf4dfc 8820940dfd
commit fb7a25ce91
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/Hooks/PreferenceHooks.php
View file

@ -125,7 +125,10 @@ class PreferenceHooks implements
// (both reply tool and new topic tool are disabled)
$preferences['discussiontools-' . HookUtils::SOURCEMODETOOLBAR]['disable-if'] = [ 'AND' ];
if ( isset( $preferences['discussiontools-' . HookUtils::REPLYTOOL] ) ) {
if ( isset( $preferences['discussiontools-' . HookUtils::REPLYTOOL] ) &&
// GlobalPreferences extension would delete disabled fields, avoid referring to it.
!( $preferences['discussiontools-' . HookUtils::REPLYTOOL]['disabled'] ?? false )
) {
$preferences['discussiontools-' . HookUtils::SOURCEMODETOOLBAR]['disable-if'][] = [
'===', 'discussiontools-' . HookUtils::REPLYTOOL, ''
];