wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-30 19:16:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle JS exceptions in API error logging

Browse source 
When an exception is thrown by our code elsewhere, and caught by the
promise mechanisms, it bubbles up here in the `code` variable, and
`data` is undefined.

Change-Id: I8a0ac49d22d254f353797fc8978871502ae8b9de
This commit is contained in:
Bartosz Dziewoński 2021-11-03 22:21:18 +01:00
parent 6cb595296f
commit d0f8794388
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/dt.ui.ReplyWidget.js
View file

@ -831,12 +831,17 @@ ReplyWidget.prototype.onReplyClick = function () {
widget.errorMessage.$element.insertBefore( widget.replyBodyWidget.$element ); widget.errorMessage.$element.insertBefore( widget.replyBodyWidget.$element );
} }
if ( code instanceof Error ) {
code = 'exception';
}
// Log more precise error codes, mw.Api just gives us 'http' in all of these cases // Log more precise error codes, mw.Api just gives us 'http' in all of these cases
if ( data ) {
if ( data.textStatus === 'timeout' || data.textStatus === 'abort' || data.textStatus === 'parsererror' ) { if ( data.textStatus === 'timeout' || data.textStatus === 'abort' || data.textStatus === 'parsererror' ) {
code = data.textStatus; code = data.textStatus;
} else if ( data.xhr ) { } else if ( data.xhr ) {
code = 'http-' + ( data.xhr.status || 0 ); code = 'http-' + ( data.xhr.status || 0 );
} }
}
logger( { logger( {
action: 'saveFailure', action: 'saveFailure',