From bfe4a814361463130c4d155769ac3902e137ec99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= Date: Mon, 13 Mar 2023 15:11:33 +0100 Subject: [PATCH] Fix [reply] spacing on mobile when usability improvements unavailable Minerva uses block placement for the buttons only on pages where usability improvements are available. Follow-up to 869520a6d0580f6260f1b869c301d3021c03fb55. Bug: T325416 Change-Id: I9e828197aea7bbaff86489f3ef6e256e0a0845ff --- modules/dt.init.less | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/modules/dt.init.less b/modules/dt.init.less index e7e13994d..e50f235a3 100644 --- a/modules/dt.init.less +++ b/modules/dt.init.less @@ -29,8 +29,7 @@ h1, h2, h3, h4, h5, h6 { // Add space before the buttons using actual spaces rather than margin, so that they may collapse // when the buttons wrap to a new line (T325416). - // (Except on Minerva, which uses block placements for the buttons rather than inline.) - body:not( .skin-minerva ) &::before { + &::before { // Must use character escapes to avoid CSS minifier messing up the spaces content: '\20\20'; white-space: pre-wrap; @@ -349,9 +348,14 @@ h1, h2, h3, h4, h5, h6 { } } + // Use block placement for the reply buttons on mobile, to make them easier to tap. &.skin-minerva .ext-discussiontools-init-replylink-buttons { - margin-left: 0; display: block; + + &::before { + // Remove the spaces that are used for inline placement (T325416), added at the top of this file. + content: ''; + } } }