wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-11 17:02:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

ApiDiscussionToolsCompare: Show nice error for deleted revisions

Browse source 
Bug: T362814
Change-Id: Iecc3e3737fcc82a79e699fe0bc00f373ecabf0c2
This commit is contained in:
Bartosz Dziewoński 2024-04-26 03:49:32 +02:00
parent f3e96a72fa
commit b8a28d6cfc
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/ApiDiscussionToolsCompare.php
View file

@ -55,6 +55,11 @@ class ApiDiscussionToolsCompare extends ApiBase {
); );
} }
} }
// To keep things simple, don't allow viewing deleted revisions through this API
// (even if the current user could view them if we checked with userCan()).
if ( !$rev->audienceCan( RevisionRecord::DELETED_TEXT, RevisionRecord::FOR_PUBLIC ) ) {
$this->dieWithError( [ 'apierror-missingcontent-revid', $rev->getId() ], 'missingcontent' );
}
return $rev; return $rev;
} }