Show empty state message if subject doesn't exist but talk page exists

If the subject page/user doesn't exist it usually makes sense
not to show the "Start a discussion about X" message, but when
the talk page itself exists but without any discussions
(e.g. after a Flow archiving), then we _should_ show message to
start a new discussion.

Bug: T378392
Change-Id: I20dab0089691ba7a429c9a50f23b9e3afe61aaaf
This commit is contained in:
Ed Sanders 2024-10-29 09:50:36 +00:00
parent ed132cc837
commit a85be7d7b5

View file

@ -518,7 +518,7 @@ class HookUtils {
// Only in talk namespaces, not including other namespaces that isAvailableForTitle() allows // Only in talk namespaces, not including other namespaces that isAvailableForTitle() allows
$title->isTalkPage() && $title->isTalkPage() &&
// Only if the subject page or the user exists (T288319, T312560) // Only if the subject page or the user exists (T288319, T312560)
static::pageSubjectExists( $title ) && ( $title->exists() || static::pageSubjectExists( $title ) ) &&
// The default display will probably be more useful for links to old revisions of deleted // The default display will probably be more useful for links to old revisions of deleted
// pages (existing pages are already excluded in shouldShowNewSectionTab()) // pages (existing pages are already excluded in shouldShowNewSectionTab())
$req->getIntOrNull( 'oldid' ) === null && $req->getIntOrNull( 'oldid' ) === null &&