wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 00:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "highlighter: Ensure items in .ranges and .$element are in the same order"

Browse source
This commit is contained in:
jenkins-bot 2022-04-21 23:55:17 +00:00 committed by Gerrit Code Review
parent d35c96db97 d910663bbc
commit 90018a5b55
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/highlighter.js
View file

@ -10,10 +10,9 @@ var
* @param {CommentItem|CommentItem[]} comments Comment item(s) to highlight
*/
function Highlight( comments ) {
var highlight = this;
var highlightNodes = [];
var ranges = [];
this.ranges = [];
this.$element = $( [] );
this.topmostElement = null;
comments = Array.isArray( comments ) ? comments : [ comments ];
@ -30,10 +29,13 @@ function Highlight( comments ) {
// before, otherwise Node#getBoundingClientRect() returns wrong results.
range.insertNode( $highlight[ 0 ] );
highlight.ranges.push( range );
highlight.$element = highlight.$element.add( $highlight );
ranges.push( range );
highlightNodes.push( $highlight[ 0 ] );
} );
this.ranges = ranges;
this.$element = $( highlightNodes );
// Events
this.updateDebounced = OO.ui.debounce( this.update.bind( this ), 500 );
window.addEventListener( 'resize', this.updateDebounced );