wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-23 18:38:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't pass an empty string to getElementById to avoid Firefox warning

Browse source 
Bug: T315614
Change-Id: I6d4eedd75a23f6ada26aedca54da80c5e33ea4f0
This commit is contained in:
Ed Sanders 2022-08-22 16:36:09 +01:00
parent e8068f2bf6
commit 837591f12e
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/highlighter.js
View file

@ -401,6 +401,11 @@ function clearHighlightTargetComment( threadItemSet ) {
* @return {Element|null} Element, if found
*/
function getTargetFromFragment( hash ) {
if ( !hash ) {
// Firefox emits a console warning if you pass an empty string
// to getElementById (T272844).
return null;
}
// Per https://html.spec.whatwg.org/multipage/browsing-the-web.html#target-element
// we try the raw fragment first, then the percent-decoded fragment.
return document.getElementById( hash ) ||