wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-23 16:06:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ImmutableRange: Fix Phan suppression"

Browse source
This commit is contained in:
jenkins-bot 2022-03-23 01:16:05 +00:00 committed by Gerrit Code Review
parent 35b3fd2fc0 05996d71fe
commit 7e4727ed45
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
includes/ImmutableRange.php
View file

@ -4,6 +4,7 @@ namespace MediaWiki\Extension\DiscussionTools;
use Error;
use Exception;
use Wikimedia\Assert\Assert;
use Wikimedia\Parsoid\DOM\Comment;
use Wikimedia\Parsoid\DOM\DocumentFragment;
use Wikimedia\Parsoid\DOM\DocumentType;
@ -282,11 +283,13 @@ class ImmutableRange {
|| $firstPartiallyContainedChild instanceof Comment
) {
$clone = $originalStartContainer->cloneNode();
// @phan-suppress-next-line PhanUndeclaredMethod
$clone->nodeValue = $originalStartContainer->substringData(
Assert::precondition(
$firstPartiallyContainedChild === $originalStartContainer,
'Only possible when the node is the startContainer'
);
$clone->nodeValue = $firstPartiallyContainedChild->substringData(
$originalStartOffset,
// @phan-suppress-next-line PhanUndeclaredProperty
$originalStartContainer->length - $originalStartOffset
$firstPartiallyContainedChild->length - $originalStartOffset
);
$fragment->appendChild( $clone );
} elseif ( $firstPartiallyContainedChild ) {
@ -319,9 +322,12 @@ class ImmutableRange {
|| $lastPartiallyContainedChild instanceof ProcessingInstruction
|| $lastPartiallyContainedChild instanceof Comment
) {
$clone = $originalEndContainer->cloneNode();
// @phan-suppress-next-line PhanUndeclaredMethod
$clone->nodeValue = $originalEndContainer->substringData(
Assert::precondition(
$lastPartiallyContainedChild === $originalEndContainer,
'Only possible when the node is the endContainer'
);
$clone = $lastPartiallyContainedChild->cloneNode();
$clone->nodeValue = $lastPartiallyContainedChild->substringData(
0,
$originalEndOffset
);