wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 00:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Work around invalid ranges in #getNativeRange"

Browse source
This commit is contained in:
jenkins-bot 2020-06-01 14:59:01 +00:00 committed by Gerrit Code Review
parent cd216ec538 c7575b49f6
commit 7898eb4757
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
modules/utils.js
View file

@ -7,11 +7,20 @@
* @return {Range}
*/
function getNativeRange( comment ) {
var
var endContainer, endOffset,
doc = comment.range.startContainer.ownerDocument,
nativeRange = doc.createRange();
nativeRange.setStart( comment.range.startContainer, comment.range.startOffset );
nativeRange.setEnd( comment.range.endContainer, comment.range.endOffset );
// HACK: When the offset is outside the container, assume this is because of
// the 'mw:Entity' hack in parser#findTimestamps and adjust accordingly.
// TODO: The parser should produce valid ranges!
endContainer = comment.range.endContainer;
endOffset = comment.range.endOffset;
while ( endOffset > ( endContainer.length || endContainer.childNodes.length ) ) {
endOffset -= ( endContainer.length || endContainer.childNodes.length );
endContainer = endContainer.nextSibling;
}
nativeRange.setEnd( endContainer, endOffset );
return nativeRange;
}