wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 08:23:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

TopicSubscriptions: Hide broken "Topic" sort

Browse source 
This doesn't sort by the topic name, but the hidden
sub_id field, leading to a confusing order.

Bug: T273342
Change-Id: I6146abf05544d40c9ef0d2e8c58d020e5a5fa8a2
This commit is contained in:
Ed Sanders 2021-10-12 14:04:59 +01:00
parent 0935bb1271
commit 7550bb4395
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
includes/TopicSubscriptionsPager.php
View file

@ -148,6 +148,7 @@ class TopicSubscriptionsPager extends TablePager {
* @inheritDoc * @inheritDoc
*/ */
protected function isFieldSortable( $field ) { protected function isFieldSortable( $field ) {
return isset( self::INDEX_FIELDS[$field] ); // Topic is set to the auto-ID field (sub_id), so sorting by it is not very useful
return isset( self::INDEX_FIELDS[$field] ) && $field !== '_topic';
} }
} }