wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-28 02:00:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update a/b test code for visual enhancements a/b test

Browse source 
Strip it out from applying to logged out users and make the test work
for multiple features

Bug: T333715
Change-Id: Id15a8a99c2ea8e6fc14fc83baf2ed6ebaaf754c8
This commit is contained in:
David Lynch 2023-05-08 01:30:21 -05:00
parent 12164c1606
commit 71d2e76d7f
3 changed files with 10 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extension.json
View file

@ -540,7 +540,7 @@
}, },
"DiscussionToolsABTest": { "DiscussionToolsABTest": {
"value": false, "value": false,
"description": "A/B test DiscussionTools features for logged in users. false, 'replytool', 'newtopictool', or 'mobile'" "description": "A/B test DiscussionTools features for logged in users. false, any valid feature string for an option below, or an array thereof"
}, },
"DiscussionToolsEnableMobile": { "DiscussionToolsEnableMobile": {
"value": true, "value": true,

23
includes/Hooks/HookUtils.php
View file

@ -300,28 +300,19 @@ class HookUtils {
*/ */
public static function determineUserABTestBucket( UserIdentity $user, ?string $feature = null ): string { public static function determineUserABTestBucket( UserIdentity $user, ?string $feature = null ): string {
$services = MediaWikiServices::getInstance(); $services = MediaWikiServices::getInstance();
$optionsManager = $services->getUserOptionsManager();
$dtConfig = $services->getConfigFactory()->makeConfig( 'discussiontools' ); $dtConfig = $services->getConfigFactory()->makeConfig( 'discussiontools' );
$abtest = $dtConfig->get( 'DiscussionToolsABTest' ); $abtest = $dtConfig->get( 'DiscussionToolsABTest' );
if ( !$abtest ) {
return '';
}
if ( $feature ? ( $abtest == $feature ) : (bool)$abtest ) { if (
if ( $user->isRegistered() ) { ( $feature ? in_array( $feature, (array)$abtest ) : (bool)$abtest ) &&
$user->isRegistered()
) {
return $user->getId() % 2 == 0 ? 'test' : 'control'; return $user->getId() % 2 == 0 ? 'test' : 'control';
} }
// logged out
$req = RequestContext::getMain()->getRequest();
$cookie = $req->getCookie( 'DTAB', '' );
if ( $cookie ) {
return $cookie;
}
// we just want to remember this across all calls in this request
static $bucket = false;
if ( !$bucket ) {
$bucket = rand( 0, 1 ) <= 0.5 ? 'test' : 'control';
}
return $bucket;
}
return ''; return '';
} }

7
includes/Hooks/PageHooks.php
View file

@ -109,12 +109,7 @@ class PageHooks implements
} }
// Load modules if any DT feature is enabled for this user // Load modules if any DT feature is enabled for this user
if ( if ( HookUtils::isFeatureEnabledForOutput( $output ) ) {
HookUtils::isFeatureEnabledForOutput( $output ) ||
// If there's an a/b test we need to include the JS for unregistered users just so
// we can make sure we store the bucket
( $this->config->get( 'DiscussionToolsABTest' ) && !$user->isRegistered() )
) {
$output->addModules( [ $output->addModules( [
'ext.discussionTools.init' 'ext.discussionTools.init'
] ); ] );