wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-28 02:00:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Avoid exception when trying to highlight hidden comment"

Browse source
This commit is contained in:
jenkins-bot 2021-07-13 17:26:37 +00:00 committed by Gerrit Code Review
parent 062416771f 650c7dd1d3
commit 64f40718e2
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/controller.js
View file

@ -49,12 +49,15 @@ function highlight( comment ) {
var baseRect = $highlight[ 0 ].getBoundingClientRect(); var baseRect = $highlight[ 0 ].getBoundingClientRect();
var rect = RangeFix.getBoundingClientRect( range ); var rect = RangeFix.getBoundingClientRect( range );
// rect may be null if the range is in a detached or hidden node
if ( rect ) {
$highlight.css( { $highlight.css( {
'margin-top': rect.top - baseRect.top - padding, 'margin-top': rect.top - baseRect.top - padding,
'margin-left': rect.left - baseRect.left - padding, 'margin-left': rect.left - baseRect.left - padding,
width: rect.width + ( padding * 2 ), width: rect.width + ( padding * 2 ),
height: rect.height + ( padding * 2 ) height: rect.height + ( padding * 2 )
} ); } );
}
return $highlight; return $highlight;
} }