wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-14 11:25:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Implement getTimestampString on CommentItem"

Browse source
This commit is contained in:
jenkins-bot 2022-03-26 21:25:13 +00:00 committed by Gerrit Code Review
parent 215695ad2c 579b8bb1d4
commit 63c6aceb2c
2 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/CommentItem.js
View file

@ -31,6 +31,18 @@ function CommentItem( level, range, signatureRanges, timestamp, author ) {
OO.inheritClass( CommentItem, ThreadItem );
/**
* Get the comment timestamp in a standard format
*
* Uses ISO 8601 date. Almost DateTimeInterface::RFC3339_EXTENDED, but ending with 'Z' instead
* of '+00:00', like Date#toISOString in JavaScript.
*
* @return {string} Comment timestamp in standard format
*/
CommentItem.prototype.getTimestampString = function () {
return this.timestamp.toISOString();
};
/**
* @return {HeadingItem} Closest ancestor which is a HeadingItem
*/

8
modules/Parser.js
View file

@ -929,7 +929,7 @@ Parser.prototype.computeId = function ( threadItem, previousItems ) {
headline = threadItem.range.startContainer;
id = 'h-' + this.truncateForId( headline.getAttribute( 'id' ) || '' );
} else if ( threadItem instanceof CommentItem ) {
id = 'c-' + this.truncateForId( threadItem.author || '' ).replace( / /g, '_' ) + '-' + threadItem.timestamp.toISOString();
id = 'c-' + this.truncateForId( threadItem.author || '' ).replace( / /g, '_' ) + '-' + threadItem.getTimestampString();
} else {
throw new Error( 'Unknown ThreadItem type' );
}
@ -942,7 +942,7 @@ Parser.prototype.computeId = function ( threadItem, previousItems ) {
headline = threadItemParent.range.startContainer;
id += '-' + this.truncateForId( headline.getAttribute( 'id' ) || '' );
} else if ( threadItemParent instanceof CommentItem ) {
id += '-' + this.truncateForId( threadItemParent.author || '' ).replace( / /g, '_' ) + '-' + threadItemParent.timestamp.toISOString();
id += '-' + this.truncateForId( threadItemParent.author || '' ).replace( / /g, '_' ) + '-' + threadItemParent.getTimestampString();
}
if ( threadItem instanceof HeadingItem ) {
@ -952,7 +952,7 @@ Parser.prototype.computeId = function ( threadItem, previousItems ) {
// heading ID.
var oldestComment = this.getThreadStartComment( threadItem );
if ( oldestComment ) {
id += '-' + oldestComment.timestamp.toISOString();
id += '-' + oldestComment.getTimestampString();
}
}
@ -994,7 +994,7 @@ Parser.prototype.computeName = function ( threadItem ) {
if ( mainComment ) {
name += this.truncateForId( mainComment.author || '' ).replace( / /g, '_' ) +
'-' + mainComment.timestamp.toISOString();
'-' + mainComment.getTimestampString();
}
return name;