wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-23 18:38:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add accesskey "s" to the "Reply" / "Add topic" button

Browse source 
Add brackets around the existing shortcut key labels, so that they
don't look quite so out-of-place next to the automatically added
accesskey label.

Bug: T278249
Change-Id: Icc0df5ba036080807ea0eb215f5526c93da78ef1
This commit is contained in:
Bartosz Dziewoński 2022-10-20 22:44:19 +02:00
parent c049f07055
commit 5ed1c4a482
4 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
extension.json
View file

@ -196,6 +196,7 @@
"discussiontools-replywidget-placeholder-reply",
"discussiontools-replywidget-preferences",
"discussiontools-replywidget-preview",
"discussiontools-replywidget-publish-accesskey",
"discussiontools-replywidget-reply",
"discussiontools-replywidget-return-to-newtopic",
"discussiontools-replywidget-return-to-reply",

1
i18n/en.json
View file

@ -118,6 +118,7 @@
"discussiontools-replywidget-placeholder-reply": "Reply to {{BIDI:$1}}",
"discussiontools-replywidget-preferences": "Preferences",
"discussiontools-replywidget-preview": "Preview",
"discussiontools-replywidget-publish-accesskey": "s",
"discussiontools-replywidget-reply": "Reply",
"discussiontools-replywidget-reply-link": "https://www.mediawiki.org/wiki/Special:MyLanguage/Talk_pages_project/Replying",
"discussiontools-replywidget-return-to-newtopic": "Return to new topic",

1
i18n/qqq.json
View file

@ -131,6 +131,7 @@
"discussiontools-replywidget-placeholder-reply": "Placeholder describing who is being replied to.\n\nParameters:\n* $1 – username of the person who wrote the previous comment",
"discussiontools-replywidget-preferences": "Label for link to the relevant preferences in the reply widget (the link points to [[Special:Preferences#mw-prefsection-editing-discussion]]).\n{{Identical|Preferences}}",
"discussiontools-replywidget-preview": "Label for the preview area of the reply widget",
"discussiontools-replywidget-publish-accesskey": "{{doc-accesskey}}",
"discussiontools-replywidget-reply": "Label for the button to submit a reply in the reply widget",
"discussiontools-replywidget-reply-link": "{{notranslate}}\nUsed by {{msg-mw|Tag-discussiontools-reply}} as a link to a page where users learn about the feature. Defaults to a page on MediaWiki.org.",
"discussiontools-replywidget-return-to-newtopic": "Label for the button to scroll the new topic widget back into view.",

9
modules/dt.ui.ReplyWidget.js
View file

@ -77,23 +77,24 @@ function ReplyWidget( commentController, commentDetails, config ) {
this.replyButton = new OO.ui.ButtonWidget( {
flags: [ 'primary', 'progressive' ],
label: this.replyButtonLabel,
title: this.replyButtonLabel + ' ' +
title: this.replyButtonLabel + ' [' +
// TODO: Use VE keyboard shortcut generating code
( $.client.profile().platform === 'mac' ?
'⌘⏎' :
mw.msg( 'visualeditor-key-ctrl' ) + '+' + mw.msg( 'visualeditor-key-enter' )
)
) + ']',
accessKey: mw.msg( 'discussiontools-replywidget-publish-accesskey' )
} );
this.cancelButton = new OO.ui.ButtonWidget( {
flags: [ 'destructive' ],
label: mw.msg( 'discussiontools-replywidget-cancel' ),
framed: false,
title: mw.msg( 'discussiontools-replywidget-cancel' ) + ' ' +
title: mw.msg( 'discussiontools-replywidget-cancel' ) + ' [' +
// TODO: Use VE keyboard shortcut generating code
( $.client.profile().platform === 'mac' ?
'⎋' :
mw.msg( 'visualeditor-key-escape' )
)
) + ']'
} );
this.$headerWrapper = $( '<div>' ).addClass( 'ext-discussiontools-ui-replyWidget-headerWrapper' );