wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-23 16:06:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "commentparser: Allow signature of user '0' to be detected"

Browse source
This commit is contained in:
jenkins-bot 2024-11-18 18:54:48 +00:00 committed by Gerrit Code Review
parent 2eb8bae39b 84d0dfc51c
commit 5dec8076e2
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/CommentParser.php
View file

@ -605,7 +605,7 @@ class CommentParser {
$username = $userpage->getText(); $username = $userpage->getText();
} }
} }
if ( !$username ) { if ( $username === null ) {
return null; return null;
} }
if ( IPUtils::isIPv6( $username ) ) { if ( IPUtils::isIPv6( $username ) ) {
@ -924,7 +924,7 @@ class CommentParser {
$foundSignature = $this->findSignature( $node, $curCommentEnd ); $foundSignature = $this->findSignature( $node, $curCommentEnd );
$author = $foundSignature['username']; $author = $foundSignature['username'];
if ( !$author ) { if ( $author === null ) {
// Ignore timestamps for which we couldn't find a signature. It's probably not a real // Ignore timestamps for which we couldn't find a signature. It's probably not a real
// comment, but just a false match due to a copypasted timestamp. // comment, but just a false match due to a copypasted timestamp.
continue; continue;
@ -969,7 +969,7 @@ class CommentParser {
$treeWalker->currentNode = $n; $treeWalker->currentNode = $n;
// …and add it as another signature to this comment (regardless of the author and timestamp) // …and add it as another signature to this comment (regardless of the author and timestamp)
$foundSignature2 = $this->findSignature( $n, $node ); $foundSignature2 = $this->findSignature( $n, $node );
if ( $foundSignature2['username'] ) { if ( $foundSignature2['username'] !== null ) {
$sigRanges[] = $this->adjustSigRange( $foundSignature2['nodes'], $match2, $n ); $sigRanges[] = $this->adjustSigRange( $foundSignature2['nodes'], $match2, $n );
$timestampRanges[] = $match2['range']; $timestampRanges[] = $match2['range'];
} }