wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-18 11:02:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace unneeded isset() with !== null

Browse source 
The PHP `global` statement actually creates a global variable if it
does not exist yet, setting it to null. Who'd have thunk.

This is reported as a new issue type 'MediaWikiNoIssetIfDefined' by
mediawiki/mediawiki-phan-config to 0.15.0.

Change-Id: Ia1c3a08f399257ede41920beafa9f1864206c94e
This commit is contained in:
Bartosz Dziewoński 2024-12-16 16:41:02 +01:00
parent cfdd9b1a48
commit 5c9389db15
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/Notifications/EventDispatcher.php
View file

@ -493,10 +493,10 @@ class EventDispatcher {
global $wgDTSchemaEditAttemptStepSamplingRate, $wgWMESchemaEditAttemptStepSamplingRate; global $wgDTSchemaEditAttemptStepSamplingRate, $wgWMESchemaEditAttemptStepSamplingRate;
// Sample 6.25% // Sample 6.25%
$samplingRate = 0.0625; $samplingRate = 0.0625;
if ( isset( $wgDTSchemaEditAttemptStepSamplingRate ) ) { if ( $wgDTSchemaEditAttemptStepSamplingRate !== null ) {
$samplingRate = $wgDTSchemaEditAttemptStepSamplingRate; $samplingRate = $wgDTSchemaEditAttemptStepSamplingRate;
} }
if ( isset( $wgWMESchemaEditAttemptStepSamplingRate ) ) { if ( $wgWMESchemaEditAttemptStepSamplingRate !== null ) {
$samplingRate = $wgWMESchemaEditAttemptStepSamplingRate; $samplingRate = $wgWMESchemaEditAttemptStepSamplingRate;
} }
if ( $samplingRate === 0 ) { if ( $samplingRate === 0 ) {