wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 16:34:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Disable VisualEditor page takeovers while a reply widget is open"

Browse source
This commit is contained in:
jenkins-bot 2020-05-08 14:24:26 +00:00 committed by Gerrit Code Review
parent af2fd3f8d8 2f92e5d114
commit 4c8e92e0fb
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
modules/CommentController.js
View file

@ -131,6 +131,10 @@ CommentController.prototype.setup = function () {
$( '.dt-init-replylink-reply' ).attr( {
tabindex: '-1'
} );
// Suppress page takeover behavior for VE editing so that our unload
// handler can warn of data loss.
// eslint-disable-next-line no-jquery/no-global-selector
$( '#ca-edit, #ca-ve-edit, .mw-editsection a, #ca-addsection' ).off( '.ve-target' );
logger( {
action: 'init',
@ -230,6 +234,11 @@ CommentController.prototype.teardown = function () {
$( '.dt-init-replylink-reply' ).attr( {
tabindex: '0'
} );
// We deliberately mangled edit links earlier so VE can't steal our page;
// have it redo setup to fix those.
if ( mw.libs.ve && mw.libs.ve.setupEditLinks ) {
mw.libs.ve.setupEditLinks();
}
modifier.removeListItem( this.newListItem );
this.newListItem = null;
this.$replyLink.trigger( 'focus' );