From 40f85d8852b9c407d15d407103203e64c5bca76b Mon Sep 17 00:00:00 2001 From: Arlo Breault Date: Fri, 20 Sep 2024 18:15:14 -0400 Subject: [PATCH] Revert "Document shortcoming of CommentFormatter::isEmptyTalkPage" This reverts commit 8245b94c4c7381d97d65791cd8654d61ee9bb11b. No longer relevant after the revert in f96eba7. Change-Id: Id81e68b4eaacb4b8a594ac97f75f1a7f5540b78c --- includes/CommentFormatter.php | 7 ------- 1 file changed, 7 deletions(-) diff --git a/includes/CommentFormatter.php b/includes/CommentFormatter.php index 488551b8f..d41260caa 100644 --- a/includes/CommentFormatter.php +++ b/includes/CommentFormatter.php @@ -917,13 +917,6 @@ class CommentFormatter { /** * Check if the talk page had no comments or headings. - * - * Note that the implementation here is using a double negative which - * doesn't guarantee a *talk page*, only that the page is not not an empty - * talk page, which could be many other types of page. - * - * The current use of this method is paired with - * HookUtils::shouldDisplayEmptyState which assures we have a talk page. */ public static function isEmptyTalkPage( ParserOutput $pout ): bool { return $pout->getExtensionData( 'DiscussionTools-isEmptyTalkPage' ) === true;