From 3b67d12a46e582777d9f294aa344e2531c5621be Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Sat, 26 Oct 2024 14:59:39 +0200 Subject: [PATCH] Use explicit nullable type on parameter arguments (for PHP 8.4) Implicitly marking parameter $... as nullable is deprecated in PHP 8.4. The explicit nullable type must be used instead. Bug: T376276 Change-Id: I40b301271ea0ae5d9123b06841eb8d3e4f9fbf86 --- includes/CommentModifier.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/CommentModifier.php b/includes/CommentModifier.php index 384f44867..e4f28384b 100644 --- a/includes/CommentModifier.php +++ b/includes/CommentModifier.php @@ -652,7 +652,7 @@ class CommentModifier { * @param string|null $signature */ public static function addWikitextReply( - ContentCommentItem $comment, string $wikitext, string $signature = null + ContentCommentItem $comment, string $wikitext, ?string $signature = null ): void { $doc = $comment->getRange()->endContainer->ownerDocument; $container = static::prepareWikitextReply( $doc, $wikitext ); @@ -670,7 +670,7 @@ class CommentModifier { * @param string|null $signature */ public static function addHtmlReply( - ContentCommentItem $comment, string $html, string $signature = null + ContentCommentItem $comment, string $html, ?string $signature = null ): void { $doc = $comment->getRange()->endContainer->ownerDocument; $container = static::prepareHtmlReply( $doc, $html );