wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-27 17:51:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop the DiscussionToolsEnable feature flag

Browse source 
This existed to do a staged rollout to WMF wikis, which was
finished in March 2021 (T276497).

Bug: T322497
Change-Id: I8851f0243e6920d93f3eb1870d1604bf201ed5a4
This commit is contained in:
Ed Sanders 2023-06-06 13:08:35 +01:00
parent dda86f8ebf
commit 3b4673bfad
3 changed files with 2 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
extension.json
View file

@ -62,7 +62,6 @@
{
"name": "config.json",
"config": {
"enable": "DiscussionToolsEnable",
"replyIndentation": "DiscussionToolsReplyIndentation",
"switchTime": "DiscussionToolsTimestampFormatSwitchTime",
"showFeedbackLinks": "DiscussionToolsShowFeedbackLinks"
@ -537,10 +536,6 @@
"discussiontools-visualenhancements": 1
},
"config": {
"DiscussionToolsEnable": {
"value": true,
"description": "Enable DiscussionTools on talk pages."
},
"DiscussionToolsBeta": {
"value": false,
"description": "Make DiscussionTools a BetaFeature."

4
includes/Hooks/HookUtils.php
View file

@ -202,10 +202,6 @@ class HookUtils {
$services = MediaWikiServices::getInstance();
$dtConfig = $services->getConfigFactory()->makeConfig( 'discussiontools' );
if ( !$dtConfig->get( 'DiscussionToolsEnable' ) ) {
return false;
}
if (
( $feature === static::TOPICSUBSCRIPTION || $feature === static::AUTOTOPICSUB ) &&
// Users must be logged in to use topic subscription, and Echo must be installed (T322498)

10
includes/Hooks/PreferenceHooks.php
View file

@ -151,10 +151,7 @@ class PreferenceHooks implements
'type' => 'api',
];
if (
!$this->config->get( 'DiscussionToolsEnable' ) ||
!$this->config->get( 'DiscussionToolsBeta' )
) {
if ( !$this->config->get( 'DiscussionToolsBeta' ) ) {
// When out of beta, preserve the user preference in case we
// bring back the beta feature for a new sub-feature. (T272071)
$preferences['discussiontools-betaenable'] = [
@ -210,10 +207,7 @@ class PreferenceHooks implements
$dtConfig = MediaWikiServices::getInstance()->getConfigFactory()
->makeConfig( 'discussiontools' );
if (
$dtConfig->get( 'DiscussionToolsEnable' ) &&
$dtConfig->get( 'DiscussionToolsBeta' )
) {
if ( $dtConfig->get( 'DiscussionToolsBeta' ) ) {
$preferences['discussiontools-betaenable'] = [
'version' => '1.0',
'label-message' => 'discussiontools-preference-label',