wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-23 10:29:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add null check for str_starts_with

Browse source 
Only needed for phan, under php8.1 this internal
function is deprecated about null.
The property $subscriptionName is not null when $subscriptionTitle is
not null and current code is safe, but phan cannot see the dependency
between both properties

Change-Id: I9e67309ec25a70c5de91d7f3e8f18447f205a4e4
This commit is contained in:
Umherirrender 2023-10-06 16:54:15 +02:00
parent 893846be65
commit 3aadcace2b
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/Actions/SubscribeAction.php
View file

@ -33,7 +33,9 @@ class SubscribeAction extends FormAction {
* @inheritDoc
*/
protected function getPageTitle() {
if ( $this->subscriptionTitle && !str_starts_with( $this->subscriptionName, 'p-topics-' ) ) {
if ( $this->subscriptionTitle &&
$this->subscriptionName !== null && !str_starts_with( $this->subscriptionName, 'p-topics-' )
) {
$title = $this->subscriptionTitle;
return $this->msg( 'discussiontools-topicsubscription-action-title' )
->plaintextParams( $title->getPrefixedText(), $title->getFragment() );