wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 16:34:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't show error message popups when failing to restore auto-save

Browse source 
Several of the messages talk about clicking the reply links, which
seems unhelpful. Also, showing a fullscreen popup on page load seems
very unhelpful too. (Itoldyouso that we shouldn't use popups.)

Bug: T268069
Change-Id: Id1312cf06200fb45a28b39481a99cc2c96603fa4
This commit is contained in:
Bartosz Dziewoński 2021-01-26 02:50:25 +01:00
parent fdd7994051
commit 344038ae41
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
modules/CommentController.js
View file

@ -37,7 +37,7 @@ function CommentController( $pageContainer, $replyLink, comment ) {
if ( storage.get( 'reply/' + comment.id + '/saveable' ) ) { if ( storage.get( 'reply/' + comment.id + '/saveable' ) ) {
mode = storage.get( 'reply/' + comment.id + '/mode' ); mode = storage.get( 'reply/' + comment.id + '/mode' );
this.setup( mode ); this.setup( mode, true );
} }
} }
@ -143,8 +143,9 @@ CommentController.prototype.onReplyLinkClick = function ( e ) {
* Create and setup the reply widget * Create and setup the reply widget
* *
* @param {string} [mode] Optionally force a mode, 'visual' or 'source' * @param {string} [mode] Optionally force a mode, 'visual' or 'source'
* @param {boolean} [hideErrors]
*/ */
CommentController.prototype.setup = function ( mode ) { CommentController.prototype.setup = function ( mode, hideErrors ) {
var comment = this.comment, var comment = this.comment,
commentController = this; commentController = this;
@ -180,10 +181,12 @@ CommentController.prototype.setup = function ( mode ) {
}, function ( code, data ) { }, function ( code, data ) {
commentController.teardown(); commentController.teardown();
OO.ui.alert( if ( !hideErrors ) {
code instanceof Error ? code.toString() : controller.getApi().getErrorMessage( data ), OO.ui.alert(
{ size: 'medium' } code instanceof Error ? code.toString() : controller.getApi().getErrorMessage( data ),
); { size: 'medium' }
);
}
logger( { logger( {
action: 'abort', action: 'abort',