From 32fc8c5ea9ec67e050aa2b11bf580e691e0fbc1c Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 11 Aug 2024 03:46:12 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 44.0.0

The following sniffs are failing and were disabled:
* Generic.CodeAnalysis.AssignmentInCondition.Found
* Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition

The following sniffs now pass and were enabled:
* Generic.CodeAnalysis.AssignmentInCondition

Change-Id: I8adfdce01ea96f4b62dabd3dea130f9593c7e5ac
---
 .phpcs.xml    | 3 ++-
 composer.json | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.phpcs.xml b/.phpcs.xml
index b47a643bc..c4ca61e22 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
 <?xml version="1.0"?>
 <ruleset>
 	<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+		<exclude name="Generic.CodeAnalysis.AssignmentInCondition.Found" />
+		<exclude name="Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition" />
 		<!--
 		Code such as this:
 			while ( ( $foo = $foo->nextSibling ) && someCondition( $foo ) ) { … }
@@ -14,7 +16,6 @@
 		typo for `==`, which is a convention borrowed from C:
 			while ( ( $foo = $foo->nextSibling ) ) { … }
 		-->
-		<exclude name="Generic.CodeAnalysis.AssignmentInCondition" />
 	</rule>
 	<file>.</file>
 	<arg name="extensions" value="php" />
diff --git a/composer.json b/composer.json
index 347ce0185..8825a52a3 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
 {
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "43.0.0",
+		"mediawiki/mediawiki-codesniffer": "44.0.0",
 		"mediawiki/mediawiki-phan-config": "0.14.0",
 		"mediawiki/minus-x": "1.1.3",
 		"php-parallel-lint/php-console-highlighter": "1.0.0",