wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 00:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix static cache access

Browse source 
Currently, DT is making more than 30 exact queries back to back in every
request. It is clear the caching is completely broken.

It is because when the properties don't exist (majority of the cases),
it returns an empty array making the caching noop.

Tested in mwdebug1002 and it fixes the issue.

Bug: T364693
Change-Id: I182ae121999df1a04cfb7399bc49891587a37074
This commit is contained in:
Amir Sarabadani 2024-05-12 18:00:43 +02:00
parent 52ca3d408e
commit 320da37512
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
includes/Hooks/HookUtils.php
View file

@ -92,18 +92,22 @@ class HookUtils {
*/ */
public static function hasPagePropCached( Title $title, string $prop ): bool { public static function hasPagePropCached( Title $title, string $prop ): bool {
Assert::parameter( Assert::parameter(
in_array( $prop, static::CACHED_PAGE_PROPS, true ), in_array( $prop, self::CACHED_PAGE_PROPS, true ),
'$prop', '$prop',
'must be one of the cached properties' 'must be one of the cached properties'
); );
$id = $title->getArticleId(); $id = $title->getArticleId();
if ( !isset( static::$propCache[ $id ] ) ) { if ( !isset( self::$propCache[ $id ] ) ) {
$services = MediaWikiServices::getInstance(); $services = MediaWikiServices::getInstance();
// Always fetch all of our properties, we need to check several of them on most requests // Always fetch all of our properties, we need to check several of them on most requests
static::$propCache += $pagePropsPerId = $services->getPageProps()->getProperties( $title, self::CACHED_PAGE_PROPS );
$services->getPageProps()->getProperties( $title, static::CACHED_PAGE_PROPS ); if ( $pagePropsPerId ) {
self::$propCache += $pagePropsPerId;
} else {
self::$propCache[ $id ] = [];
} }
return isset( static::$propCache[ $id ][ $prop ] ); }
return isset( self::$propCache[ $id ][ $prop ] );
} }
/** /**