wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-23 16:06:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: Rewrite exclude rule Generic.CodeAnalysis.AssignmentInCondition

Browse source 
The <exclude name=".."/> is managed by libup and when a rule passed,
it get removed from the list. Failing rules on update are added.

Setting the severity for the rule to none avoid that this is changed by
libup and it is more visible, that the disable is wanted and there is
nothing to "fix" as usually assumend for sniffs in the exclude list.

Follow-Up: I8adfdce01ea96f4b62dabd3dea130f9593c7e5ac
Change-Id: If42dade02c6ceed1e00f5a3dc846e1578b960ca6
This commit is contained in:
Umherirrender 2024-08-31 23:04:41 +02:00 committed by Bartosz Dziewoński
parent 31d67dd8e7
commit 2308d9bba0
1 changed files with 16 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
.phpcs.xml
View file

@ -1,8 +1,7 @@
<?xml version="1.0"?> <?xml version="1.0"?>
<ruleset> <ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
<exclude name="Generic.CodeAnalysis.AssignmentInCondition.Found" />
<exclude name="Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition" />
<!-- <!--
Code such as this: Code such as this:
while ( ( $foo = $foo->nextSibling ) && someCondition( $foo ) ) { … } while ( ( $foo = $foo->nextSibling ) && someCondition( $foo ) ) { … }
@ -16,7 +15,10 @@
typo for `==`, which is a convention borrowed from C: typo for `==`, which is a convention borrowed from C:
while ( ( $foo = $foo->nextSibling ) ) { … } while ( ( $foo = $foo->nextSibling ) ) { … }
--> -->
<rule ref="Generic.CodeAnalysis.AssignmentInCondition">
<severity>0</severity>
</rule> </rule>
<file>.</file> <file>.</file>
<arg name="extensions" value="php" /> <arg name="extensions" value="php" />
<arg name="encoding" value="UTF-8" /> <arg name="encoding" value="UTF-8" />