wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-27 17:51:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mobile: Only show "Add discussion" button if "New section" tab would be shown on desktop

Browse source 
Bug: T302417
Change-Id: Icd2acf19b8b7e4cf8893bbb37f80eafefe86acbb
This commit is contained in:
Bartosz Dziewoński 2022-02-23 18:03:09 +01:00
parent e11beee2ad
commit 109f49bb56
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
includes/Hooks/PageHooks.php
View file

@ -335,11 +335,19 @@ class PageHooks implements
* @return bool|void
*/
public function onArticleViewHeader( $article, &$outputDone, &$pcache ) {
$title = $article->getTitle();
$context = $article->getContext();
$output = $context->getOutput();
if (
$output->getSkin()->getSkinName() === 'minerva' &&
HookUtils::isFeatureEnabledForOutput( $output, HookUtils::NEWTOPICTOOL ) &&
// Only add the button if "New section" tab would be shown in a normal skin.
// Match the logic in MediaWiki core:
// https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/add6d0a0e38167a710fb47fac97ff3004451494c/includes/skins/SkinTemplate.php#1317
(
!HookUtils::hasPagePropCached( $title, 'nonewsectionlink' ) &&
( $title->isTalkPage() || HookUtils::hasPagePropCached( $title, 'newsectionlink' ) )
) &&
// No need to show the button when the empty state banner is shown
!HookUtils::shouldDisplayEmptyState( $context )
) {
@ -348,7 +356,7 @@ class PageHooks implements
$output->enableOOUI();
$output->addHTML(
new ButtonWidget( [
'href' => $article->getTitle()->getLinkURL( [ 'action' => 'edit', 'section' => 'new' ] ),
'href' => $title->getLinkURL( [ 'action' => 'edit', 'section' => 'new' ] ),
// TODO: Make this a local message if the Minerva feature goes away
'label' => $context->msg( 'minerva-talk-add-topic' )->text(),
'flags' => [ 'progressive', 'primary' ],