wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-23 16:06:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify preg_replace_callback in ApiDiscussionToolsPreview

Browse source 
There is nothing in this preg_replace call that needs to be executed
"as code". A normal preg_replace can do the same.

The pattern looks a bit different but really does have the exact same
effect as before.

Change-Id: I3597d632f2ecbe5b7ccef39a394075327c9bea79
This commit is contained in:
thiemowmde 2023-10-30 09:12:21 +01:00
parent f2265f918f
commit 07c051ba75
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/ApiDiscussionToolsPreview.php
View file

@ -79,10 +79,8 @@ class ApiDiscussionToolsPreview extends ApiBase {
$signature = $this->msg( 'discussiontools-signature-prefix' )->inContentLanguage()->text() . '~~~~';
// Drop opacity of signature in preview to make message body preview clearer.
// Extract any leading spaces outside the <span> markup to ensure accurate previews.
$signature = preg_replace_callback( '/^( *)(.+)$/', static function ( $matches ) {
list( , $leadingSpaces, $sig ) = $matches;
return $leadingSpaces . '<span style="opacity: 0.6;">' . $sig . '</span>';
}, $signature );
$signature = preg_replace( '/([^ ].*)/', '<span style="opacity: 0.6;">$1</span>',
$signature );
$result = $this->previewMessage(
$params['type'],