wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-11 08:08:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Discus.../tests/cases/for-parser-cache/for-parser-cache-formatted-mobile.html

70 lines
9.5 KiB
HTML
Raw Normal View History

Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
<span data-mw-thread-id="h--2021-02-24T19:24:00.000Z"><span data-mw-comment-start="" id="h--2021-02-24T19:24:00.000Z"></span><span data-mw-comment-end="h--2021-02-24T19:24:00.000Z"></span></span><span data-mw-comment-start="" id="c-Matma_Rex-2021-02-24T19:24:00.000Z"></span><style data-mw-deduplicate="TemplateStyles:r3303">.mw-parser-output .color-purple{color:purple}</style><div class="color-purple">This page demonstrates some quirks of raw HTML generated in ParserOutput, which gets saved to the parser cache and which we operate on in the ParserAfterTidy hook. Most other test cases are using the final HTML returned by ParserOutput::getText(), which we operate on in the OutputPageBeforeHTML hook.</div>
CommentFormatter: Add test cases for mobile version Also, rename the files, since CommentFormatter now does more than replies. Change-Id: I1ae432c06badd9790274db27881c2222c0439ba8
2022-07-27 14:19:31 +00:00
<p>Note:
</p>
<ul><li>No "mw-parser-output" wrapper div</li>
<li>Funky mw:editsection tags</li></ul>
Turn comment timestamps into permalinks Bug: T275729 Change-Id: Ica9cfd9743a67fce170e8b078016fa79bf6fbb84
2022-07-30 22:02:17 +00:00
<p><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:For_parser_cache#c-Matma_Rex-2021-02-24T19:24:00.000Z" class="ext-discussiontools-init-timestamplink">19:24, 24 February 2021 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2021-02-24T19:24:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-iconElement oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"icon":"share","label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-icon-share oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2021-02-24T19:24:00.000Z"></span>
CommentFormatter: Add test cases for mobile version Also, rename the files, since CommentFormatter now does more than replies. Change-Id: I1ae432c06badd9790274db27881c2222c0439ba8
2022-07-27 14:19:31 +00:00
</p>
overflow menu: Add hooks for registering and interacting with items Why: - We want to allow extensions to register interactive menu items in the overflow menu. What: - Create a PHP hook to allow extensions to provide menu items for rendering in the overflow menu - The hook allows for registering resource loader modules required by the menu item - The hook passes in some contextual information, like the thread item data, context source object, and if the page is editable - Create a JS hook that fires when a user selects one of the menu items - Example implementation: Ie9afbedb4f24cbd75eb48bb21dc9f6d8d732d853 Misc: - Remove b/c code that existed to handle a transitional period where JSON encoded overflow menu data did not necessarily exist in the parser cache - Rename code instances of ellipsis button / data / menu to refer to "overflow menu" - Some renames will have to wait until parser cache is updated; these are noted with TODOs Bug: T342251 Change-Id: I5f2a51791f8ba7619d1399a4b93111e9bb44e172
2023-09-28 11:00:36 +00:00
<div class="mw-heading mw-heading2 ext-discussiontools-init-section"><h2><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="/w/index.php?title=Talk:For_parser_cache&amp;action=dtsubscribe&amp;commentname=h-Matma_Rex-2021-02-24T19%3A24%3A00.000Z&amp;section=Heading+with+a+%22+quote" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span><span id="Heading_with_a_.22_quote"></span><span class="mw-headline" id="Heading_with_a_&quot;_quote" data-mw-thread-id="h-Heading_with_a_&quot;_quote-2021-02-24T19:24:00.000Z"><span data-mw-comment-start="" id="h-Heading_with_a_&quot;_quote-2021-02-24T19:24:00.000Z"></span>Heading with a " quote<span data-mw-comment-end="h-Heading_with_a_&quot;_quote-2021-02-24T19:24:00.000Z"></span></span><mw:editsection page="Talk:For parser cache" section="1">Heading with a " quote</mw:editsection></h2><span class='ext-discussiontools-init-section-ellipsisButton ext-discussiontools-init-section-overflowMenuButton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-iconElement oo-ui-buttonWidget' data-ooui='{"_":"OO.ui.ButtonMenuSelectWidget","rel":["nofollow"],"framed":false,"icon":"ellipsis","data":{"itemConfigs":[{"id":"edit","data":{"id":"edit"},"icon":"edit","label":"a label"}],"resourceLoaderModules":[]},"classes":["ext-discussiontools-init-section-ellipsisButton","ext-discussiontools-init-section-overflowMenuButton"]}'><a role='button' tabindex='0' rel='nofollow' class='oo-ui-buttonElement-button'><span class='oo-ui-iconElement-icon oo-ui-icon-ellipsis'></span><span class='oo-ui-labelElement-label'></span><span class='oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator'></span></a></span><div class="ext-discussiontools-init-section-bar"><div class="ext-discussiontools-init-section-metadata"><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-timestampLabel'>(discussiontools-topicheader-latestcomment: <a href="#c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_&quot;_quote">1614194640</a>)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-commentCountLabel'>(discussiontools-topicheader-commentcount: 1)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-authorCountLabel'>(discussiontools-topicheader-authorcount: 1)</span></div><div class="ext-discussiontools-init-section-actions"><span class='ext-discussiontools-init-section-subscribeButton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-iconElement oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget' data-ooui='{"_":"OO.ui.ButtonWidget","href":"\/w\/index.php?title=Talk:For_parser_cache&amp;action=dtsubscribe&amp;commentname=h-Matma_Rex-2021-02-24T19%3A24%3A00.000Z&amp;section=Heading+with+a+%22+quote","rel":["nofollow"],"framed":false,"icon":"bellOutline","label":"(discussiontools-topicsubscription-button-subscribe-label)","title":"(discussiontools-topicsubscription-button-subscribe-tooltip)","flags":["progressive"],"classes":["ext-discussiontools-init-section-subscribeButton"]}'><a role='button' title='(discussiontools-topicsubscription-button-subscribe-tooltip)' tabindex='0' href='/w/index.php?title=Talk:For_parser_cache&amp;action=dtsubscribe&amp;commentname=h-Matma_Rex-2021-02-24T19%3A24%3A00.000Z&amp;section=Heading+with+a+%22+quote' rel='nofollow' class='oo-ui-buttonElement-button'><span class='oo-ui-iconElement-icon oo-ui-icon-bellOutline oo-ui-image-progressive'></span><span class='oo-ui-labelElement-label'>(discussiontools-topicsubscription-button-subscribe-label)</span><span class='oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progr
Turn comment timestamps into permalinks Bug: T275729 Change-Id: Ica9cfd9743a67fce170e8b078016fa79bf6fbb84
2022-07-30 22:02:17 +00:00
<p><span data-mw-comment-start="" id="c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_&quot;_quote"></span>Test. <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:For_parser_cache#c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_&quot;_quote" class="ext-discussiontools-init-timestamplink">19:24, 24 February 2021 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_&quot;_quote"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-iconElement oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"icon":"share","label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-icon-share oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_&quot;_quote"></span>
CommentFormatter: Add test cases for mobile version Also, rename the files, since CommentFormatter now does more than replies. Change-Id: I1ae432c06badd9790274db27881c2222c0439ba8
2022-07-27 14:19:31 +00:00
</p>
Use setExtensionData() instead of marker comments where possible (3/3) We started using marker comments (HTML comments with special content inserted into the page) for the reply buttons back in the day, because we needed to indicate their location in the HTML. Later we used the same idea for things which aren't actually tied to a specific location in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a better way to do this. This commit stop writing the HTML comments, which are no longer used, and cleans up the tests. Bug: T328980 Change-Id: I37541356830945cc9abcc79d4c445ff6f2449759 (cherry picked from commit ab40ef62c08fe375ea04b254e4df0a28c295544f)
2023-02-07 00:42:00 +00:00
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
<pre>
Use setExtensionData() instead of marker comments where possible (3/3) We started using marker comments (HTML comments with special content inserted into the page) for the reply buttons back in the day, because we needed to indicate their location in the HTML. Later we used the same idea for things which aren't actually tied to a specific location in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a better way to do this. This commit stop writing the HTML comments, which are no longer used, and cleans up the tests. Bug: T328980 Change-Id: I37541356830945cc9abcc79d4c445ff6f2449759 (cherry picked from commit ab40ef62c08fe375ea04b254e4df0a28c295544f)
2023-02-07 00:42:00 +00:00
newestComment: {
"id": "c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_\"_quote",
"timestamp": "2021-02-24T19:24:00.000Z",
"author": "Matma Rex",
"heading": {
"headingLevel": 2,
"name": "h-Matma_Rex-2021-02-24T19:24:00.000Z",
"type": "heading",
"level": 0,
"id": "h-Heading_with_a_\"_quote-2021-02-24T19:24:00.000Z",
"replies": [
"c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_\"_quote"
],
"text": "Heading with a \" quote",
"linkableTitle": "Heading with a \" quote"
}
}
hasLedeContent
hasCommentsInLedeContent
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
{
"wgDiscussionToolsPageThreads": [
{
"headingLevel": null,
"name": "h-Matma_Rex-2021-02-24T19:24:00.000Z",
"type": "heading",
"level": 0,
"id": "h--2021-02-24T19:24:00.000Z",
"replies": [
{
"timestamp": "2021-02-24T19:24:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2021-02-24T19:24:00.000Z",
"replies": []
}
]
},
{
"headingLevel": 2,
"name": "h-Matma_Rex-2021-02-24T19:24:00.000Z",
"type": "heading",
"level": 0,
"id": "h-Heading_with_a_\"_quote-2021-02-24T19:24:00.000Z",
"replies": [
{
"timestamp": "2021-02-24T19:24:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_\"_quote",
"replies": []
}
]
}
]
}
</pre>
Reference in a new issue Copy permalink