wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-19 11:32:16 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Discus.../tests/cases/wrappers/wrappers-formattedreply.html

65 lines
27 KiB
HTML
Raw Normal View History

Move placeholder heading level (99) to a constant Change the HeadingItem constructor to take a 'null' headingLevel and store this internally with the constant. Change the JSON serializer to convert this back to null. Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-06 17:35:43 +00:00
<h2 id="paragraph" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-paragraph-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-paragraph&quot;],&quot;headingLevel&quot;:2,&quot;name&quot;:&quot;h-Matma_Rex-2020-01-22T23:19:00.000Z&quot;}" class="ext-discussiontools-init-section"><span data-mw-comment-start="" id="h-paragraph-2020-01-22T23:19:00.000Z"></span>paragraph<span data-mw-comment-end="h-paragraph-2020-01-22T23:19:00.000Z"></span><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 19:42:45 +00:00
<p><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-paragraph"></span>blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-paragraph&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-paragraph"></span></p>
Fix detecting decorative comment frames with whitespace As a result of 0fc71f60cd464e9cf54c4048985971953503ce51, "empty" text nodes (containing only whitespace) at the end of the comment may be inside the comment's range, and trying to ignore them caused the ranges not to match and the frame not to be detected. Now the code works whether they're inside the comment's range or not. Add a test case for wrapped discussion comments with HTML comments and with whitespace. Bug: T250126 Bug: T268407 Change-Id: I2217ff5a635fd1c9c9e803f46795b1bfb3d17535
2020-12-08 22:46:11 +00:00
Move placeholder heading level (99) to a constant Change the HeadingItem constructor to take a 'null' headingLevel and store this internally with the constant. Change the JSON serializer to convert this back to null. Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-06 17:35:43 +00:00
<h2 id="preformatted" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-preformatted-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-preformatted&quot;],&quot;headingLevel&quot;:2,&quot;name&quot;:&quot;h-Matma_Rex-2020-01-22T23:19:00.000Z&quot;}" class="ext-discussiontools-init-section"><span data-mw-comment-start="" id="h-preformatted-2020-01-22T23:19:00.000Z"></span>preformatted<span data-mw-comment-end="h-preformatted-2020-01-22T23:19:00.000Z"></span><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 19:42:45 +00:00
<pre><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-preformatted"></span>blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-preformatted&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-preformatted"></span></pre>
Fix detecting decorative comment frames with whitespace As a result of 0fc71f60cd464e9cf54c4048985971953503ce51, "empty" text nodes (containing only whitespace) at the end of the comment may be inside the comment's range, and trying to ignore them caused the ranges not to match and the frame not to be detected. Now the code works whether they're inside the comment's range or not. Add a test case for wrapped discussion comments with HTML comments and with whitespace. Bug: T250126 Bug: T268407 Change-Id: I2217ff5a635fd1c9c9e803f46795b1bfb3d17535
2020-12-08 22:46:11 +00:00
Move placeholder heading level (99) to a constant Change the HeadingItem constructor to take a 'null' headingLevel and store this internally with the constant. Change the JSON serializer to convert this back to null. Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-06 17:35:43 +00:00
<h2 id="div_with_one_comment" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-div_with_one_comment-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment&quot;],&quot;headingLevel&quot;:2,&quot;name&quot;:&quot;h-Matma_Rex-2020-01-22T23:19:00.000Z&quot;}" class="ext-discussiontools-init-section"><span data-mw-comment-start="" id="h-div_with_one_comment-2020-01-22T23:19:00.000Z"></span>div with one comment<span data-mw-comment-end="h-div_with_one_comment-2020-01-22T23:19:00.000Z"></span><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
Give comments IDs so they can be scrolled to with hash links Bug: T265268 Change-Id: Idb985ed38bdb74e23cb7840899a61dc919f05f6f
2021-03-10 17:25:52 +00:00
<div style="background: beige;"><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment"></span>
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 19:42:45 +00:00
blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment"></span>
Fix detecting decorative comment frames with whitespace As a result of 0fc71f60cd464e9cf54c4048985971953503ce51, "empty" text nodes (containing only whitespace) at the end of the comment may be inside the comment's range, and trying to ignore them caused the ranges not to match and the frame not to be detected. Now the code works whether they're inside the comment's range or not. Add a test case for wrapped discussion comments with HTML comments and with whitespace. Bug: T250126 Bug: T268407 Change-Id: I2217ff5a635fd1c9c9e803f46795b1bfb3d17535
2020-12-08 22:46:11 +00:00
</div>
Move placeholder heading level (99) to a constant Change the HeadingItem constructor to take a 'null' headingLevel and store this internally with the constant. Change the JSON serializer to convert this back to null. Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-06 17:35:43 +00:00
<h2 id="two_divs_with_one_comment" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-two_divs_with_one_comment-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-two_divs_with_one_comment&quot;],&quot;headingLevel&quot;:2,&quot;name&quot;:&quot;h-Matma_Rex-2020-01-22T23:19:00.000Z&quot;}" class="ext-discussiontools-init-section"><span data-mw-comment-start="" id="h-two_divs_with_one_comment-2020-01-22T23:19:00.000Z"></span>two divs with one comment<span data-mw-comment-end="h-two_divs_with_one_comment-2020-01-22T23:19:00.000Z"></span><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
Give comments IDs so they can be scrolled to with hash links Bug: T265268 Change-Id: Idb985ed38bdb74e23cb7840899a61dc919f05f6f
2021-03-10 17:25:52 +00:00
<div style="background: beige;"><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-two_divs_with_one_comment"></span>
More test cases for comment wrappers (multiple siblings) For a moment I doubted if we handle this case correctly, but in fact I didn't botch that code *this* badly. Change-Id: I5a9d142e4bd97ac40aa388bb43b65ab1286e3f18
2021-02-02 23:03:45 +00:00
blah
</div>
<div style="background: beige;">
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 19:42:45 +00:00
blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-two_divs_with_one_comment&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-two_divs_with_one_comment"></span>
More test cases for comment wrappers (multiple siblings) For a moment I doubted if we handle this case correctly, but in fact I didn't botch that code *this* badly. Change-Id: I5a9d142e4bd97ac40aa388bb43b65ab1286e3f18
2021-02-02 23:03:45 +00:00
</div>
Move placeholder heading level (99) to a constant Change the HeadingItem constructor to take a 'null' headingLevel and store this internally with the constant. Change the JSON serializer to convert this back to null. Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-06 17:35:43 +00:00
<h2 id="div_with_one_comment-htmlcomments" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-div_with_one_comment-htmlcomments-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-htmlcomments&quot;],&quot;headingLevel&quot;:2,&quot;name&quot;:&quot;h-Matma_Rex-2020-01-22T23:19:00.000Z&quot;}" class="ext-discussiontools-init-section"><span data-mw-comment-start="" id="h-div_with_one_comment-htmlcomments-2020-01-22T23:19:00.000Z"></span>div with one comment, and some HTML comments<span data-mw-comment-end="h-div_with_one_comment-htmlcomments-2020-01-22T23:19:00.000Z"></span><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
Fix detecting decorative comment frames with whitespace As a result of 0fc71f60cd464e9cf54c4048985971953503ce51, "empty" text nodes (containing only whitespace) at the end of the comment may be inside the comment's range, and trying to ignore them caused the ranges not to match and the frame not to be detected. Now the code works whether they're inside the comment's range or not. Add a test case for wrapped discussion comments with HTML comments and with whitespace. Bug: T250126 Bug: T268407 Change-Id: I2217ff5a635fd1c9c9e803f46795b1bfb3d17535
2020-12-08 22:46:11 +00:00
<div style="background: beige;">
Give comments IDs so they can be scrolled to with hash links Bug: T265268 Change-Id: Idb985ed38bdb74e23cb7840899a61dc919f05f6f
2021-03-10 17:25:52 +00:00
<i><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-htmlcomments"></span>hello</i><br/>
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 19:42:45 +00:00
<small>blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)</small><!-- blah --><span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-htmlcomments&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-htmlcomments"></span>
Fix detecting decorative comment frames with whitespace As a result of 0fc71f60cd464e9cf54c4048985971953503ce51, "empty" text nodes (containing only whitespace) at the end of the comment may be inside the comment's range, and trying to ignore them caused the ranges not to match and the frame not to be detected. Now the code works whether they're inside the comment's range or not. Add a test case for wrapped discussion comments with HTML comments and with whitespace. Bug: T250126 Bug: T268407 Change-Id: I2217ff5a635fd1c9c9e803f46795b1bfb3d17535
2020-12-08 22:46:11 +00:00
</div><!-- blah -->
Move placeholder heading level (99) to a constant Change the HeadingItem constructor to take a 'null' headingLevel and store this internally with the constant. Change the JSON serializer to convert this back to null. Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-06 17:35:43 +00:00
<h2 id="two_divs_with_one_comment-htmlcomments" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-two_divs_with_one_comment-htmlcomments-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-two_divs_with_one_comment-htmlcomments&quot;],&quot;headingLevel&quot;:2,&quot;name&quot;:&quot;h-Matma_Rex-2020-01-22T23:19:00.000Z&quot;}" class="ext-discussiontools-init-section"><span data-mw-comment-start="" id="h-two_divs_with_one_comment-htmlcomments-2020-01-22T23:19:00.000Z"></span>two divs with one comment, and some HTML comments<span data-mw-comment-end="h-two_divs_with_one_comment-htmlcomments-2020-01-22T23:19:00.000Z"></span><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
Give comments IDs so they can be scrolled to with hash links Bug: T265268 Change-Id: Idb985ed38bdb74e23cb7840899a61dc919f05f6f
2021-03-10 17:25:52 +00:00
<div style="background: beige;"><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-two_divs_with_one_comment-htmlcomments"></span>
More test cases for comment wrappers (multiple siblings) For a moment I doubted if we handle this case correctly, but in fact I didn't botch that code *this* badly. Change-Id: I5a9d142e4bd97ac40aa388bb43b65ab1286e3f18
2021-02-02 23:03:45 +00:00
blah
</div>
<!-- blah -->
<div style="background: beige;">
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 19:42:45 +00:00
blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-two_divs_with_one_comment-htmlcomments&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-two_divs_with_one_comment-htmlcomments"></span>
More test cases for comment wrappers (multiple siblings) For a moment I doubted if we handle this case correctly, but in fact I didn't botch that code *this* badly. Change-Id: I5a9d142e4bd97ac40aa388bb43b65ab1286e3f18
2021-02-02 23:03:45 +00:00
</div><!-- blah -->
Move placeholder heading level (99) to a constant Change the HeadingItem constructor to take a 'null' headingLevel and store this internally with the constant. Change the JSON serializer to convert this back to null. Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-06 17:35:43 +00:00
<h2 id="div_with_one_comment-list_end" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-div_with_one_comment-list_end-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-list_end&quot;],&quot;headingLevel&quot;:2,&quot;name&quot;:&quot;h-Matma_Rex-2020-01-22T23:19:00.000Z&quot;}" class="ext-discussiontools-init-section"><span data-mw-comment-start="" id="h-div_with_one_comment-list_end-2020-01-22T23:19:00.000Z"></span>div with one comment, ends with a list<span data-mw-comment-end="h-div_with_one_comment-list_end-2020-01-22T23:19:00.000Z"></span><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
Fix replying outside wrappers for partially indented comments Top-level comments that start or end with a list (inconsistent indentation) would not have triggered the logic for detecting wrappers. Bug: T273692 Change-Id: Idcb4eed73e391f5f86eca2eb05cb3cea0d86f30a
2021-02-08 20:52:30 +00:00
<div style="background: beige;">
Give comments IDs so they can be scrolled to with hash links Bug: T265268 Change-Id: Idb985ed38bdb74e23cb7840899a61dc919f05f6f
2021-03-10 17:25:52 +00:00
<p><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-list_end"></span>hello</p>
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 19:42:45 +00:00
<ul><li>blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-list_end&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-list_end"></span></li></ul>
Fix replying outside wrappers for partially indented comments Top-level comments that start or end with a list (inconsistent indentation) would not have triggered the logic for detecting wrappers. Bug: T273692 Change-Id: Idcb4eed73e391f5f86eca2eb05cb3cea0d86f30a
2021-02-08 20:52:30 +00:00
</div>
Move placeholder heading level (99) to a constant Change the HeadingItem constructor to take a 'null' headingLevel and store this internally with the constant. Change the JSON serializer to convert this back to null. Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-06 17:35:43 +00:00
<h2 id="div_with_one_comment-list_start" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-div_with_one_comment-list_start-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-list_start&quot;],&quot;headingLevel&quot;:2,&quot;name&quot;:&quot;h-Matma_Rex-2020-01-22T23:19:00.000Z&quot;}" class="ext-discussiontools-init-section"><span data-mw-comment-start="" id="h-div_with_one_comment-list_start-2020-01-22T23:19:00.000Z"></span>div with one comment, starts with a list<span data-mw-comment-end="h-div_with_one_comment-list_start-2020-01-22T23:19:00.000Z"></span><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
Fix replying outside wrappers for partially indented comments Top-level comments that start or end with a list (inconsistent indentation) would not have triggered the logic for detecting wrappers. Bug: T273692 Change-Id: Idcb4eed73e391f5f86eca2eb05cb3cea0d86f30a
2021-02-08 20:52:30 +00:00
<div style="background: beige;">
Give comments IDs so they can be scrolled to with hash links Bug: T265268 Change-Id: Idb985ed38bdb74e23cb7840899a61dc919f05f6f
2021-03-10 17:25:52 +00:00
<ul><li><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-list_start"></span>hello</li></ul>
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 19:42:45 +00:00
<p>blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-list_start&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_one_comment-list_start"></span></p>
Fix replying outside wrappers for partially indented comments Top-level comments that start or end with a list (inconsistent indentation) would not have triggered the logic for detecting wrappers. Bug: T273692 Change-Id: Idcb4eed73e391f5f86eca2eb05cb3cea0d86f30a
2021-02-08 20:52:30 +00:00
</div>
Move placeholder heading level (99) to a constant Change the HeadingItem constructor to take a 'null' headingLevel and store this internally with the constant. Change the JSON serializer to convert this back to null. Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-06 17:35:43 +00:00
<h2 id="table_with_one_comment" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-table_with_one_comment-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_one_comment&quot;],&quot;headingLevel&quot;:2,&quot;name&quot;:&quot;h-Matma_Rex-2020-01-22T23:19:00.000Z&quot;}" class="ext-discussiontools-init-section"><span data-mw-comment-start="" id="h-table_with_one_comment-2020-01-22T23:19:00.000Z"></span>table with one comment<span data-mw-comment-end="h-table_with_one_comment-2020-01-22T23:19:00.000Z"></span><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
Give comments IDs so they can be scrolled to with hash links Bug: T265268 Change-Id: Idb985ed38bdb74e23cb7840899a61dc919f05f6f
2021-03-10 17:25:52 +00:00
<table border="1"><tbody><tr><td><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_one_comment"></span>
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 19:42:45 +00:00
blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_one_comment&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_one_comment"></span>
Fix detecting decorative comment frames with whitespace As a result of 0fc71f60cd464e9cf54c4048985971953503ce51, "empty" text nodes (containing only whitespace) at the end of the comment may be inside the comment's range, and trying to ignore them caused the ranges not to match and the frame not to be detected. Now the code works whether they're inside the comment's range or not. Add a test case for wrapped discussion comments with HTML comments and with whitespace. Bug: T250126 Bug: T268407 Change-Id: I2217ff5a635fd1c9c9e803f46795b1bfb3d17535
2020-12-08 22:46:11 +00:00
</td></tr></tbody></table>
Move placeholder heading level (99) to a constant Change the HeadingItem constructor to take a 'null' headingLevel and store this internally with the constant. Change the JSON serializer to convert this back to null. Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-06 17:35:43 +00:00
<h2 id="div_with_multiple_comments" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-div_with_multiple_comments-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_multiple_comments&quot;,&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_multiple_comments-1&quot;],&quot;headingLevel&quot;:2,&quot;name&quot;:&quot;h-Matma_Rex-2020-01-22T23:19:00.000Z&quot;}" class="ext-discussiontools-init-section"><span data-mw-comment-start="" id="h-div_with_multiple_comments-2020-01-22T23:19:00.000Z"></span>div with multiple comments<span data-mw-comment-end="h-div_with_multiple_comments-2020-01-22T23:19:00.000Z"></span><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
Give comments IDs so they can be scrolled to with hash links Bug: T265268 Change-Id: Idb985ed38bdb74e23cb7840899a61dc919f05f6f
2021-03-10 17:25:52 +00:00
<div style="background: beige;"><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_multiple_comments"></span>
Fix inserting comment start markers when they're outside of any wrappers Comment boundaries are stored as a DOM parent node plus a child index. Because of that, inserting anything into the DOM before a comment – such as another comment's start/end markers – would cause us to insert subsequent comments' markers into the wrong places. This issue didn't affect many pages, because usually any parent node would have just one comment in it. Only pages with comment boundaries outside of any wrappers (directly inside the root node) were broken. Just process the list in reverse to fix this. Bug: T298096 Change-Id: Iccffc36b71e9fcf3d72c4db2b9459d39042f7a2d
2021-12-21 14:20:18 +00:00
blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_multiple_comments&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-Matma_Rex-2020-01-22T23:19:00.000Z&quot;],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_multiple_comments"></span>
<dl><dd><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-Matma_Rex-2020-01-22T23:19:00.000Z"></span>blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:2,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-Matma_Rex-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-Matma_Rex-2020-01-22T23:19:00.000Z"></span></dd></dl><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_multiple_comments-1"></span>
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 19:42:45 +00:00
blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_multiple_comments-1&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-div_with_multiple_comments-1"></span>
Fix detecting decorative comment frames with whitespace As a result of 0fc71f60cd464e9cf54c4048985971953503ce51, "empty" text nodes (containing only whitespace) at the end of the comment may be inside the comment's range, and trying to ignore them caused the ranges not to match and the frame not to be detected. Now the code works whether they're inside the comment's range or not. Add a test case for wrapped discussion comments with HTML comments and with whitespace. Bug: T250126 Bug: T268407 Change-Id: I2217ff5a635fd1c9c9e803f46795b1bfb3d17535
2020-12-08 22:46:11 +00:00
</div>
Move placeholder heading level (99) to a constant Change the HeadingItem constructor to take a 'null' headingLevel and store this internally with the constant. Change the JSON serializer to convert this back to null. Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
2022-06-06 17:35:43 +00:00
<h2 id="table_with_multiple_comments" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-table_with_multiple_comments-2020-01-22T23:19:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_multiple_comments&quot;,&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_multiple_comments-1&quot;],&quot;headingLevel&quot;:2,&quot;name&quot;:&quot;h-Matma_Rex-2020-01-22T23:19:00.000Z&quot;}" class="ext-discussiontools-init-section"><span data-mw-comment-start="" id="h-table_with_multiple_comments-2020-01-22T23:19:00.000Z"></span>table with multiple comments<span data-mw-comment-end="h-table_with_multiple_comments-2020-01-22T23:19:00.000Z"></span><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
Give comments IDs so they can be scrolled to with hash links Bug: T265268 Change-Id: Idb985ed38bdb74e23cb7840899a61dc919f05f6f
2021-03-10 17:25:52 +00:00
<table border="1"><tbody><tr><td><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_multiple_comments"></span>
Fix inserting comment start markers when they're outside of any wrappers Comment boundaries are stored as a DOM parent node plus a child index. Because of that, inserting anything into the DOM before a comment – such as another comment's start/end markers – would cause us to insert subsequent comments' markers into the wrong places. This issue didn't affect many pages, because usually any parent node would have just one comment in it. Only pages with comment boundaries outside of any wrappers (directly inside the root node) were broken. Just process the list in reverse to fix this. Bug: T298096 Change-Id: Iccffc36b71e9fcf3d72c4db2b9459d39042f7a2d
2021-12-21 14:20:18 +00:00
blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_multiple_comments&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-Matma_Rex-2020-01-22T23:19:00.000Z-1&quot;],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_multiple_comments"></span>
<dl><dd><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-Matma_Rex-2020-01-22T23:19:00.000Z-1"></span>blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:2,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-Matma_Rex-2020-01-22T23:19:00.000Z-1&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-Matma_Rex-2020-01-22T23:19:00.000Z-1"></span></dd></dl><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_multiple_comments-1"></span>
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4
2021-06-02 19:42:45 +00:00
blah blah <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 23:19, 22 January 2020 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_multiple_comments-1&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2020-01-22T23:19:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-22T23:19:00.000Z-table_with_multiple_comments-1"></span>
Fix detecting decorative comment frames with whitespace As a result of 0fc71f60cd464e9cf54c4048985971953503ce51, "empty" text nodes (containing only whitespace) at the end of the comment may be inside the comment's range, and trying to ignore them caused the ranges not to match and the frame not to be detected. Now the code works whether they're inside the comment's range or not. Add a test case for wrapped discussion comments with HTML comments and with whitespace. Bug: T250126 Bug: T268407 Change-Id: I2217ff5a635fd1c9c9e803f46795b1bfb3d17535
2020-12-08 22:46:11 +00:00
</td></tr></tbody></table>
Reference in a new issue Copy permalink