wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-13 18:37:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Discus.../.phpcs.xml

14 lines
682 B
XML
Raw Normal View History

build: Add missing .phpcs.xml and make pass Add .phpcs.xml to run codesniffer against the extension. The entry in composer.json is already there Change-Id: If9de7e9b1b9439dc4d5fa2ba521883d13deaa739
2020-01-13 19:48:11 +00:00
<?xml version="1.0"?>
<ruleset>
The Great Parser JS to PHP port of 2020!* * Not to be confused with the Parsing Team's "Great Parser JS to PHP port of 2019" Gasp as OR hacks are changed to null coalescing operators. Applaud as variable declarations are dropped. Cheer as parameters and return values are type-hinted. Shudder as DomNodeLists have no indexOf method. Moving discussion parsing to the server should allow us to implement much cleaner APIs for commenting. Bug: T252252 Co-authored-by: Ed Sanders <esanders@wikimedia.org> Change-Id: Ic1438d516e223db462cb227f6668e856672f538c
2019-12-10 02:38:17 +00:00
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
Remove some redundant PHPDoc comments Inspired by this Wikitech-l discussion: https://lists.wikimedia.org/hyperkitty/list/wikitech-l@lists.wikimedia.org/thread/NWXPNHRNLEVXHSWX33H473OAWQP6CDOA/ To keep this simple for now, I am only removing redundant PHPDoc comments on constructors, and only when all the documentation for parameters completely duplicates type hints. More could be done, but that can happen later when we have better tooling. Redundant comments on constructors that take a dozen services are by far the most annoying for me and I want them gone now. Change-Id: I86cbf7d6e48035cfa06f780c8fb1b02e68709a0c
2022-11-24 18:56:08 +00:00
<!-- Do not require redundant documentation comments, we mostly use type hints -->
build: Updating mediawiki/mediawiki-codesniffer to 32.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate * MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected * MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic Additional changes: * Dropped .inc files from .phpcs.xml (T200956). Change-Id: I340d6b573e9ae2a99085fb19a705fcf567b03f92
2020-10-29 10:52:56 +00:00
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic" />
The Great Parser JS to PHP port of 2020!* * Not to be confused with the Parsing Team's "Great Parser JS to PHP port of 2019" Gasp as OR hacks are changed to null coalescing operators. Applaud as variable declarations are dropped. Cheer as parameters and return values are type-hinted. Shudder as DomNodeLists have no indexOf method. Moving discussion parsing to the server should allow us to implement much cleaner APIs for commenting. Bug: T252252 Co-authored-by: Ed Sanders <esanders@wikimedia.org> Change-Id: Ic1438d516e223db462cb227f6668e856672f538c
2019-12-10 02:38:17 +00:00
<exclude name="MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures" />
</rule>
build: Add missing .phpcs.xml and make pass Add .phpcs.xml to run codesniffer against the extension. The entry in composer.json is already there Change-Id: If9de7e9b1b9439dc4d5fa2ba521883d13deaa739
2020-01-13 19:48:11 +00:00
<file>.</file>
build: Updating mediawiki/mediawiki-codesniffer to 32.0.0 The following sniffs are failing and were disabled: * MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate * MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected * MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPublic Additional changes: * Dropped .inc files from .phpcs.xml (T200956). Change-Id: I340d6b573e9ae2a99085fb19a705fcf567b03f92
2020-10-29 10:52:56 +00:00
<arg name="extensions" value="php" />
build: Add missing .phpcs.xml and make pass Add .phpcs.xml to run codesniffer against the extension. The entry in composer.json is already there Change-Id: If9de7e9b1b9439dc4d5fa2ba521883d13deaa739
2020-01-13 19:48:11 +00:00
<arg name="encoding" value="UTF-8" />
</ruleset>
Reference in a new issue Copy permalink