2019-12-10 02:38:17 +00:00
|
|
|
<?php
|
|
|
|
|
2020-05-14 22:44:49 +00:00
|
|
|
namespace MediaWiki\Extension\DiscussionTools\Tests;
|
|
|
|
|
|
|
|
use DateTimeImmutable;
|
|
|
|
use DOMElement;
|
|
|
|
use DOMNode;
|
2020-06-16 20:13:31 +00:00
|
|
|
use Error;
|
2020-05-22 16:26:05 +00:00
|
|
|
use MediaWiki\Extension\DiscussionTools\CommentItem;
|
2020-05-14 22:44:49 +00:00
|
|
|
use MediaWiki\Extension\DiscussionTools\CommentParser;
|
|
|
|
use MediaWiki\Extension\DiscussionTools\CommentUtils;
|
2020-05-22 16:26:05 +00:00
|
|
|
use MediaWiki\Extension\DiscussionTools\HeadingItem;
|
2020-05-22 13:47:21 +00:00
|
|
|
use MediaWiki\Extension\DiscussionTools\ImmutableRange;
|
2020-05-22 16:26:05 +00:00
|
|
|
use MediaWiki\Extension\DiscussionTools\ThreadItem;
|
2020-05-14 23:09:20 +00:00
|
|
|
use stdClass;
|
2019-12-10 02:38:17 +00:00
|
|
|
use Wikimedia\TestingAccessWrapper;
|
|
|
|
|
|
|
|
/**
|
2020-05-15 21:08:25 +00:00
|
|
|
* @coversDefaultClass \MediaWiki\Extension\DiscussionTools\CommentParser
|
2020-05-14 22:44:49 +00:00
|
|
|
*
|
|
|
|
* @group DiscussionTools
|
2019-12-10 02:38:17 +00:00
|
|
|
*/
|
2020-05-14 22:44:49 +00:00
|
|
|
class CommentParserTest extends CommentTestCase {
|
2019-12-10 02:38:17 +00:00
|
|
|
|
2020-05-13 20:24:35 +00:00
|
|
|
/**
|
|
|
|
* Convert UTF-8 byte offsets to UTF-16 code unit offsets.
|
|
|
|
*
|
|
|
|
* @param DOMElement $ancestor
|
|
|
|
* @param DOMNode $node
|
|
|
|
* @param int $nodeOffset
|
2020-05-14 23:09:20 +00:00
|
|
|
* @return string
|
2020-05-13 20:24:35 +00:00
|
|
|
*/
|
2020-05-14 23:09:20 +00:00
|
|
|
private static function getOffsetPath(
|
|
|
|
DOMElement $ancestor, DOMNode $node, int $nodeOffset
|
|
|
|
) : string {
|
2020-05-13 20:24:35 +00:00
|
|
|
if ( $node->nodeType === XML_TEXT_NODE ) {
|
|
|
|
$startNode = $node;
|
|
|
|
$nodeText = '';
|
|
|
|
|
|
|
|
while ( $node ) {
|
|
|
|
$nodeText .= $node->nodeValue;
|
|
|
|
|
|
|
|
// In Parsoid HTML, entities are represented as a 'mw:Entity' node, rather than normal HTML
|
|
|
|
// entities. On Arabic Wikipedia, the "UTC" timezone name contains some non-breaking spaces,
|
|
|
|
// which apparently are often turned into entities by buggy editing tools. To handle
|
|
|
|
// this, we must piece together the text, so that our regexp can match those timestamps.
|
|
|
|
if (
|
|
|
|
$node->nextSibling &&
|
|
|
|
$node->nextSibling->nodeType === XML_ELEMENT_NODE &&
|
|
|
|
$node->nextSibling->getAttribute( 'typeof' ) === 'mw:Entity'
|
|
|
|
) {
|
|
|
|
$nodeText .= $node->nextSibling->firstChild->nodeValue;
|
|
|
|
|
|
|
|
// If the entity is followed by more text, do this again
|
|
|
|
if (
|
|
|
|
$node->nextSibling->nextSibling &&
|
|
|
|
$node->nextSibling->nextSibling->nodeType === XML_TEXT_NODE
|
|
|
|
) {
|
|
|
|
$node = $node->nextSibling->nextSibling;
|
|
|
|
} else {
|
|
|
|
$node = null;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
$node = null;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$str = substr( $nodeText, 0, $nodeOffset );
|
|
|
|
// Count characters that require two code units to encode in UTF-16
|
|
|
|
$count = preg_match_all( '/[\x{010000}-\x{10FFFF}]/u', $str );
|
|
|
|
$nodeOffset = mb_strlen( $str ) + $count;
|
|
|
|
|
|
|
|
$node = $startNode;
|
|
|
|
}
|
|
|
|
|
2020-05-05 13:12:51 +00:00
|
|
|
$path = [ $nodeOffset ];
|
|
|
|
while ( $node !== $ancestor ) {
|
|
|
|
if ( !$node->parentNode ) {
|
|
|
|
throw new Error( 'Not a descendant' );
|
|
|
|
}
|
2020-05-14 22:44:49 +00:00
|
|
|
array_unshift( $path, CommentUtils::childIndexOf( $node ) );
|
2020-05-05 13:12:51 +00:00
|
|
|
$node = $node->parentNode;
|
|
|
|
}
|
|
|
|
return implode( '/', $path );
|
|
|
|
}
|
|
|
|
|
2020-05-22 16:26:05 +00:00
|
|
|
private static function serializeComments( ThreadItem &$threadItem, DOMElement $root ) : stdClass {
|
|
|
|
$serialized = new stdClass();
|
|
|
|
|
|
|
|
$serialized->type = $threadItem->getType();
|
|
|
|
$serialized->level = $threadItem->getLevel();
|
2020-05-05 13:12:51 +00:00
|
|
|
|
|
|
|
// Can't serialize the DOM nodes involved in the range,
|
|
|
|
// instead use their offsets within their parent nodes
|
2020-05-22 16:26:05 +00:00
|
|
|
$range = $threadItem->getRange();
|
|
|
|
$serialized->id = $threadItem->getId();
|
|
|
|
$serialized->range = [
|
|
|
|
self::getOffsetPath( $root, $range->startContainer, $range->startOffset ),
|
|
|
|
self::getOffsetPath( $root, $range->endContainer, $range->endOffset )
|
2020-05-05 13:12:51 +00:00
|
|
|
];
|
2020-05-22 16:26:05 +00:00
|
|
|
$serialized->replies = [];
|
|
|
|
foreach ( $threadItem->getReplies() as $reply ) {
|
|
|
|
$serialized->replies[] = self::serializeComments( $reply, $root );
|
|
|
|
}
|
|
|
|
|
|
|
|
if ( $threadItem instanceof CommentItem ) {
|
|
|
|
$serialized->signatureRanges = array_map( function ( ImmutableRange $range ) use ( $root ) {
|
2020-05-05 13:12:51 +00:00
|
|
|
return [
|
|
|
|
self::getOffsetPath( $root, $range->startContainer, $range->startOffset ),
|
|
|
|
self::getOffsetPath( $root, $range->endContainer, $range->endOffset )
|
|
|
|
];
|
2020-05-22 16:26:05 +00:00
|
|
|
}, $threadItem->getSignatureRanges() );
|
|
|
|
$serialized->timestamp = $threadItem->getTimestamp();
|
|
|
|
$serialized->author = $threadItem->getAuthor();
|
|
|
|
$warnings = $threadItem->getWarnings();
|
|
|
|
if ( count( $warnings ) ) {
|
|
|
|
$serialized->warnings = $threadItem->getWarnings();
|
|
|
|
}
|
2020-05-05 13:12:51 +00:00
|
|
|
}
|
|
|
|
|
2020-05-22 16:26:05 +00:00
|
|
|
if ( $threadItem instanceof HeadingItem && $threadItem->isPlaceholderHeading() ) {
|
|
|
|
$serialized->placeholderHeading = $threadItem->isPlaceholderHeading();
|
2020-05-05 13:12:51 +00:00
|
|
|
}
|
2020-05-22 16:26:05 +00:00
|
|
|
|
|
|
|
return $serialized;
|
2020-05-05 13:12:51 +00:00
|
|
|
}
|
|
|
|
|
2019-12-10 02:38:17 +00:00
|
|
|
/**
|
|
|
|
* @dataProvider provideTimestampRegexps
|
|
|
|
* @covers ::getTimestampRegexp
|
|
|
|
*/
|
2020-05-14 23:09:20 +00:00
|
|
|
public function testGetTimestampRegexp(
|
|
|
|
string $format, string $expected, string $message
|
|
|
|
) : void {
|
2019-12-10 02:38:17 +00:00
|
|
|
$parser = TestingAccessWrapper::newFromObject(
|
2020-05-14 22:44:49 +00:00
|
|
|
CommentParser::newFromGlobalState()
|
2019-12-10 02:38:17 +00:00
|
|
|
);
|
|
|
|
|
|
|
|
// HACK: Fix differences between JS & PHP regexes
|
|
|
|
// TODO: We may just have to have two version in the test data
|
|
|
|
$expected = preg_replace( '/\\\\u([0-9A-F]+)/', '\\\\x{$1}', $expected );
|
|
|
|
$expected = str_replace( ':', '\:', $expected );
|
|
|
|
$expected = '/' . $expected . '/u';
|
|
|
|
|
|
|
|
$result = $parser->getTimestampRegexp( $format, '\\d', [ 'UTC' => 'UTC' ] );
|
|
|
|
self::assertSame( $expected, $result, $message );
|
|
|
|
}
|
|
|
|
|
2020-05-14 23:09:20 +00:00
|
|
|
public function provideTimestampRegexps() : array {
|
2020-05-18 20:07:00 +00:00
|
|
|
return self::getJson( '../cases/timestamp-regex.json' );
|
2019-12-10 02:38:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider provideTimestampParser
|
|
|
|
* @covers ::getTimestampParser
|
|
|
|
*/
|
2020-05-14 23:09:20 +00:00
|
|
|
public function testGetTimestampParser(
|
|
|
|
string $format, array $data, string $expected, string $message
|
|
|
|
) : void {
|
2019-12-10 02:38:17 +00:00
|
|
|
$parser = TestingAccessWrapper::newFromObject(
|
2020-05-14 22:44:49 +00:00
|
|
|
CommentParser::newFromGlobalState()
|
2019-12-10 02:38:17 +00:00
|
|
|
);
|
|
|
|
|
|
|
|
$expected = new DateTimeImmutable( $expected );
|
|
|
|
|
|
|
|
$tsParser = $parser->getTimestampParser( $format, null, 'UTC', [ 'UTC' => 'UTC' ] );
|
|
|
|
self::assertEquals( $expected, $tsParser( $data ), $message );
|
|
|
|
}
|
|
|
|
|
2020-05-14 23:09:20 +00:00
|
|
|
public function provideTimestampParser() : array {
|
2020-05-18 20:07:00 +00:00
|
|
|
return self::getJson( '../cases/timestamp-parser.json' );
|
2019-12-10 02:38:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider provideTimestampParserDST
|
|
|
|
* @covers ::getTimestampParser
|
|
|
|
*/
|
|
|
|
public function testGetTimestampParserDST(
|
2020-05-14 23:09:20 +00:00
|
|
|
string $sample, string $expected, string $expectedUtc, string $format,
|
|
|
|
string $timezone, array $timezoneAbbrs, string $message
|
|
|
|
) : void {
|
2019-12-10 02:38:17 +00:00
|
|
|
$parser = TestingAccessWrapper::newFromObject(
|
2020-05-14 22:44:49 +00:00
|
|
|
CommentParser::newFromGlobalState()
|
2019-12-10 02:38:17 +00:00
|
|
|
);
|
|
|
|
|
|
|
|
$regexp = $parser->getTimestampRegexp( $format, '\\d', $timezoneAbbrs );
|
|
|
|
$tsParser = $parser->getTimestampParser( $format, null, $timezone, $timezoneAbbrs );
|
|
|
|
|
|
|
|
$expected = new DateTimeImmutable( $expected );
|
|
|
|
$expectedUtc = new DateTimeImmutable( $expectedUtc );
|
|
|
|
|
|
|
|
preg_match( $regexp, $sample, $match, PREG_OFFSET_CAPTURE );
|
|
|
|
$date = $tsParser( $match );
|
|
|
|
|
|
|
|
self::assertEquals( $expected, $date, $message );
|
|
|
|
self::assertEquals( $expectedUtc, $date, $message );
|
|
|
|
}
|
|
|
|
|
2020-05-14 23:09:20 +00:00
|
|
|
public function provideTimestampParserDST() : array {
|
2020-05-18 20:07:00 +00:00
|
|
|
return self::getJson( '../cases/timestamp-parser-dst.json' );
|
2019-12-10 02:38:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider provideAuthors
|
|
|
|
* @covers ::getAuthors
|
|
|
|
*/
|
2020-05-22 16:26:05 +00:00
|
|
|
public function testGetAuthors( array $thread, array $expected ) : void {
|
2020-05-14 22:44:49 +00:00
|
|
|
$parser = CommentParser::newFromGlobalState();
|
2020-05-22 16:26:05 +00:00
|
|
|
$doc = $this->createDocument( '' );
|
|
|
|
$node = $doc->createElement( 'div' );
|
|
|
|
$range = new ImmutableRange( $node, 0, $node, 0 );
|
|
|
|
|
|
|
|
$makeThreadItem = function ( array $arr ) use ( &$makeThreadItem, $range ) : ThreadItem {
|
|
|
|
if ( $arr['type'] === 'comment' ) {
|
|
|
|
$item = new CommentItem( 1, $range );
|
|
|
|
$item->setAuthor( $arr['author'] );
|
|
|
|
} else {
|
|
|
|
$item = new HeadingItem( $range );
|
|
|
|
}
|
|
|
|
foreach ( $arr['replies'] as $reply ) {
|
|
|
|
$item->addReply( $makeThreadItem( $reply ) );
|
|
|
|
}
|
|
|
|
return $item;
|
|
|
|
};
|
|
|
|
|
|
|
|
$threadItem = $makeThreadItem( $thread );
|
2019-12-10 02:38:17 +00:00
|
|
|
|
2020-05-22 16:26:05 +00:00
|
|
|
self::assertEquals( $expected, $parser->getAuthors( $threadItem ) );
|
2019-12-10 02:38:17 +00:00
|
|
|
}
|
|
|
|
|
2020-05-14 23:09:20 +00:00
|
|
|
public function provideAuthors() : array {
|
2020-05-22 16:26:05 +00:00
|
|
|
return self::getJson( '../cases/authors.json' );
|
2019-12-10 02:38:17 +00:00
|
|
|
}
|
2020-05-05 13:12:51 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider provideComments
|
|
|
|
* @covers ::getComments
|
|
|
|
* @covers ::groupThreads
|
|
|
|
*/
|
2020-05-14 23:09:20 +00:00
|
|
|
public function testGetComments(
|
|
|
|
string $name, string $dom, string $expected, string $config, string $data
|
|
|
|
) : void {
|
2020-05-11 15:52:06 +00:00
|
|
|
$dom = self::getHtml( $dom );
|
2020-05-05 13:12:51 +00:00
|
|
|
$expected = self::getJson( $expected );
|
|
|
|
$config = self::getJson( $config );
|
|
|
|
$data = self::getJson( $data );
|
|
|
|
|
2020-05-11 15:52:06 +00:00
|
|
|
$this->setupEnv( $config, $data );
|
2020-05-15 00:51:36 +00:00
|
|
|
$parser = self::createParser( $data );
|
2020-05-05 13:12:51 +00:00
|
|
|
|
2020-05-11 15:52:06 +00:00
|
|
|
$doc = self::createDocument( $dom );
|
2020-06-16 20:13:31 +00:00
|
|
|
$body = $doc->getElementsByTagName( 'body' )->item( 0 );
|
2020-05-05 13:12:51 +00:00
|
|
|
|
2020-06-16 20:13:31 +00:00
|
|
|
$comments = $parser->getComments( $body );
|
2020-05-15 00:51:36 +00:00
|
|
|
$threads = $parser->groupThreads( $comments );
|
2020-05-05 13:12:51 +00:00
|
|
|
|
|
|
|
$processedThreads = [];
|
|
|
|
|
|
|
|
foreach ( $threads as $i => $thread ) {
|
2020-06-16 20:13:31 +00:00
|
|
|
$thread = self::serializeComments( $thread, $body );
|
2020-05-05 13:12:51 +00:00
|
|
|
$thread = json_decode( json_encode( $thread ), true );
|
|
|
|
$processedThreads[] = $thread;
|
|
|
|
self::assertEquals( $expected[$i], $processedThreads[$i], $name . ' section ' . $i );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-05-14 23:09:20 +00:00
|
|
|
public function provideComments() : array {
|
2020-05-18 20:07:00 +00:00
|
|
|
return self::getJson( '../cases/comments.json' );
|
2020-05-05 13:12:51 +00:00
|
|
|
}
|
2020-05-15 00:51:36 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider provideTranscludedFrom
|
2020-07-19 19:47:44 +00:00
|
|
|
* @covers ::getTranscludedFrom
|
2020-05-18 19:33:05 +00:00
|
|
|
* @covers \MediaWiki\Extension\DiscussionTools\CommentUtils::unwrapParsoidSections
|
2020-05-15 00:51:36 +00:00
|
|
|
*/
|
|
|
|
public function testGetTranscludedFrom(
|
|
|
|
string $name, string $dom, string $expected, string $config, string $data
|
|
|
|
) : void {
|
|
|
|
$dom = self::getHtml( $dom );
|
|
|
|
$expected = self::getJson( $expected );
|
|
|
|
$config = self::getJson( $config );
|
|
|
|
$data = self::getJson( $data );
|
|
|
|
|
|
|
|
$this->setupEnv( $config, $data );
|
|
|
|
$parser = self::createParser( $data );
|
|
|
|
|
|
|
|
$doc = self::createDocument( $dom );
|
2020-07-15 16:21:23 +00:00
|
|
|
$container = $doc->getElementsByTagName( 'body' )->item( 0 );
|
2020-05-15 00:51:36 +00:00
|
|
|
|
2020-06-16 20:13:31 +00:00
|
|
|
CommentUtils::unwrapParsoidSections( $container );
|
2020-05-15 00:51:36 +00:00
|
|
|
|
|
|
|
$comments = $parser->getComments( $container );
|
2020-07-01 16:04:02 +00:00
|
|
|
$parser->groupThreads( $comments );
|
2020-05-15 00:51:36 +00:00
|
|
|
|
|
|
|
$transcludedFrom = [];
|
|
|
|
foreach ( $comments as $comment ) {
|
2020-05-22 16:26:05 +00:00
|
|
|
if ( $comment instanceof CommentItem ) {
|
|
|
|
$transcludedFrom[ $comment->getId() ] =
|
2020-05-15 00:51:36 +00:00
|
|
|
$parser->getTranscludedFrom( $comment );
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
self::assertEquals(
|
|
|
|
$expected,
|
|
|
|
$transcludedFrom,
|
|
|
|
$name
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function provideTranscludedFrom() : array {
|
2020-05-18 20:07:00 +00:00
|
|
|
return self::getJson( '../cases/transcluded.json' );
|
2020-05-15 00:51:36 +00:00
|
|
|
}
|
|
|
|
|
2019-12-10 02:38:17 +00:00
|
|
|
}
|