wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-11 16:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Discus.../tests/cases/for-parser-cache/for-parser-cache-formatted-desktop.html

70 lines
7.8 KiB
HTML
Raw Normal View History

Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
<span data-mw-thread-id="h--2021-02-24T19:24:00.000Z"><span data-mw-comment-start="" id="h--2021-02-24T19:24:00.000Z"></span><span data-mw-comment-end="h--2021-02-24T19:24:00.000Z"></span></span><span data-mw-comment-start="" id="c-Matma_Rex-2021-02-24T19:24:00.000Z"></span><style data-mw-deduplicate="TemplateStyles:r3303">.mw-parser-output .color-purple{color:purple}</style><div class="color-purple">This page demonstrates some quirks of raw HTML generated in ParserOutput, which gets saved to the parser cache and which we operate on in the ParserAfterTidy hook. Most other test cases are using the final HTML returned by ParserOutput::getText(), which we operate on in the OutputPageBeforeHTML hook.</div>
CommentFormatter: Fix inserting placeholder heading marker This code expected $container->firstChild to be a <div class="mw-parser-output">, but that element is not present when we're running on HTML to be saved in parser cache. We ended up inserting the marker inside whatever node was the first on the page, and if it was a <style> element, both our marker and the styles would be lost when serializing, like in 6c7a0ca9a2c1e40d5de90b88f79ba2646d647f80. When we're running on final HTML, the marker will now be outside of <div class="mw-parser-output">, but that seems to be fine. Only early versions of I4e60fdbc098c1a74757d6e60fec6bcf8e5db37c1 had problems with that (see comments on patchset 41), but it works now. The added test case also covers the fix for T274709. Bug: T275440 Change-Id: I38d45dd8686919be51e1d307ded12b0afe185eb5
2021-02-22 22:02:41 +00:00
<p>Note:
</p>
<ul><li>No "mw-parser-output" wrapper div</li>
<li>Funky mw:editsection tags</li></ul>
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
<p><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 19:24, 24 February 2021 (UTC)<span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2021-02-24T19:24:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2021-02-24T19:24:00.000Z"></span>
CommentFormatter: Fix inserting placeholder heading marker This code expected $container->firstChild to be a <div class="mw-parser-output">, but that element is not present when we're running on HTML to be saved in parser cache. We ended up inserting the marker inside whatever node was the first on the page, and if it was a <style> element, both our marker and the styles would be lost when serializing, like in 6c7a0ca9a2c1e40d5de90b88f79ba2646d647f80. When we're running on final HTML, the marker will now be outside of <div class="mw-parser-output">, but that seems to be fine. Only early versions of I4e60fdbc098c1a74757d6e60fec6bcf8e5db37c1 had problems with that (see comments on patchset 41), but it works now. The added test case also covers the fix for T274709. Bug: T275440 Change-Id: I38d45dd8686919be51e1d307ded12b0afe185eb5
2021-02-22 22:02:41 +00:00
</p>
Move visualenhancements metadata and some buttons outside of `<h2>` We wrap a `<div>` tag around the `<h2>`, and move some elements there. The markup is inspired by and compatible with my proposal for T13555. The "ext-discussiontools-init-section" class is moved to the `<div>`. A small patch is needed in MobileFrontend to preserve the section collapsing functionality: I11bff21e81046898ca63f3f432797129fa70ad88. The following elements are now outside of `<h2>`: * Metadata bar * Subscribe button * Ellipsis menu (only shown on mobile) The following elements are sadly still inside of `<h2>`: * Subscribe links (only shown on desktop) * Section edit links from MediaWiki core Trying to move them mucks up the CSS too much. I hope we can resolve this later as a part of the work on T13555. Depends-On: I11bff21e81046898ca63f3f432797129fa70ad88 Bug: T314714 Change-Id: I0bbdcfa02c334858737855349d7a35746de1d8f2
2022-10-18 00:27:35 +00:00
<div class="mw-heading mw-heading2 ext-discussiontools-init-section"><span class='ext-discussiontools-init-section-subscribeButton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-iconElement oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget' data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"icon":"bellOutline","label":"(discussiontools-topicsubscription-button-subscribe-label)","title":"(discussiontools-topicsubscription-button-subscribe-tooltip)","flags":["progressive"],"classes":["ext-discussiontools-init-section-subscribeButton"]}'><a role='button' title='(discussiontools-topicsubscription-button-subscribe-tooltip)' tabindex='0' rel='nofollow' class='oo-ui-buttonElement-button'><span class='oo-ui-iconElement-icon oo-ui-icon-bellOutline oo-ui-image-progressive'></span><span class='oo-ui-labelElement-label'>(discussiontools-topicsubscription-button-subscribe-label)</span><span class='oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive'></span></a></span><h2><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span><span id="Heading_with_a_.22_quote"></span><span class="mw-headline" id="Heading_with_a_&quot;_quote" data-mw-thread-id="h-Heading_with_a_&quot;_quote-2021-02-24T19:24:00.000Z"><span data-mw-comment-start="" id="h-Heading_with_a_&quot;_quote-2021-02-24T19:24:00.000Z"></span>Heading with a " quote<span data-mw-comment-end="h-Heading_with_a_&quot;_quote-2021-02-24T19:24:00.000Z"></span></span><mw:editsection page="Talk:For parser cache" section="1">Heading with a " quote</mw:editsection></h2><div class="ext-discussiontools-init-section-bar"><div class="ext-discussiontools-init-section-metadata"><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-timestampLabel'>(discussiontools-topicheader-latestcomment: <a href="#c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_&quot;_quote">1614194640</a>)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-commentCountLabel'>(discussiontools-topicheader-commentcount: 1)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-authorCountLabel'>(discussiontools-topicheader-authorcount: 1)</span></div><div class="ext-discussiontools-init-section-actions"></div></div></div>
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
<p><span data-mw-comment-start="" id="c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_&quot;_quote"></span>Test. <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 19:24, 24 February 2021 (UTC)<span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_&quot;_quote"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_&quot;_quote"></span>
CommentFormatter: Fix inserting placeholder heading marker This code expected $container->firstChild to be a <div class="mw-parser-output">, but that element is not present when we're running on HTML to be saved in parser cache. We ended up inserting the marker inside whatever node was the first on the page, and if it was a <style> element, both our marker and the styles would be lost when serializing, like in 6c7a0ca9a2c1e40d5de90b88f79ba2646d647f80. When we're running on final HTML, the marker will now be outside of <div class="mw-parser-output">, but that seems to be fine. Only early versions of I4e60fdbc098c1a74757d6e60fec6bcf8e5db37c1 had problems with that (see comments on patchset 41), but it works now. The added test case also covers the fix for T274709. Bug: T275440 Change-Id: I38d45dd8686919be51e1d307ded12b0afe185eb5
2021-02-22 22:02:41 +00:00
</p>
Use setExtensionData() instead of marker comments where possible (3/3) We started using marker comments (HTML comments with special content inserted into the page) for the reply buttons back in the day, because we needed to indicate their location in the HTML. Later we used the same idea for things which aren't actually tied to a specific location in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a better way to do this. This commit stop writing the HTML comments, which are no longer used, and cleans up the tests. Bug: T328980 Change-Id: I37541356830945cc9abcc79d4c445ff6f2449759 (cherry picked from commit ab40ef62c08fe375ea04b254e4df0a28c295544f)
2023-02-07 00:42:00 +00:00
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
<pre>
Use setExtensionData() instead of marker comments where possible (3/3) We started using marker comments (HTML comments with special content inserted into the page) for the reply buttons back in the day, because we needed to indicate their location in the HTML. Later we used the same idea for things which aren't actually tied to a specific location in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a better way to do this. This commit stop writing the HTML comments, which are no longer used, and cleans up the tests. Bug: T328980 Change-Id: I37541356830945cc9abcc79d4c445ff6f2449759 (cherry picked from commit ab40ef62c08fe375ea04b254e4df0a28c295544f)
2023-02-07 00:42:00 +00:00
newestComment: {
"id": "c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_\"_quote",
"timestamp": "2021-02-24T19:24:00.000Z",
"author": "Matma Rex",
"heading": {
"headingLevel": 2,
"name": "h-Matma_Rex-2021-02-24T19:24:00.000Z",
"type": "heading",
"level": 0,
"id": "h-Heading_with_a_\"_quote-2021-02-24T19:24:00.000Z",
"replies": [
"c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_\"_quote"
],
"text": "Heading with a \" quote",
"linkableTitle": "Heading with a \" quote"
}
}
hasLedeContent
hasCommentsInLedeContent
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
{
"wgDiscussionToolsPageThreads": [
{
"headingLevel": null,
"name": "h-Matma_Rex-2021-02-24T19:24:00.000Z",
"type": "heading",
"level": 0,
"id": "h--2021-02-24T19:24:00.000Z",
"replies": [
{
"timestamp": "2021-02-24T19:24:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2021-02-24T19:24:00.000Z",
"replies": []
}
]
},
{
"headingLevel": 2,
"name": "h-Matma_Rex-2021-02-24T19:24:00.000Z",
"type": "heading",
"level": 0,
"id": "h-Heading_with_a_\"_quote-2021-02-24T19:24:00.000Z",
"replies": [
{
"timestamp": "2021-02-24T19:24:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_\"_quote",
"replies": []
}
]
}
]
}
</pre>
Reference in a new issue Copy permalink