wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-17 13:12:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Discus.../tests/cases/ar-nbsp-timezone-parsoid/ar-nbsp-timezone-parsoid.json

1163 lines
27 KiB
JSON
Raw Normal View History

Handle   and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
[
{
"placeholderHeading": true,
"type": "heading",
"range": [
"0",
"0"
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 99,
Handle   and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h||2020-04-21T22:51:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle   and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-21T22:51:00.000Z",
"author": "Johan (WMF)",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/0/0/1/0/0/0/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/0/17/13/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/0/17/6",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/0/17/13/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Johan (WMF)|2020-04-21T22:51:00.000Z",
Stop printing console warnings It was useful when I was debugging those parts of the code, but now it's usually annoying. The warnings can still sometimes be useful for understanding how the tool parses some discussion, though. To keep that functionality, add displaying warnings for each comment in the debug mode. Change-Id: I2d218a8a394f179bcc0990ff988a0567c275ccf2
2020-05-13 18:23:48 +00:00
"warnings": [
"Comment starts and ends with different indentation"
],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
},
{
"type": "comment",
"timestamp": "2020-04-28T17:47:00.000Z",
"author": "Dyolf77 (WMF)",
"range": [
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/0/19/0/0",
"0/0/19/17/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/0/19/10",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/0/19/17/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Dyolf77 (WMF)|2020-04-28T17:47:00.000Z",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/0/0",
"0/1/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 3,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Allow headings to have IDs Previously, only comments could have IDs, because we only needed IDs for replying. But we might also use them for notifications soon. Bug: T264478 Change-Id: I1bcad02bf17ab54bc5028a959543c10f0430836b
2020-09-22 23:05:25 +00:00
"id": "h|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/4/0/0",
"0/1/4/0/2"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|الحبيب|التعليقات|2020-04-29T14:08:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-29T14:08:00.000Z",
"author": "Dyolf77",
"range": [
"0/1/4/2/0",
"0/1/4/2/6/2"
],
"signatureRanges": [
[
"0/1/4/2/1",
"0/1/4/2/6/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Dyolf77|2020-04-29T14:08:00.000Z|الحبيب",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/5/0/0",
"0/1/5/0/1"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|Trabelsiismail|التعليقات|2020-04-29T17:40:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-29T17:40:00.000Z",
"author": "Trabelsiismail",
"range": [
"0/1/5/2/0",
"0/1/5/2/8/2"
],
"signatureRanges": [
[
"0/1/5/2/1",
"0/1/5/2/8/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Trabelsiismail|2020-04-29T17:40:00.000Z|Trabelsiismail",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/6/0/0",
"0/1/6/0/2"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|عادل|التعليقات|2020-04-29T22:55:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-29T22:55:00.000Z",
"author": "Nehaoua",
"range": [
"0/1/6/2/0",
"0/1/6/2/14/2"
],
"signatureRanges": [
[
"0/1/6/2/7",
"0/1/6/2/14/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Nehaoua|2020-04-29T22:55:00.000Z|عادل",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/7/0/0",
"0/1/7/0/2"
],
"headingLevel": 4,
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|مستخدم:Aboody09876544|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/8/0/0",
"0/1/8/0/1"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|Aws_Al-mimari|التعليقات|2020-04-30T11:58:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-30T11:58:00.000Z",
"author": "Aws Al-mimari",
"range": [
"0/1/8/2/2",
"0/1/8/2/10/2"
],
"signatureRanges": [
[
"0/1/8/2/3",
"0/1/8/2/10/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Aws Al-mimari|2020-04-30T11:58:00.000Z|Aws_Al-mimari",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/9/0/0",
"0/1/9/0/2"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|حسن_سلمان_الحسن|التعليقات|2020-04-30T14:00:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-30T14:00:00.000Z",
"author": "حسن سلمان الحسن",
"range": [
"0/1/9/2/0",
"0/1/9/2/8/2"
],
"signatureRanges": [
[
"0/1/9/2/1",
"0/1/9/2/8/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|حسن سلمان الحسن|2020-04-30T14:00:00.000Z|حسن_سلمان_الحسن",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/10/0/0",
"0/1/10/0/2"
],
"headingLevel": 4,
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|سميح_حسن_خلف|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/11/0/0",
"0/1/11/0/2"
],
"headingLevel": 4,
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|معتز_وزة_المكتشف|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/12/0/0",
"0/1/12/0/2"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|السيد_طه|التعليقات|2020-04-30T17:35:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-30T17:35:00.000Z",
"author": "Elsayed Taha",
"range": [
"0/1/12/2/0",
"0/1/12/2/8/2"
],
"signatureRanges": [
[
"0/1/12/2/1",
"0/1/12/2/8/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Elsayed Taha|2020-04-30T17:35:00.000Z|السيد_طه",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/13/0/0",
"0/1/13/0/2"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|أبو_تائب|التعليقات|2020-04-30T17:46:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-30T17:46:00.000Z",
"author": "أبو تائب",
"range": [
"0/1/13/2/0",
"0/1/13/2/7/2"
],
"signatureRanges": [
[
"0/1/13/2/1",
"0/1/13/2/7/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|أبو تائب|2020-04-30T17:46:00.000Z|أبو_تائب",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/14/0/0",
"0/1/14/0/2"
],
"headingLevel": 4,
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|أميمة_ابو_العطا|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/15/0/0",
"0/1/15/0/2"
],
"headingLevel": 4,
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|ريمي_العثماني|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/16/0/0",
"0/1/16/0/2"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|سيف_القوضي|التعليقات|2020-04-30T23:49:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-30T23:49:00.000Z",
"author": "Saif Oofa7",
"range": [
"0/1/16/2/0",
"0/1/16/4/8/2"
],
"signatureRanges": [
[
"0/1/16/4/1",
"0/1/16/4/8/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Saif Oofa7|2020-04-30T23:49:00.000Z|سيف_القوضي",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/17/0/0",
"0/1/17/0/1"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|Mohanad_Kh|التعليقات|2020-05-01T12:00:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-05-01T12:00:00.000Z",
"author": "Mohanad Kh",
"range": [
"0/1/17/2/0",
"0/1/17/6/8/2"
],
"signatureRanges": [
[
"0/1/17/6/1",
"0/1/17/6/8/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Mohanad Kh|2020-05-01T12:00:00.000Z|Mohanad_Kh",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/18/0/0",
"0/1/18/0/2"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|أبو_هشام|التعليقات|2020-05-01T21:30:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-05-01T21:30:00.000Z",
"author": "أبو هشام",
"range": [
"0/1/18/2/0",
"0/1/18/2/8/2"
],
"signatureRanges": [
[
"0/1/18/2/1",
"0/1/18/2/8/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|أبو هشام|2020-05-01T21:30:00.000Z|أبو_هشام",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/19/0/0",
"0/1/19/0/2"
],
"headingLevel": 4,
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|جمال|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/20/0/0",
"0/1/20/0/2"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|محمد_بوعلام_عصامي|التعليقات|2020-05-02T03:01:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-05-02T03:01:00.000Z",
"author": "محمد بوعلام عصامي",
"range": [
"0/1/20/2/0",
"0/1/20/2/14/2"
],
"signatureRanges": [
[
"0/1/20/2/7",
"0/1/20/2/14/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|محمد بوعلام عصامي|2020-05-02T03:01:00.000Z|محمد_بوعلام_عصامي",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/21/0/0",
"0/1/21/0/1"
],
"headingLevel": 4,
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|Med_Aly_2002|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/22/0/0",
"0/1/22/0/2"
],
"headingLevel": 4,
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|جميل|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/23/0/0",
"0/1/23/0/2"
],
"headingLevel": 4,
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|اقتراح_هام|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/24/0/0",
"0/1/24/0/1"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|Justwiki|التعليقات|2020-05-04T17:56:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-05-04T17:56:00.000Z",
"author": "Justwiki",
"range": [
"0/1/24/2/0",
"0/1/24/2/8/2"
],
"signatureRanges": [
[
"0/1/24/2/1",
"0/1/24/2/8/2"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Justwiki|2020-05-04T17:56:00.000Z|Justwiki",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"type": "heading",
"range": [
"0/1/25/0/0",
"0/1/25/0/1"
],
"headingLevel": 4,
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|Abu_aamir|التعليقات|2020-05-05T09:36:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-05-05T09:36:00.000Z",
"author": "Abu aamir",
"range": [
"0/1/25/2/0",
"0/1/25/2/8/28"
],
"signatureRanges": [
[
"0/1/25/2/5",
"0/1/25/2/8/28"
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Abu aamir|2020-05-05T09:36:00.000Z|Abu_aamir",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"replies": []
}
]
}
]
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/4/0/0",
"0/1/4/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|الحبيب|التعليقات|2020-04-29T14:08:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-29T14:08:00.000Z",
"author": "Dyolf77",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/4/2/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/4/2/6/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/4/2/1",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/4/2/6/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Dyolf77|2020-04-29T14:08:00.000Z|الحبيب",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/5/0/0",
"0/1/5/0/1"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|Trabelsiismail|التعليقات|2020-04-29T17:40:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-29T17:40:00.000Z",
"author": "Trabelsiismail",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/5/2/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/5/2/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/5/2/1",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/5/2/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Trabelsiismail|2020-04-29T17:40:00.000Z|Trabelsiismail",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/6/0/0",
"0/1/6/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|عادل|التعليقات|2020-04-29T22:55:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-29T22:55:00.000Z",
"author": "Nehaoua",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/6/2/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/6/2/14/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/6/2/7",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/6/2/14/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Nehaoua|2020-04-29T22:55:00.000Z|عادل",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/7/0/0",
"0/1/7/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|مستخدم:Aboody09876544|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/8/0/0",
"0/1/8/0/1"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|Aws_Al-mimari|التعليقات|2020-04-30T11:58:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-30T11:58:00.000Z",
"author": "Aws Al-mimari",
"range": [
Ignore empty paragraphs at the beginning of comments The wikitext parser outputs `<p><br></p>` for empty paragraphs, so we need to ignore `<br>` tags when searching for an "interesting" node that marks the beginning of a comment. Otherwise the empty paragraphs mess up the detection of indentation levels. Bug: T264116 Change-Id: I84a97ab577baa7336b78935ccdc48041ecfc231a
2020-09-29 20:05:58 +00:00
"0/1/8/2/2",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/8/2/10/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/8/2/3",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/8/2/10/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Aws Al-mimari|2020-04-30T11:58:00.000Z|Aws_Al-mimari",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/9/0/0",
"0/1/9/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|حسن_سلمان_الحسن|التعليقات|2020-04-30T14:00:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-30T14:00:00.000Z",
"author": "حسن سلمان الحسن",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/9/2/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/9/2/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/9/2/1",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/9/2/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|حسن سلمان الحسن|2020-04-30T14:00:00.000Z|حسن_سلمان_الحسن",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/10/0/0",
"0/1/10/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|سميح_حسن_خلف|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/11/0/0",
"0/1/11/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|معتز_وزة_المكتشف|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/12/0/0",
"0/1/12/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|السيد_طه|التعليقات|2020-04-30T17:35:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-30T17:35:00.000Z",
"author": "Elsayed Taha",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/12/2/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/12/2/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/12/2/1",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/12/2/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Elsayed Taha|2020-04-30T17:35:00.000Z|السيد_طه",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/13/0/0",
"0/1/13/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|أبو_تائب|التعليقات|2020-04-30T17:46:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-30T17:46:00.000Z",
"author": "أبو تائب",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/13/2/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/13/2/7/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/13/2/1",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/13/2/7/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|أبو تائب|2020-04-30T17:46:00.000Z|أبو_تائب",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/14/0/0",
"0/1/14/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|أميمة_ابو_العطا|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/15/0/0",
"0/1/15/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|ريمي_العثماني|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/16/0/0",
"0/1/16/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|سيف_القوضي|التعليقات|2020-04-30T23:49:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-04-30T23:49:00.000Z",
"author": "Saif Oofa7",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/16/2/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/16/4/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/16/4/1",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/16/4/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Saif Oofa7|2020-04-30T23:49:00.000Z|سيف_القوضي",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/17/0/0",
"0/1/17/0/1"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|Mohanad_Kh|التعليقات|2020-05-01T12:00:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-05-01T12:00:00.000Z",
"author": "Mohanad Kh",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/17/2/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/17/6/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/17/6/1",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/17/6/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Mohanad Kh|2020-05-01T12:00:00.000Z|Mohanad_Kh",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/18/0/0",
"0/1/18/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|أبو_هشام|التعليقات|2020-05-01T21:30:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-05-01T21:30:00.000Z",
"author": "أبو هشام",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/18/2/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/18/2/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/18/2/1",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/18/2/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|أبو هشام|2020-05-01T21:30:00.000Z|أبو_هشام",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/19/0/0",
"0/1/19/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|جمال|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/20/0/0",
"0/1/20/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|محمد_بوعلام_عصامي|التعليقات|2020-05-02T03:01:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-05-02T03:01:00.000Z",
"author": "محمد بوعلام عصامي",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/20/2/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/20/2/14/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/20/2/7",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/20/2/14/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|محمد بوعلام عصامي|2020-05-02T03:01:00.000Z|محمد_بوعلام_عصامي",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/21/0/0",
"0/1/21/0/1"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|Med_Aly_2002|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/22/0/0",
"0/1/22/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|جميل|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/23/0/0",
"0/1/23/0/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "h|اقتراح_هام|التعليقات",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/24/0/0",
"0/1/24/0/1"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|Justwiki|التعليقات|2020-05-04T17:56:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-05-04T17:56:00.000Z",
"author": "Justwiki",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/24/2/0",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/24/2/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/24/2/1",
parser: Fix comment ranges when timestamp has entities Previously, parser would output offsets that don't exist in their containers, because we were pretending that entities are parts of their neighboring text nodes. Turns out it's much easier to do it right when going backwards. Change-Id: I9bccca2d403f1a976ae517449989170cdd99721e
2020-08-11 04:22:57 +00:00
"0/1/24/2/8/2"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Justwiki|2020-05-04T17:56:00.000Z|Justwiki",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
},
{
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"placeholderHeading": false,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"type": "heading",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/25/0/0",
"0/1/25/0/1"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
Connect sub-threads to their parent threads Our threads now also contain all replies to their sub-threads. This is similar to how sections work in MediaWiki, where the parent section also contains the content of all the lower-level sections. We're going to need this for notifications about replies in a thread. Bug: T264478 Change-Id: I241fc58e2088a7555942824b0f184ed21e3a8b6f
2020-10-01 19:36:11 +00:00
"headingLevel": 4,
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"level": 0,
Add oldest timestamp in the thread to heading IDs To avoid old threads re-appearing on popular pages when someone uses a vague title (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN), include the oldest timestamp in the thread (i.e. date the thread was started) in the heading ID. Bug: T264478 Change-Id: If918bfd5e025248923d1939bc86916697ead95a0
2020-10-07 15:48:20 +00:00
"id": "h|Abu_aamir|التعليقات|2020-05-05T09:36:00.000Z",
Move warnings stuff from CommentItem to ThreadItem After recent changes allowing ThreadItems to have IDs, they can now also have warnings about duplicate IDs. Bug: T267035 Change-Id: If3edfe34e6e29741e29fac8946a3c88badc4ab7f
2020-11-02 18:35:38 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": [
{
"type": "comment",
"timestamp": "2020-05-05T09:36:00.000Z",
"author": "Abu aamir",
"range": [
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/25/2/0",
"0/1/25/2/8/28"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
],
"signatureRanges": [
[
tests: Fix computing ranges in Parsoid documents In JS tests, we load the documents via mw.template, which apparently causes the <html>, <head> and <body> tags to disappear, resulting in the ranges not matching in PHP tests (and the real document). Put in a big hack that makes them match, and update the JSON files. Change-Id: I8194752cd5f82c3716c99e76a37226af5d4a0ec1
2020-05-13 20:19:43 +00:00
"0/1/25/2/5",
"0/1/25/2/8/28"
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
]
],
"level": 1,
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
"id": "c|Abu aamir|2020-05-05T09:36:00.000Z|Abu_aamir",
Fix some TODOs about test data We avoided fixing these because it causes changes in just about all of the test data, which is annoying when reviewing or blaming changes. But the previous several commits also caused changes in just about all of the test data, so we might as well do this too. Change-Id: I83b64d83b6f12c04dc06c0cadff7cdd89417e137
2020-10-07 14:45:19 +00:00
"warnings": [],
Handle &nbsp; and other entities in the timestamp/timezone Bug: T251838 Change-Id: Iba8d7c71e332c63229eec4bc7c80b10627135784
2020-05-05 20:19:04 +00:00
"replies": []
}
]
}
]
Reference in a new issue Copy permalink