wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-17 05:10:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Discus.../tests/cases/signatures-funny/signatures-funny-reply.html

28 lines
6.2 KiB
HTML
Raw Normal View History

Add reply links at the end of a line, even if the signature is in the middle Previously they were added at the end of the text node containing the timestamp, which was usually the end of the line, but not always. And also fix the same problem for inserting the actual replies (or reply widgets). This replaces an undocumented hack that prevented our own reply links from triggering this bug (without it, the reply widget would be inserted before the reply link rather than after). While we're here, remove unintentional spacing that appeared before some reply links, caused by trailing whitespace in text nodes. Add tests for all of the above. Bug: T245695 Change-Id: I354b63e2446bb996176a2e3d76abf944127f307e
2020-03-02 18:50:36 +00:00
<h2><span class="mw-headline" id="multi_signatures">multi signatures</span><span class="mw-editsection"><span class="mw-editsection-bracket">[</span><a href="/w/index.php?title=Talk:Scratch&amp;action=edit&amp;section=5" title="Edit section: multi signatures">edit source</a><span class="mw-editsection-bracket">]</span></span></h2>
More test cases for multiple signatures in funny places Expand the 'signatures-funny' test case with more examples, which don't behave correctly. Follow-up commits I04a8ea09401e06f2d4bb1f226f17eb528b29ed95 and Ic26a87642f8a15d5de2f7073d4d8176b299c7f94 fix them. Bug: T255738 Change-Id: I0fdd8bdf11b497ffeed37c37953c5730f6e4f3b7
2020-08-11 04:09:18 +00:00
<p>aaa <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:31, 25 January 2020 (UTC) amended! <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:41, 25 January 2020 (UTC)<a href="#">Reply</a>
Add reply links at the end of a line, even if the signature is in the middle Previously they were added at the end of the text node containing the timestamp, which was usually the end of the line, but not always. And also fix the same problem for inserting the actual replies (or reply widgets). This replaces an undocumented hack that prevented our own reply links from triggering this bug (without it, the reply widget would be inserted before the reply link rather than after). While we're here, remove unintentional spacing that appeared before some reply links, caused by trailing whitespace in text nodes. Add tests for all of the above. Bug: T245695 Change-Id: I354b63e2446bb996176a2e3d76abf944127f307e
2020-03-02 18:50:36 +00:00
</p>
More test cases for multiple signatures in funny places Expand the 'signatures-funny' test case with more examples, which don't behave correctly. Follow-up commits I04a8ea09401e06f2d4bb1f226f17eb528b29ed95 and Ic26a87642f8a15d5de2f7073d4d8176b299c7f94 fix them. Bug: T255738 Change-Id: I0fdd8bdf11b497ffeed37c37953c5730f6e4f3b7
2020-08-11 04:09:18 +00:00
<ul><li>bbb <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:32, 25 January 2020 (UTC)<a href="#">Reply</a>
<ul><li>ccc <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:33, 25 January 2020 (UTC) amended! <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:43, 25 January 2020 (UTC)<a href="#">Reply</a></li></ul></li></ul>
<p>multi-line top level <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:34, 25 January 2020 (UTC)<a href="#">Reply</a>
</p><p>ddd <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:34, 25 January 2020 (UTC)<a href="#">Reply</a>
Add reply links at the end of a line, even if the signature is in the middle Previously they were added at the end of the text node containing the timestamp, which was usually the end of the line, but not always. And also fix the same problem for inserting the actual replies (or reply widgets). This replaces an undocumented hack that prevented our own reply links from triggering this bug (without it, the reply widget would be inserted before the reply link rather than after). While we're here, remove unintentional spacing that appeared before some reply links, caused by trailing whitespace in text nodes. Add tests for all of the above. Bug: T245695 Change-Id: I354b63e2446bb996176a2e3d76abf944127f307e
2020-03-02 18:50:36 +00:00
</p>
More test cases for multiple signatures in funny places Expand the 'signatures-funny' test case with more examples, which don't behave correctly. Follow-up commits I04a8ea09401e06f2d4bb1f226f17eb528b29ed95 and Ic26a87642f8a15d5de2f7073d4d8176b299c7f94 fix them. Bug: T255738 Change-Id: I0fdd8bdf11b497ffeed37c37953c5730f6e4f3b7
2020-08-11 04:09:18 +00:00
<ul><li>eee <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:35, 25 January 2020 (UTC) amended! <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:45, 25 January 2020 (UTC)<a href="#">Reply</a></li>
<li>fff <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:36, 25 January 2020 (UTC) also!<a href="#">Reply</a></li>
<li>fff <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:37, 25 January 2020 (UTC) and <i>also</i>!<a href="#">Reply</a>
<ul><li>multi-line reply <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:38, 25 January 2020 (UTC)<a href="#">Reply</a></li>
<li>ggg <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:38, 25 January 2020 (UTC)<a href="#">Reply</a></li></ul></li></ul>
Don't detect comments within headings Bug: T267068 Change-Id: Id134f15e086fd070801c4b1d836dbfbf9bf444ad
2020-11-04 15:17:39 +00:00
<h2><span id="hello_Matma_Rex_.28talk.29_18:27.2C_2_November_2020_.28UTC.29"></span><span class="mw-headline" id="hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)">hello <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:27, 2 November 2020 (UTC)</span><span class="mw-editsection"><span class="mw-editsection-bracket">[</span><a href="/w/index.php?title=Talk:Signature_in_heading&amp;action=edit&amp;section=1" title="Edit section: hello Matma Rex (talk) 18:27, 2 November 2020 (UTC)">edit source</a><span class="mw-editsection-bracket">]</span></span></h2>
<p>hello <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:28, 2 November 2020 (UTC)<a href="#">Reply</a>
</p>
Fix start node for comments following headings The general rule is that comments start after their preceding thread item, but when that is a heading we should skip past the entire <h[1-6]> node to avoid making section edit links part of the first comment. Bug: T267988 Change-Id: Ia7f1b27e0a69a9aab7c7da743bf8549479304096
2020-11-16 00:35:51 +00:00
Skip end marker "forward" until a block tag is reached The end marker is skipped forward until an open or close block tag is reached. In tree traversal terms this means moving either to the next sibling, or the parent (to skip over close tags). Bug: T256033 Change-Id: Iaa2c588698790d576ac4f9ecc126f58a082ef6b3
2020-11-16 19:14:46 +00:00
<p>Wrapped signature. <small><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:29, 2 November 2020 (UTC)</small><a href="#">Reply</a></p>
<p>Double wrapped signature. <sup><small><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:30, 2 November 2020 (UTC)</small></sup><a href="#">Reply</a></p>
<p>Double wrapped signature with inner trailing text. <sup><small><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:31, 2 November 2020 (UTC)</small>text</sup><a href="#">Reply</a></p>
<p>Double wrapped signature with outer trailing text. <sup><small><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:32, 2 November 2020 (UTC)</small></sup>text<a href="#">Reply</a></p>
<p>Trailing tags. <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:33, 2 November 2020 (UTC)<span>foo</span><a href="#">Reply</a></p>
Add test case for trailing void tags (<br>) Bug: T266288 Change-Id: I9385a5b6804fa199327f7af2cfd8275f30727f66
2020-12-08 22:46:11 +00:00
<p>Trailing void tags (br). <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:33, 2 November 2020 (UTC)<br/><a href="#">Reply</a></p>
Skip end marker "forward" until a block tag is reached The end marker is skipped forward until an open or close block tag is reached. In tree traversal terms this means moving either to the next sibling, or the parent (to skip over close tags). Bug: T256033 Change-Id: Iaa2c588698790d576ac4f9ecc126f58a082ef6b3
2020-11-16 19:14:46 +00:00
Fix start node for comments following headings The general rule is that comments start after their preceding thread item, but when that is a heading we should skip past the entire <h[1-6]> node to avoid making section edit links part of the first comment. Bug: T267988 Change-Id: Ia7f1b27e0a69a9aab7c7da743bf8549479304096
2020-11-16 00:35:51 +00:00
<h2><span class="mw-headline" id="Transcluded"><span class="mw-headline-number">1</span> Numbered heading with edit section links</span><span class="mw-editsection"><span class="mw-editsection-bracket">[</span><a href="#" title="Edit section: ">edit source</a><span class="mw-editsection-bracket">]</span></span></h2>
Skip end marker "forward" until a block tag is reached The end marker is skipped forward until an open or close block tag is reached. In tree traversal terms this means moving either to the next sibling, or the parent (to skip over close tags). Bug: T256033 Change-Id: Iaa2c588698790d576ac4f9ecc126f58a082ef6b3
2020-11-16 19:14:46 +00:00
<p>comment <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:34, 2 November 2020 (UTC)<a href="#">Reply</a></p>
Reference in a new issue Copy permalink