mediawiki-extensions-Discus.../tests/cases/for-parser-cache/for-parser-cache-formattedreply.html

<span data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h--2021-02-24T19:24:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2021-02-24T19:24:00.000Z&quot;],&quot;headingLevel&quot;:99,&quot;placeholderHeading&quot;:true}"><span data-mw-comment-start="" id="h--2021-02-24T19:24:00.000Z"></span><span data-mw-comment-end="h--2021-02-24T19:24:00.000Z"></span></span><span data-mw-comment-start="" id="c-Matma_Rex-2021-02-24T19:24:00.000Z"></span><style data-mw-deduplicate="TemplateStyles:r3303">.mw-parser-output .color-purple{color:purple}</style><div class="color-purple">This page demonstrates some quirks of raw HTML generated in ParserOutput, which gets saved to the parser cache and which we operate on in the ParserAfterTidy hook. Most other test cases are using the final HTML returned by ParserOutput::getText(), which we operate on in the OutputPageBeforeHTML hook.</div>
<p>Note:
</p>
<ul><li>No "mw-parser-output" wrapper div</li>
<li>Funky mw:editsection tags</li></ul>
<p><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 19:24, 24 February 2021 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2021-02-24T19:24:00.000Z&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2021-02-24T19:24:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2021-02-24T19:24:00.000Z"></span>
</p>
<h2 class="ext-discussiontools-init-section"><span id="Heading_with_a_.22_quote"></span><span class="mw-headline" id="Heading_with_a_&quot;_quote" data-mw-comment="{&quot;type&quot;:&quot;heading&quot;,&quot;level&quot;:0,&quot;id&quot;:&quot;h-Heading_with_a_\&quot;_quote-2021-02-24T19:24:00.000Z&quot;,&quot;replies&quot;:[&quot;c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_\&quot;_quote&quot;],&quot;headingLevel&quot;:2,&quot;placeholderHeading&quot;:false}"><span data-mw-comment-start="" id="h-Heading_with_a_&quot;_quote-2021-02-24T19:24:00.000Z"></span>Heading with a " quote<span data-mw-comment-end="h-Heading_with_a_&quot;_quote-2021-02-24T19:24:00.000Z"></span></span><mw:editsection page="Talk:For parser cache" section="1">Heading with a " quote</mw:editsection><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" data-mw-comment-name="h-Matma_Rex-2021-02-24T19:24:00.000Z" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
<p><span data-mw-comment-start="" id="c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_&quot;_quote"></span>Test. <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 19:24, 24 February 2021 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{&quot;type&quot;:&quot;comment&quot;,&quot;level&quot;:1,&quot;id&quot;:&quot;c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_\&quot;_quote&quot;,&quot;replies&quot;:[],&quot;timestamp&quot;:&quot;2021-02-24T19:24:00.000Z&quot;,&quot;author&quot;:&quot;Matma Rex&quot;}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_&quot;_quote"></span>
</p>
Fix inserting comment start markers when they're outside of any wrappers Comment boundaries are stored as a DOM parent node plus a child index. Because of that, inserting anything into the DOM before a comment – such as another comment's start/end markers – would cause us to insert subsequent comments' markers into the wrong places. This issue didn't affect many pages, because usually any parent node would have just one comment in it. Only pages with comment boundaries outside of any wrappers (directly inside the root node) were broken. Just process the list in reverse to fix this. Bug: T298096 Change-Id: Iccffc36b71e9fcf3d72c4db2b9459d39042f7a2d 2021-12-21 14:20:18 +00:00			<span data-mw-comment="{"type":"heading","level":0,"id":"h--2021-02-24T19:24:00.000Z","replies":["c-Matma_Rex-2021-02-24T19:24:00.000Z"],"headingLevel":99,"placeholderHeading":true}"><span data-mw-comment-start="" id="h--2021-02-24T19:24:00.000Z"></span><span data-mw-comment-end="h--2021-02-24T19:24:00.000Z"></span></span><span data-mw-comment-start="" id="c-Matma_Rex-2021-02-24T19:24:00.000Z"></span><style data-mw-deduplicate="TemplateStyles:r3303">.mw-parser-output .color-purple{color:purple}</style><div class="color-purple">This page demonstrates some quirks of raw HTML generated in ParserOutput, which gets saved to the parser cache and which we operate on in the ParserAfterTidy hook. Most other test cases are using the final HTML returned by ParserOutput::getText(), which we operate on in the OutputPageBeforeHTML hook.</div>
CommentFormatter: Fix inserting placeholder heading marker This code expected $container->firstChild to be a <div class="mw-parser-output">, but that element is not present when we're running on HTML to be saved in parser cache. We ended up inserting the marker inside whatever node was the first on the page, and if it was a <style> element, both our marker and the styles would be lost when serializing, like in 6c7a0ca9a2c1e40d5de90b88f79ba2646d647f80. When we're running on final HTML, the marker will now be outside of <div class="mw-parser-output">, but that seems to be fine. Only early versions of I4e60fdbc098c1a74757d6e60fec6bcf8e5db37c1 had problems with that (see comments on patchset 41), but it works now. The added test case also covers the fix for T274709. Bug: T275440 Change-Id: I38d45dd8686919be51e1d307ded12b0afe185eb5 2021-02-22 22:02:41 +00:00			`<p>Note:`
			`</p>`
			`<ul><li>No "mw-parser-output" wrapper div</li>`
			`<li>Funky mw:editsection tags</li></ul>`
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4 2021-06-02 19:42:45 +00:00			<p><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 19:24, 24 February 2021 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{"type":"comment","level":1,"id":"c-Matma_Rex-2021-02-24T19:24:00.000Z","replies":[],"timestamp":"2021-02-24T19:24:00.000Z","author":"Matma Rex"}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2021-02-24T19:24:00.000Z"></span>
CommentFormatter: Fix inserting placeholder heading marker This code expected $container->firstChild to be a <div class="mw-parser-output">, but that element is not present when we're running on HTML to be saved in parser cache. We ended up inserting the marker inside whatever node was the first on the page, and if it was a <style> element, both our marker and the styles would be lost when serializing, like in 6c7a0ca9a2c1e40d5de90b88f79ba2646d647f80. When we're running on final HTML, the marker will now be outside of <div class="mw-parser-output">, but that seems to be fine. Only early versions of I4e60fdbc098c1a74757d6e60fec6bcf8e5db37c1 had problems with that (see comments on patchset 41), but it works now. The added test case also covers the fix for T274709. Bug: T275440 Change-Id: I38d45dd8686919be51e1d307ded12b0afe185eb5 2021-02-22 22:02:41 +00:00			`</p>`
Use placeholder localisation messages in CommentFormatter tests Otherwise they will fail whenever translations are updated (and they are failing right now). Change-Id: I849c57b86d36fb6c7739cc31a74df741e08462f4 2021-06-02 19:42:45 +00:00			<h2 class="ext-discussiontools-init-section"><span id="Heading_with_a_.22_quote"></span><span class="mw-headline" id="Heading_with_a_"_quote" data-mw-comment="{"type":"heading","level":0,"id":"h-Heading_with_a_\"_quote-2021-02-24T19:24:00.000Z","replies":["c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_\"_quote"],"headingLevel":2,"placeholderHeading":false}"><span data-mw-comment-start="" id="h-Heading_with_a_"_quote-2021-02-24T19:24:00.000Z"></span>Heading with a " quote<span data-mw-comment-end="h-Heading_with_a_"_quote-2021-02-24T19:24:00.000Z"></span></span><mw:editsection page="Talk:For parser cache" section="1">Heading with a " quote</mw:editsection><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" data-mw-comment-name="h-Matma_Rex-2021-02-24T19:24:00.000Z" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span></h2>
			<p><span data-mw-comment-start="" id="c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_"_quote"></span>Test. <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 19:24, 24 February 2021 (UTC)<span class="ext-discussiontools-init-replylink-buttons"><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" data-mw-comment="{"type":"comment","level":1,"id":"c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_\"_quote","replies":[],"timestamp":"2021-02-24T19:24:00.000Z","author":"Matma Rex"}" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2021-02-24T19:24:00.000Z-Heading_with_a_"_quote"></span>
CommentFormatter: Fix inserting placeholder heading marker This code expected $container->firstChild to be a <div class="mw-parser-output">, but that element is not present when we're running on HTML to be saved in parser cache. We ended up inserting the marker inside whatever node was the first on the page, and if it was a <style> element, both our marker and the styles would be lost when serializing, like in 6c7a0ca9a2c1e40d5de90b88f79ba2646d647f80. When we're running on final HTML, the marker will now be outside of <div class="mw-parser-output">, but that seems to be fine. Only early versions of I4e60fdbc098c1a74757d6e60fec6bcf8e5db37c1 had problems with that (see comments on patchset 41), but it works now. The added test case also covers the fix for T274709. Bug: T275440 Change-Id: I38d45dd8686919be51e1d307ded12b0afe185eb5 2021-02-22 22:02:41 +00:00			`</p>`