wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-30 19:16:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Discus.../tests/cases/signatures-funny/signatures-funny-formatted-desktop.html

260 lines
54 KiB
HTML
Raw Normal View History

Support topic subscriptions when JavaScript is disabled Unsubscribing was already available from Special:TopicSubscriptions when JavaScript is disabled. * Add links to subscribe/unsubscribe in CommentFormatter * Update links in skin navigation * Add support for subscribing in the actions Bug: T321431 Change-Id: If3c4bf7df309d0d98237c3b7b9c129cc2f72cda3
2022-12-08 16:15:02 +00:00
<div class="mw-heading mw-heading2 ext-discussiontools-init-section"><span class='ext-discussiontools-init-section-subscribeButton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-iconElement oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget' data-ooui='{"_":"OO.ui.ButtonWidget","href":"\/w\/index.php?title=Talk:Signatures_funny&amp;action=dtsubscribe&amp;commentname=h-Matma_Rex-2020-01-25T08%3A31%3A00.000Z&amp;section=multi+signatures","rel":["nofollow"],"framed":false,"icon":"bellOutline","label":"(discussiontools-topicsubscription-button-subscribe-label)","title":"(discussiontools-topicsubscription-button-subscribe-tooltip)","flags":["progressive"],"classes":["ext-discussiontools-init-section-subscribeButton"]}'><a role='button' title='(discussiontools-topicsubscription-button-subscribe-tooltip)' tabindex='0' href='/w/index.php?title=Talk:Signatures_funny&amp;action=dtsubscribe&amp;commentname=h-Matma_Rex-2020-01-25T08%3A31%3A00.000Z&amp;section=multi+signatures' rel='nofollow' class='oo-ui-buttonElement-button'><span class='oo-ui-iconElement-icon oo-ui-icon-bellOutline oo-ui-image-progressive'></span><span class='oo-ui-labelElement-label'>(discussiontools-topicsubscription-button-subscribe-label)</span><span class='oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive'></span></a></span><h2><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="/w/index.php?title=Talk:Signatures_funny&amp;action=dtsubscribe&amp;commentname=h-Matma_Rex-2020-01-25T08%3A31%3A00.000Z&amp;section=multi+signatures" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span><span class="mw-headline" id="multi_signatures" data-mw-thread-id="h-multi_signatures-2020-01-25T08:31:00.000Z"><span data-mw-comment-start="" id="h-multi_signatures-2020-01-25T08:31:00.000Z"></span>multi signatures<span data-mw-comment-end="h-multi_signatures-2020-01-25T08:31:00.000Z"></span></span><span class="mw-editsection"><span class="mw-editsection-bracket">[</span><a href="/w/index.php?title=Talk:Scratch&amp;action=edit&amp;section=5" title="Edit section: multi signatures">edit source</a><span class="mw-editsection-bracket">]</span></span></h2><div class="ext-discussiontools-init-section-bar"><div class="ext-discussiontools-init-section-metadata"><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-timestampLabel'>(discussiontools-topicheader-latestcomment: <a href="#c-Matma_Rex-2020-01-25T08:38:00.000Z-Matma_Rex-2020-01-25T08:37:00.000Z">1579941480</a>)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-commentCountLabel'>(discussiontools-topicheader-commentcount: 10)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-authorCountLabel'>(discussiontools-topicheader-authorcount: 1)</span></div><div class="ext-discussiontools-init-section-actions"></div></div></div>
Turn comment timestamps into permalinks Bug: T275729 Change-Id: Ica9cfd9743a67fce170e8b078016fa79bf6fbb84
2022-07-30 22:02:17 +00:00
<p><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-25T08:31:00.000Z-multi_signatures"></span>aaa <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:31, 25 January 2020 (UTC) amended! <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-01-25T08:31:00.000Z-multi_signatures" class="ext-discussiontools-init-timestamplink">08:41, 25 January 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-01-25T08:31:00.000Z-multi_signatures"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-25T08:31:00.000Z-multi_signatures"></span>
Add tests for CommentFormatter I haven't really reviewed the outputs, but at least a) they don't crash b) they will fail if the output suddenly changes (which could cause problems due to caching). Bug: T252555 Change-Id: I1bbcbc5dd17ce1e24b3622062f5e8df4baf5f389
2020-10-19 20:59:55 +00:00
</p>
Turn comment timestamps into permalinks Bug: T275729 Change-Id: Ica9cfd9743a67fce170e8b078016fa79bf6fbb84
2022-07-30 22:02:17 +00:00
<ul><li><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-25T08:32:00.000Z-Matma_Rex-2020-01-25T08:31:00.000Z"></span>bbb <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-01-25T08:32:00.000Z-Matma_Rex-2020-01-25T08:31:00.000Z" class="ext-discussiontools-init-timestamplink">08:32, 25 January 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-01-25T08:32:00.000Z-Matma_Rex-2020-01-25T08:31:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-25T08:32:00.000Z-Matma_Rex-2020-01-25T08:31:00.000Z"></span>
<ul><li><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-25T08:33:00.000Z-Matma_Rex-2020-01-25T08:32:00.000Z"></span>ccc <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:33, 25 January 2020 (UTC) amended! <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-01-25T08:33:00.000Z-Matma_Rex-2020-01-25T08:32:00.000Z" class="ext-discussiontools-init-timestamplink">08:43, 25 January 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-01-25T08:33:00.000Z-Matma_Rex-2020-01-25T08:32:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-25T08:33:00.000Z-Matma_Rex-2020-01-25T08:32:00.000Z"></span></li></ul></li></ul>
<p><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-25T08:34:00.000Z-multi_signatures"></span>multi-line top level <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-01-25T08:34:00.000Z-multi_signatures" class="ext-discussiontools-init-timestamplink">08:34, 25 January 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-01-25T08:34:00.000Z-multi_signatures"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-25T08:34:00.000Z-multi_signatures"></span>
</p><p><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-25T08:34:00.000Z-multi_signatures-1"></span>ddd <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-01-25T08:34:00.000Z-multi_signatures-1" class="ext-discussiontools-init-timestamplink">08:34, 25 January 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-01-25T08:34:00.000Z-multi_signatures-1"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-25T08:34:00.000Z-multi_signatures-1"></span>
Add tests for CommentFormatter I haven't really reviewed the outputs, but at least a) they don't crash b) they will fail if the output suddenly changes (which could cause problems due to caching). Bug: T252555 Change-Id: I1bbcbc5dd17ce1e24b3622062f5e8df4baf5f389
2020-10-19 20:59:55 +00:00
</p>
Turn comment timestamps into permalinks Bug: T275729 Change-Id: Ica9cfd9743a67fce170e8b078016fa79bf6fbb84
2022-07-30 22:02:17 +00:00
<ul><li><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-25T08:35:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z"></span>eee <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:35, 25 January 2020 (UTC) amended! <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-01-25T08:35:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z" class="ext-discussiontools-init-timestamplink">08:45, 25 January 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-01-25T08:35:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-25T08:35:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z"></span></li>
<li><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-25T08:36:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z"></span>fff <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-01-25T08:36:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z" class="ext-discussiontools-init-timestamplink">08:36, 25 January 2020 (UTC)</a> also!<span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-01-25T08:36:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-25T08:36:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z"></span></li>
<li><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-25T08:37:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z"></span>fff <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-01-25T08:37:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z" class="ext-discussiontools-init-timestamplink">08:37, 25 January 2020 (UTC)</a> and <i>also</i>!<span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-01-25T08:37:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-25T08:37:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z"></span>
<ul><li><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-25T08:38:00.000Z-Matma_Rex-2020-01-25T08:37:00.000Z"></span>multi-line reply <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-01-25T08:38:00.000Z-Matma_Rex-2020-01-25T08:37:00.000Z" class="ext-discussiontools-init-timestamplink">08:38, 25 January 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-01-25T08:38:00.000Z-Matma_Rex-2020-01-25T08:37:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-25T08:38:00.000Z-Matma_Rex-2020-01-25T08:37:00.000Z"></span></li>
<li><span data-mw-comment-start="" id="c-Matma_Rex-2020-01-25T08:38:00.000Z-Matma_Rex-2020-01-25T08:37:00.000Z-1"></span>ggg <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-01-25T08:38:00.000Z-Matma_Rex-2020-01-25T08:37:00.000Z-1" class="ext-discussiontools-init-timestamplink">08:38, 25 January 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-01-25T08:38:00.000Z-Matma_Rex-2020-01-25T08:37:00.000Z-1"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-01-25T08:38:00.000Z-Matma_Rex-2020-01-25T08:37:00.000Z-1"></span></li></ul></li></ul>
Use Parsoid DOMCompat/DOMUtils in CommentFormatter As CommentFormatter no longer needs HTMLFormatter, remove the inheritance and make addReplyLinks a static method. Testing locally this is marginally slower, going from 2.55s to 2.9s for the CommentFormatterTest case. Bug: T266317 Bug: T267973 Change-Id: If69749cae678a1647a138d782a32032189f55cec
2020-11-16 15:50:46 +00:00
Support topic subscriptions when JavaScript is disabled Unsubscribing was already available from Special:TopicSubscriptions when JavaScript is disabled. * Add links to subscribe/unsubscribe in CommentFormatter * Update links in skin navigation * Add support for subscribing in the actions Bug: T321431 Change-Id: If3c4bf7df309d0d98237c3b7b9c129cc2f72cda3
2022-12-08 16:15:02 +00:00
<div class="mw-heading mw-heading2 ext-discussiontools-init-section"><span class='ext-discussiontools-init-section-subscribeButton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-iconElement oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget' data-ooui='{"_":"OO.ui.ButtonWidget","href":"\/w\/index.php?title=Talk:Signatures_funny&amp;action=dtsubscribe&amp;commentname=h-Bob-2020-01-25T08%3A32%3A00.000Z&amp;section=hello+Matma+Rex+%28talk%29+18%3A27%2C+2+November+2020+%28UTC%29","rel":["nofollow"],"framed":false,"icon":"bellOutline","label":"(discussiontools-topicsubscription-button-subscribe-label)","title":"(discussiontools-topicsubscription-button-subscribe-tooltip)","flags":["progressive"],"classes":["ext-discussiontools-init-section-subscribeButton"]}'><a role='button' title='(discussiontools-topicsubscription-button-subscribe-tooltip)' tabindex='0' href='/w/index.php?title=Talk:Signatures_funny&amp;action=dtsubscribe&amp;commentname=h-Bob-2020-01-25T08%3A32%3A00.000Z&amp;section=hello+Matma+Rex+%28talk%29+18%3A27%2C+2+November+2020+%28UTC%29' rel='nofollow' class='oo-ui-buttonElement-button'><span class='oo-ui-iconElement-icon oo-ui-icon-bellOutline oo-ui-image-progressive'></span><span class='oo-ui-labelElement-label'>(discussiontools-topicsubscription-button-subscribe-label)</span><span class='oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive'></span></a></span><h2><span class="ext-discussiontools-init-section-subscribe mw-editsection-like"><span class="ext-discussiontools-init-section-subscribe-bracket">[</span><a href="/w/index.php?title=Talk:Signatures_funny&amp;action=dtsubscribe&amp;commentname=h-Bob-2020-01-25T08%3A32%3A00.000Z&amp;section=hello+Matma+Rex+%28talk%29+18%3A27%2C+2+November+2020+%28UTC%29" class="ext-discussiontools-init-section-subscribe-link" role="button" tabindex="0" title="(discussiontools-topicsubscription-button-subscribe-tooltip)">(discussiontools-topicsubscription-button-subscribe)</a><span class="ext-discussiontools-init-section-subscribe-bracket">]</span></span><span id="hello_Matma_Rex_.28talk.29_18:27.2C_2_November_2020_.28UTC.29"></span><span class="mw-headline" id="hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)" data-mw-thread-id="h-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)-2020-01-25T08:32:00.000Z"><span data-mw-comment-start="" id="h-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)-2020-01-25T08:32:00.000Z"></span>hello <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:27, 2 November 2020 (UTC)<span data-mw-comment-end="h-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)-2020-01-25T08:32:00.000Z"></span></span><span class="mw-editsection"><span class="mw-editsection-bracket">[</span><a href="/w/index.php?title=Talk:Signature_in_heading&amp;action=edit&amp;section=1" title="Edit section: hello Matma Rex (talk) 18:27, 2 November 2020 (UTC)">edit source</a><span class="mw-editsection-bracket">]</span></span></h2><div class="ext-discussiontools-init-section-bar"><div class="ext-discussiontools-init-section-metadata"><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-timestampLabel'>(discussiontools-topicheader-latestcomment: <a href="#c-Matma_Rex-2020-11-03T12:02:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z">1604404920</a>)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-commentCountLabel'>(discussiontools-topicheader-commentcount: 12)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-authorCountLabel'>(discussiontools-topicheader-authorcount: 2)</span></div><div class="ext-discussiontools-init-section-actions"></div></div></div>
Turn comment timestamps into permalinks Bug: T275729 Change-Id: Ica9cfd9743a67fce170e8b078016fa79bf6fbb84
2022-07-30 22:02:17 +00:00
<p><span data-mw-comment-start="" id="c-Matma_Rex-2020-11-02T18:28:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span>hello <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-11-02T18:28:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)" class="ext-discussiontools-init-timestamplink">18:28, 2 November 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-11-02T18:28:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-11-02T18:28:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span>
Use Parsoid DOMCompat/DOMUtils in CommentFormatter As CommentFormatter no longer needs HTMLFormatter, remove the inheritance and make addReplyLinks a static method. Testing locally this is marginally slower, going from 2.55s to 2.9s for the CommentFormatterTest case. Bug: T266317 Bug: T267973 Change-Id: If69749cae678a1647a138d782a32032189f55cec
2020-11-16 15:50:46 +00:00
</p>
Don't detect comments within quotes Bug: T275881 Change-Id: I8f7a4279837bd95ebf5b604ff350c0a3f29c2c05
2021-02-26 20:05:40 +00:00
<ul>
Turn comment timestamps into permalinks Bug: T275729 Change-Id: Ica9cfd9743a67fce170e8b078016fa79bf6fbb84
2022-07-30 22:02:17 +00:00
<li><span data-mw-comment-start="" id="c-Matma_Rex-2020-11-03T12:00:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"></span>Quoting another comment: <blockquote>bbb <b><a href="/wiki/User:Bob" title="User:Bob">Bob</a></b> 08:32, 25 January 2020 (UTC)</blockquote> <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-11-03T12:00:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z" class="ext-discussiontools-init-timestamplink">12:00, 3 November 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-11-03T12:00:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-11-03T12:00:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"></span></li>
<li><span data-mw-comment-start="" id="c-Bob-2020-01-25T08:32:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"></span>Quoting another comment, but without the right markup: <dl><dd>bbb <b><a href="/wiki/User:Bob" title="User:Bob">Bob</a></b> <a href="https://example.org/wiki/Talk:Signatures_funny#c-Bob-2020-01-25T08:32:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z" class="ext-discussiontools-init-timestamplink">08:32, 25 January 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Bob-2020-01-25T08:32:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Bob-2020-01-25T08:32:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"></span></dd></dl> <a href="/wiki/User:Matma_Rex" title="User:Matma Rex"><span data-mw-comment-start="" id="c-Matma_Rex-2020-11-03T12:01:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"></span>Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-11-03T12:01:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z" class="ext-discussiontools-init-timestamplink">12:01, 3 November 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-11-03T12:01:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-11-03T12:01:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"></span></li>
<li><span data-mw-comment-start="" id="c-Matma_Rex-2020-11-03T12:02:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"></span>Quoting another comment inline: <q>bbb <b><a href="/wiki/User:Bob" title="User:Bob">Bob</a></b> 08:32, 25 January 2020 (UTC)</q>. <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-11-03T12:02:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z" class="ext-discussiontools-init-timestamplink">12:02, 3 November 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-11-03T12:02:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-11-03T12:02:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z"></span></li>
<li><span data-mw-comment-start="" id="c-Bob-2020-01-25T08:32:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z-1"></span>Quoting another comment inline, but without the right markup: "bbb <b><a href="/wiki/User:Bob" title="User:Bob">Bob</a></b> 08:32, 25 January 2020 (UTC)". <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:Signatures_funny#c-Bob-2020-01-25T08:32:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z-1" class="ext-discussiontools-init-timestamplink">12:03, 3 November 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Bob-2020-01-25T08:32:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z-1"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Bob-2020-01-25T08:32:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z-1"></span></li>
Don't detect comments within quotes Bug: T275881 Change-Id: I8f7a4279837bd95ebf5b604ff350c0a3f29c2c05
2021-02-26 20:05:40 +00:00
</ul>
Turn comment timestamps into permalinks Bug: T275729 Change-Id: Ica9cfd9743a67fce170e8b078016fa79bf6fbb84
2022-07-30 22:02:17 +00:00
<p><span data-mw-comment-start="" id="c-Matma_Rex-2020-11-02T18:29:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span>Wrapped signature. <small><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-11-02T18:29:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)" class="ext-discussiontools-init-timestamplink">18:29, 2 November 2020 (UTC)</a><span data-mw-comment-end="c-Matma_Rex-2020-11-02T18:29:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span></small><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-11-02T18:29:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span></p>
<p><span data-mw-comment-start="" id="c-Matma_Rex-2020-11-02T18:30:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span>Double wrapped signature. <sup><small><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-11-02T18:30:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)" class="ext-discussiontools-init-timestamplink">18:30, 2 November 2020 (UTC)</a></small><span data-mw-comment-end="c-Matma_Rex-2020-11-02T18:30:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span></sup><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-11-02T18:30:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span></p>
<p><span data-mw-comment-start="" id="c-Matma_Rex-2020-11-02T18:31:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span>Double wrapped signature with inner trailing text. <sup><small><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-11-02T18:31:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)" class="ext-discussiontools-init-timestamplink">18:31, 2 November 2020 (UTC)</a></small>text<span data-mw-comment-end="c-Matma_Rex-2020-11-02T18:31:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span></sup><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-11-02T18:31:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span></p>
<p><span data-mw-comment-start="" id="c-Matma_Rex-2020-11-02T18:32:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span>Double wrapped signature with outer trailing text. <sup><small><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-11-02T18:32:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)" class="ext-discussiontools-init-timestamplink">18:32, 2 November 2020 (UTC)</a></small></sup>text<span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-11-02T18:32:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-11-02T18:32:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span></p>
<p><span data-mw-comment-start="" id="c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span>Trailing tags. <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)" class="ext-discussiontools-init-timestamplink">18:33, 2 November 2020 (UTC)</a><span>foo<span data-mw-comment-end="c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"></span></span><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span></p>
<p><span data-mw-comment-start="" id="c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)-1"></span>Trailing void tags (br). <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) <a href="https://example.org/wiki/Talk:Signatures_funny#c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)-1" class="ext-discussiontools-init-timestamplink">18:33, 2 November 2020 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)-1"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span><span class="ext-discussiontools-init-replylink-bracket">[</span><a class="ext-discussiontools-init-replylink-reply" role="button" tabindex="0" href="">(discussiontools-replylink)</a><span class="ext-discussiontools-init-replylink-bracket">]</span></span><span data-mw-comment-end="c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)-1"></span><br/></p>
Use setExtensionData() instead of marker comments where possible (3/3) We started using marker comments (HTML comments with special content inserted into the page) for the reply buttons back in the day, because we needed to indicate their location in the HTML. Later we used the same idea for things which aren't actually tied to a specific location in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a better way to do this. This commit stop writing the HTML comments, which are no longer used, and cleans up the tests. Bug: T328980 Change-Id: I37541356830945cc9abcc79d4c445ff6f2449759 (cherry picked from commit ab40ef62c08fe375ea04b254e4df0a28c295544f)
2023-02-07 00:42:00 +00:00
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
<pre>
Use setExtensionData() instead of marker comments where possible (3/3) We started using marker comments (HTML comments with special content inserted into the page) for the reply buttons back in the day, because we needed to indicate their location in the HTML. Later we used the same idea for things which aren't actually tied to a specific location in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a better way to do this. This commit stop writing the HTML comments, which are no longer used, and cleans up the tests. Bug: T328980 Change-Id: I37541356830945cc9abcc79d4c445ff6f2449759 (cherry picked from commit ab40ef62c08fe375ea04b254e4df0a28c295544f)
2023-02-07 00:42:00 +00:00
newestComment: {
"id": "c-Matma_Rex-2020-11-03T12:02:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z",
"timestamp": "2020-11-03T12:02:00.000Z",
"author": "Matma Rex",
"heading": {
"headingLevel": 2,
"name": "h-Bob-2020-01-25T08:32:00.000Z",
"type": "heading",
"level": 0,
"id": "h-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)-2020-01-25T08:32:00.000Z",
"replies": [
"c-Matma_Rex-2020-11-02T18:28:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"c-Matma_Rex-2020-11-02T18:29:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"c-Matma_Rex-2020-11-02T18:30:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"c-Matma_Rex-2020-11-02T18:31:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"c-Matma_Rex-2020-11-02T18:32:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)-1"
],
"text": "hello Matma Rex (talk) 18:27, 2 November 2020 (UTC)",
"linkableTitle": "hello Matma Rex (talk) 18:27, 2 November 2020 (UTC)"
}
}
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
{
"wgDiscussionToolsPageThreads": [
{
"headingLevel": 2,
"name": "h-Matma_Rex-2020-01-25T08:31:00.000Z",
"type": "heading",
"level": 0,
"id": "h-multi_signatures-2020-01-25T08:31:00.000Z",
"replies": [
{
"timestamp": "2020-01-25T08:31:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2020-01-25T08:31:00.000Z-multi_signatures",
"replies": [
{
"timestamp": "2020-01-25T08:32:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 2,
"id": "c-Matma_Rex-2020-01-25T08:32:00.000Z-Matma_Rex-2020-01-25T08:31:00.000Z",
"replies": [
{
"timestamp": "2020-01-25T08:33:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 3,
"id": "c-Matma_Rex-2020-01-25T08:33:00.000Z-Matma_Rex-2020-01-25T08:32:00.000Z",
"replies": []
}
]
}
]
},
{
"timestamp": "2020-01-25T08:34:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2020-01-25T08:34:00.000Z-multi_signatures",
"replies": []
},
{
"timestamp": "2020-01-25T08:34:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2020-01-25T08:34:00.000Z-multi_signatures-1",
"replies": [
{
"timestamp": "2020-01-25T08:35:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 2,
"id": "c-Matma_Rex-2020-01-25T08:35:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z",
"replies": []
},
{
"timestamp": "2020-01-25T08:36:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 2,
"id": "c-Matma_Rex-2020-01-25T08:36:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z",
"replies": []
},
{
"timestamp": "2020-01-25T08:37:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 2,
"id": "c-Matma_Rex-2020-01-25T08:37:00.000Z-Matma_Rex-2020-01-25T08:34:00.000Z",
"replies": [
{
"timestamp": "2020-01-25T08:38:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 3,
"id": "c-Matma_Rex-2020-01-25T08:38:00.000Z-Matma_Rex-2020-01-25T08:37:00.000Z",
"replies": []
},
{
"timestamp": "2020-01-25T08:38:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 3,
"id": "c-Matma_Rex-2020-01-25T08:38:00.000Z-Matma_Rex-2020-01-25T08:37:00.000Z-1",
"replies": []
}
]
}
]
}
[BREAKING CHANGE] Remove isSectionEditable from overflow hook Instead make isUneditableSection an optional property of ContentHeadingItem. Change-Id: Icfddf28aa789b5014ac183ff9f9699f38d78c121
2023-10-11 15:53:55 +00:00
],
"uneditableSection": true
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
},
{
"headingLevel": 2,
"name": "h-Bob-2020-01-25T08:32:00.000Z",
"type": "heading",
"level": 0,
"id": "h-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)-2020-01-25T08:32:00.000Z",
"replies": [
{
"timestamp": "2020-11-02T18:28:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2020-11-02T18:28:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"replies": [
{
"timestamp": "2020-11-03T12:00:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 2,
"id": "c-Matma_Rex-2020-11-03T12:00:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z",
"replies": []
},
{
"timestamp": "2020-01-25T08:32:00.000Z",
"author": "Bob",
"type": "comment",
"level": 2,
"id": "c-Bob-2020-01-25T08:32:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z",
"replies": []
},
{
"timestamp": "2020-11-03T12:01:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 2,
"id": "c-Matma_Rex-2020-11-03T12:01:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z",
"replies": []
},
{
"timestamp": "2020-11-03T12:02:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 2,
"id": "c-Matma_Rex-2020-11-03T12:02:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z",
"replies": []
},
{
"timestamp": "2020-01-25T08:32:00.000Z",
"author": "Bob",
"type": "comment",
"level": 2,
"id": "c-Bob-2020-01-25T08:32:00.000Z-Matma_Rex-2020-11-02T18:28:00.000Z-1",
"replies": []
}
]
},
{
"timestamp": "2020-11-02T18:29:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2020-11-02T18:29:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"replies": []
},
{
"timestamp": "2020-11-02T18:30:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2020-11-02T18:30:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"replies": []
},
{
"timestamp": "2020-11-02T18:31:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2020-11-02T18:31:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"replies": []
},
{
"timestamp": "2020-11-02T18:32:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2020-11-02T18:32:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"replies": []
},
{
"timestamp": "2020-11-02T18:33:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)",
"replies": []
},
{
"timestamp": "2020-11-02T18:33:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2020-11-02T18:33:00.000Z-hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)-1",
"replies": []
}
[BREAKING CHANGE] Remove isSectionEditable from overflow hook Instead make isUneditableSection an optional property of ContentHeadingItem. Change-Id: Icfddf28aa789b5014ac183ff9f9699f38d78c121
2023-10-11 15:53:55 +00:00
],
"uneditableSection": true
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
}
]
}
</pre>
Reference in a new issue Copy permalink