wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-29 13:26:28 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Discus.../tests/cases/pl-big-oldparser/pl-big-oldparser.json

3580 lines
91 KiB
JSON
Raw Normal View History

Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
[
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/4/0",
"0/4/1"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-29T06:23:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Stok",
"range": [
"0/6/0",
"0/7/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/7/1",
"0/7/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Stok|2018-09-29T06:23:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-29T07:06:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Cybularny",
"range": [
"0/9/0/0",
"0/9/0/3/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/9/0/1",
"0/9/0/3/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Cybularny|2018-09-29T07:06:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-01T18:20:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Zwiadowca21",
"range": [
"0/11/0/0/0/0/0",
"0/11/0/0/0/12/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/11/0/0/0/10",
"0/11/0/0/0/12/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Zwiadowca21|2018-10-01T18:20:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/13/0",
"0/13/1"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-30T01:22:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Wostr",
"range": [
"0/15/0",
"0/19/3/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/19/0",
"0/19/3/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Wostr|2018-09-30T01:22:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-30T07:43:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Eurohunter",
"range": [
"0/21/0/0/0/0/0",
"0/21/0/0/0/7/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/21/0/0/0/4",
"0/21/0/0/0/7/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Eurohunter|2018-09-30T07:43:00.000Z|0",
Allow updating the expected results when running PHP tests This is similar to the code we already have in JS tests, but instead of printing to the console where you have to copy-paste from, it just overwrites the files. Also, update all of the expected results by this method. Changes in the expected outputs: * In JSON files, the "warnings" are now always in the same place regardless of the type of the warning. * In all HTML files, self-closing tags now include the trailing slash, some characters are no longer encoded as entities when not necessary, and attributes may be single-quoted when that makes them shorter. * In Parsoid HTML files, the header is no longer terribly mangled. Other notes: * CommentParserTest.php: Change the output of serializeComments() to be in similar order as in JS, to reduce the diffs in this commit and because it's a better order for humans. * modifier.test.js: Remove some hacks that were working around small inconsistencies between the previous expected outputs and the actual outputs. Change-Id: I9f764640dae823321c0ac35898fa4db03f1ca364
2020-07-30 23:34:56 +00:00
"warnings": [
"Comment skips indentation level"
],
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-30T07:52:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Eurohunter",
"range": [
"0/21/0/0/0/8/0/0",
"0/21/0/0/0/8/0/8/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/21/0/0/0/8/0/5",
"0/21/0/0/0/8/0/8/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Eurohunter|2018-09-30T07:52:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-30T07:55:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Eurohunter",
"range": [
"0/21/0/0/0/8/0/9/0/0",
"0/21/0/0/0/8/0/9/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/21/0/0/0/8/0/9/0/1",
"0/21/0/0/0/8/0/9/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 5,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Eurohunter|2018-09-30T07:55:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-30T10:42:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "WTM",
"range": [
"0/23/0",
"0/23/16/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/23/7",
"0/23/10/27"
],
[
"0/23/13",
"0/23/16/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
parser: Merge multiple comments on one line Even when you have multiple signatures by multiple users in one paragraph (or list item), it's still basically a single comment. We don't want to offer multiple buttons to reply to it. The changed parser test cases are illustrative: * All affected comments in the "pl" example are comments with a "post-scriptum", which is now more intuitively treated as part of the main comment. * The first comment in the "en" example would probably have been better if it wasn't merged, but a weird use of the outdent template causes us to not be able to distinguish that the two parts of the comment display on separate lines. * The last comment in the "en" example (isn't that neat?) was previously incorrectly treated as two comments, because there's a timestamp in the middle of it (the user is referring to another comment). * Remaining affected comments in the "en" example are also comments with a "post-scriptum" and their treatment is clearly better now. It also accidentally fixes some problems with modifier tests (but not all), where previously <dl> nodes would be inserted in the middle of <p> nodes, to reply to the comments which are now merged. Bug: T240640 Change-Id: I0f2d9238aff75d78286250affd323cd145661a11
2020-01-22 00:00:18 +00:00
"id": "WTM|2018-09-30T10:42:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-30T11:09:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Eurohunter",
"range": [
"0/25/0/0/0",
"0/25/0/5/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/25/0/2",
"0/25/0/5/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Eurohunter|2018-09-30T11:09:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-30T16:32:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Yashaa",
"range": [
"0/25/0/6/0/0/0",
"0/25/0/6/0/5/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/25/0/6/0/2",
"0/25/0/6/0/5/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Yashaa|2018-09-30T16:32:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-30T21:24:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Eurohunter",
"range": [
"0/25/0/6/0/6/0/0",
"0/25/0/6/0/6/0/8/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/25/0/6/0/6/0/5",
"0/25/0/6/0/6/0/8/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Eurohunter|2018-09-30T21:24:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-01T10:18:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Yashaa",
"range": [
"0/25/0/6/0/6/0/9/0/0",
"0/25/0/6/0/6/0/9/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/25/0/6/0/6/0/9/0/1",
"0/25/0/6/0/6/0/9/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 5,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Yashaa|2018-10-01T10:18:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-30T22:17:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "WTM",
"range": [
"0/27/0",
"0/27/18/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/27/15",
"0/27/18/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "WTM|2018-09-30T22:17:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-01T06:39:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Panek",
"range": [
"0/29/0/0",
"0/29/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/29/0/1",
"0/29/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Panek|2018-10-01T06:39:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-01T09:52:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Panek",
"range": [
"0/29/0/5/0/0",
"0/29/0/5/2/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/29/0/5/2/1",
"0/29/0/5/2/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Panek|2018-10-01T09:52:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-01T20:23:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Barcival",
"range": [
"0/29/2/0",
"0/29/2/8/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/29/2/5",
"0/29/2/8/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Barcival|2018-10-01T20:23:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/31/0",
"0/31/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-01T13:54:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Zwiadowca21",
"range": [
"0/33/0",
"0/33/15/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/33/13",
"0/33/15/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Zwiadowca21|2018-10-01T13:54:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-01T17:32:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Piolodiusz",
"range": [
"0/34/0",
"0/34/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/34/3",
"0/34/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Piolodiusz|2018-10-01T17:32:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-02T16:02:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Eurohunter",
"range": [
"0/36/0/0",
"0/36/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/36/0/1",
"0/36/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Eurohunter|2018-10-02T16:02:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/38/0",
"0/38/1"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-03T12:51:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "MOs810",
"range": [
"0/40/0",
"0/40/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/40/3",
"0/40/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "MOs810|2018-10-03T12:51:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-03T13:16:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Teukros",
"range": [
"0/42/0/0",
"0/42/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/42/0/3",
"0/42/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Teukros|2018-10-03T13:16:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-03T13:59:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "MOs810",
"range": [
"0/42/0/7/0/0",
"0/42/0/7/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/42/0/7/0/3",
"0/42/0/7/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "MOs810|2018-10-03T13:59:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-03T17:27:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Aotearoa",
"range": [
"0/42/2/0",
"0/42/2/4/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/42/2/1",
"0/42/2/4/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Aotearoa|2018-10-03T17:27:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/44/0",
"0/44/1"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-04T17:49:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "GregX21",
"range": [
"0/46/0",
"0/48/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/48/1",
"0/48/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "GregX21|2018-10-04T17:49:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-05T15:32:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Piolodiusz",
"range": [
"0/50/0/0",
"0/50/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/50/0/3",
"0/50/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Piolodiusz|2018-10-05T15:32:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-06T07:05:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "GregX21",
"range": [
"0/52/0/0/0/0",
"0/52/0/0/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/52/0/0/0/1",
"0/52/0/0/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "GregX21|2018-10-06T07:05:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-06T12:12:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Witia",
"range": [
"0/54/0/0",
"0/54/0/12/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/54/0/9",
"0/54/0/12/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Witia|2018-10-06T12:12:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-06T16:18:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "GregX21",
"range": [
"0/56/0/0/0/0",
"0/58/0/0/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/58/0/0/0/1",
"0/58/0/0/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "GregX21|2018-10-06T16:18:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/60/0",
"0/60/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-29T10:14:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "MOs810",
"range": [
"0/62/0",
"0/62/14/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/62/11",
"0/62/14/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "MOs810|2018-07-29T10:14:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-29T10:31:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Gdarin",
"range": [
"0/64/0/0",
"0/64/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/64/0/3",
"0/64/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Gdarin|2018-07-29T10:31:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-29T10:34:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Teukros",
"range": [
"0/64/2/0",
"0/64/2/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/64/2/1",
"0/64/2/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Teukros|2018-07-29T10:34:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-29T11:27:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Kenraiz",
"range": [
"0/64/4/0",
"0/64/4/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/64/4/1",
"0/64/4/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Kenraiz|2018-07-29T11:27:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-29T11:34:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Gruzin",
"range": [
"0/66/0/0/0/0",
"0/66/0/0/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/66/0/0/0/1",
"0/66/0/0/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Gruzin|2018-07-29T11:34:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-29T12:55:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Anagram16",
"range": [
"0/66/0/2/0/0/0/0",
"0/66/0/2/0/0/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/66/0/2/0/0/0/1",
"0/66/0/2/0/0/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Anagram16|2018-07-29T12:55:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-29T11:52:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Adamt",
"range": [
"0/68/0/0",
"0/68/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/68/0/1",
"0/68/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Adamt|2018-07-29T11:52:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-29T12:12:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Anagram16",
"range": [
"0/68/2/0",
"0/68/2/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/68/2/1",
"0/68/2/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Anagram16|2018-07-29T12:12:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-29T13:37:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Hoa binh",
"range": [
"0/68/4/0",
"0/68/4/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/68/4/1",
"0/68/4/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Hoa binh|2018-07-29T13:37:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-29T13:45:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Anagram16",
"range": [
"0/70/0/0/0/0",
"0/70/0/0/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/70/0/0/0/1",
"0/70/0/0/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Anagram16|2018-07-29T13:45:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-29T16:11:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Gruzin",
"range": [
"0/70/0/0/2/0",
"0/70/0/0/2/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/70/0/0/2/1",
"0/70/0/0/2/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Gruzin|2018-07-29T16:11:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-30T17:54:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Zetpe0202",
"range": [
"0/72/0/0",
"0/72/0/20/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/72/0/17",
"0/72/0/20/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Zetpe0202|2018-07-30T17:54:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-30T18:47:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Gruzin",
"range": [
"0/74/0/0/0/0",
"0/74/0/0/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/74/0/0/0/1",
"0/74/0/0/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Gruzin|2018-07-30T18:47:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-30T19:08:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "John Belushi",
"range": [
"0/76/0/0",
"0/76/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/76/0/1",
"0/76/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "John Belushi|2018-07-30T19:08:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-30T19:30:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Gruzin",
"range": [
"0/76/2/0",
"0/76/2/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/76/2/1",
"0/76/2/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Gruzin|2018-07-30T19:30:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-31T08:26:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "MOs810",
"range": [
"0/76/4/0",
"0/76/4/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/76/4/1",
"0/76/4/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "MOs810|2018-07-31T08:26:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-31T08:36:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "John Belushi",
"range": [
"0/78/0/0/0/0",
"0/78/0/0/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/78/0/0/0/1",
"0/78/0/0/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "John Belushi|2018-07-31T08:36:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-31T14:56:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Gruzin",
"range": [
"0/78/0/0/2/0",
"0/78/0/0/2/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/78/0/0/2/1",
"0/78/0/0/2/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Gruzin|2018-07-31T14:56:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-31T15:21:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Teukros",
"range": [
"0/78/0/0/4/0",
"0/78/0/0/4/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/78/0/0/4/1",
"0/78/0/0/4/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Teukros|2018-07-31T15:21:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-31T16:44:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Malarz pl",
"range": [
"0/78/0/0/6/0",
"0/78/0/0/6/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/78/0/0/6/1",
"0/78/0/0/6/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Malarz pl|2018-07-31T16:44:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-31T17:50:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Zala",
"range": [
"0/78/0/0/6/5/0/0",
"0/78/0/0/6/5/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/78/0/0/6/5/0/1",
"0/78/0/0/6/5/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Zala|2018-07-31T17:50:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-07-31T22:05:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Adamt",
"range": [
"0/78/0/0/8/0",
"0/78/0/0/8/4/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/78/0/0/8/1",
"0/78/0/0/8/4/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Adamt|2018-07-31T22:05:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-08-01T18:20:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "John Belushi",
"range": [
"0/78/0/2/0/0/0/0",
"0/78/0/2/0/0/0/10/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/78/0/2/0/0/0/7",
"0/78/0/2/0/0/0/10/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "John Belushi|2018-08-01T18:20:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-08-06T14:08:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "KamilK7",
"range": [
"0/80/0/0",
"0/80/0/4/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/80/0/1",
"0/80/0/4/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "KamilK7|2018-08-06T14:08:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-08-13T22:43:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Cz ja",
"range": [
"0/82/0",
"0/82/8/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/82/1",
"0/82/4/27"
],
[
"0/82/5",
"0/82/8/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
parser: Merge multiple comments on one line Even when you have multiple signatures by multiple users in one paragraph (or list item), it's still basically a single comment. We don't want to offer multiple buttons to reply to it. The changed parser test cases are illustrative: * All affected comments in the "pl" example are comments with a "post-scriptum", which is now more intuitively treated as part of the main comment. * The first comment in the "en" example would probably have been better if it wasn't merged, but a weird use of the outdent template causes us to not be able to distinguish that the two parts of the comment display on separate lines. * The last comment in the "en" example (isn't that neat?) was previously incorrectly treated as two comments, because there's a timestamp in the middle of it (the user is referring to another comment). * Remaining affected comments in the "en" example are also comments with a "post-scriptum" and their treatment is clearly better now. It also accidentally fixes some problems with modifier tests (but not all), where previously <dl> nodes would be inserted in the middle of <p> nodes, to reply to the comments which are now merged. Bug: T240640 Change-Id: I0f2d9238aff75d78286250affd323cd145661a11
2020-01-22 00:00:18 +00:00
"id": "Cz ja|2018-08-13T22:43:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-08-14T07:07:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Malarz pl",
"range": [
"0/84/0/0",
"0/84/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/84/0/3",
"0/84/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Malarz pl|2018-08-14T07:07:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-08-31T15:59:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "BasileusAutokratorPL",
"range": [
"0/86/0",
"0/86/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/86/1",
"0/86/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "BasileusAutokratorPL|2018-08-31T15:59:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-08T16:10:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ciacho5",
"range": [
"0/88/0/0/0",
"0/88/0/7/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/88/0/4",
"0/88/0/7/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ciacho5|2018-09-08T16:10:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-09-09T15:15:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "BasileusAutokratorPL",
"range": [
"0/90/0",
"0/90/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/90/1",
"0/90/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "BasileusAutokratorPL|2018-09-09T15:15:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-08T09:34:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Alan ffm",
"range": [
"0/92/0/0",
"0/92/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/92/0/1",
"0/92/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Alan ffm|2018-10-08T09:34:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/94/0",
"0/94/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-09T20:26:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Wostr",
"range": [
"0/96/0",
"0/96/8/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/96/5",
"0/96/8/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Wostr|2018-10-09T20:26:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-11T12:15:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Kriis bis",
"range": [
"0/98/0/0",
"0/98/0/14/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/98/0/11",
"0/98/0/14/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Kriis bis|2018-10-11T12:15:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/100/0",
"0/100/1"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-10T19:51:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ciacho5",
"range": [
"0/102/0",
"0/102/8/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/102/5",
"0/102/8/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ciacho5|2018-10-10T19:51:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-10T21:52:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Piotr967",
"range": [
"0/104/0/0",
"0/104/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/104/0/1",
"0/104/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Piotr967|2018-10-10T21:52:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-11T08:12:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ciacho5",
"range": [
"0/106/0/0",
"0/106/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/106/0/1",
"0/106/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ciacho5|2018-10-11T08:12:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-11T12:44:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Henryk Tannhäuser",
"range": [
"0/106/2/0",
"0/106/2/8/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/106/2/5",
"0/106/2/8/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Henryk Tannhäuser|2018-10-11T12:44:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/108/0",
"0/108/1"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-11T20:46:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "WTM",
"range": [
"0/110/0",
"0/110/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/110/3",
"0/110/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "WTM|2018-10-11T20:46:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-12T07:11:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Kriis bis",
"range": [
"0/112/0/0",
"0/112/0/8/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/112/0/5",
"0/112/0/8/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Kriis bis|2018-10-12T07:11:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/114/0",
"0/114/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-06T12:50:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Jacek555",
"range": [
"0/116/0",
"0/116/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/116/3",
"0/116/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Jacek555|2018-10-06T12:50:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-06T16:35:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Vinsinna",
"range": [
"0/118/0/0",
"0/118/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/118/0/1",
"0/118/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Vinsinna|2018-10-06T16:35:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-06T17:18:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Wostr",
"range": [
"0/120/0/0",
"0/120/0/8/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/0/5",
"0/120/0/8/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Wostr|2018-10-06T17:18:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-06T17:36:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Matrek",
"range": [
"0/120/2/0",
"0/120/2/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/2/1",
"0/120/2/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Matrek|2018-10-06T17:36:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-07T08:20:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Dreamcatcher25",
"range": [
"0/120/4/0",
"0/120/4/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/4/3",
"0/120/4/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Dreamcatcher25|2018-10-07T08:20:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-07T16:04:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Matrek",
"range": [
"0/120/4/7/0/0/0/0",
"0/120/4/7/0/0/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/4/7/0/0/0/3",
"0/120/4/7/0/0/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Matrek|2018-10-07T16:04:00.000Z|0",
Stop printing console warnings It was useful when I was debugging those parts of the code, but now it's usually annoying. The warnings can still sometimes be useful for understanding how the tool parses some discussion, though. To keep that functionality, add displaying warnings for each comment in the debug mode. Change-Id: I2d218a8a394f179bcc0990ff988a0567c275ccf2
2020-05-13 18:23:48 +00:00
"warnings": [
"Comment skips indentation level"
Allow updating the expected results when running PHP tests This is similar to the code we already have in JS tests, but instead of printing to the console where you have to copy-paste from, it just overwrites the files. Also, update all of the expected results by this method. Changes in the expected outputs: * In JSON files, the "warnings" are now always in the same place regardless of the type of the warning. * In all HTML files, self-closing tags now include the trailing slash, some characters are no longer encoded as entities when not necessary, and attributes may be single-quoted when that makes them shorter. * In Parsoid HTML files, the header is no longer terribly mangled. Other notes: * CommentParserTest.php: Change the output of serializeComments() to be in similar order as in JS, to reduce the diffs in this commit and because it's a better order for humans. * modifier.test.js: Remove some hacks that were working around small inconsistencies between the previous expected outputs and the actual outputs. Change-Id: I9f764640dae823321c0ac35898fa4db03f1ca364
2020-07-30 23:34:56 +00:00
],
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-07T11:43:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Wostr",
"range": [
"0/120/4/7/2/0",
"0/120/4/7/2/4/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/4/7/2/1",
"0/120/4/7/2/4/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Wostr|2018-10-07T11:43:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-07T16:27:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Wostr",
"range": [
"0/120/6/0",
"0/120/6/8/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/6/5",
"0/120/6/8/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Wostr|2018-10-07T16:27:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-07T16:34:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Matrek",
"range": [
"0/120/6/9/0/0",
"0/120/6/9/0/8/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/6/9/0/1",
"0/120/6/9/0/4/26"
],
[
"0/120/6/9/0/5",
"0/120/6/9/0/8/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
parser: Merge multiple comments on one line Even when you have multiple signatures by multiple users in one paragraph (or list item), it's still basically a single comment. We don't want to offer multiple buttons to reply to it. The changed parser test cases are illustrative: * All affected comments in the "pl" example are comments with a "post-scriptum", which is now more intuitively treated as part of the main comment. * The first comment in the "en" example would probably have been better if it wasn't merged, but a weird use of the outdent template causes us to not be able to distinguish that the two parts of the comment display on separate lines. * The last comment in the "en" example (isn't that neat?) was previously incorrectly treated as two comments, because there's a timestamp in the middle of it (the user is referring to another comment). * Remaining affected comments in the "en" example are also comments with a "post-scriptum" and their treatment is clearly better now. It also accidentally fixes some problems with modifier tests (but not all), where previously <dl> nodes would be inserted in the middle of <p> nodes, to reply to the comments which are now merged. Bug: T240640 Change-Id: I0f2d9238aff75d78286250affd323cd145661a11
2020-01-22 00:00:18 +00:00
"id": "Matrek|2018-10-07T16:34:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-07T16:53:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Wostr",
"range": [
"0/120/6/9/0/9/0/0",
"0/120/6/9/0/9/0/8/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/6/9/0/9/0/5",
"0/120/6/9/0/9/0/8/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Wostr|2018-10-07T16:53:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-07T18:49:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Vinsinna",
"range": [
"0/120/6/9/0/9/0/9/0/0",
"0/120/6/9/0/9/0/9/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/6/9/0/9/0/9/0/3",
"0/120/6/9/0/9/0/9/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 5,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Vinsinna|2018-10-07T18:49:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-08T16:33:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Jacek555",
"range": [
"0/120/6/9/2/0",
"0/120/6/9/2/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/6/9/2/3",
"0/120/6/9/2/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Jacek555|2018-10-08T16:33:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-07T16:32:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Gruzin",
"range": [
"0/120/8/0",
"0/120/8/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/8/1",
"0/120/8/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Gruzin|2018-10-07T16:32:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-07T18:00:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Lesław Zimny",
"range": [
"0/120/10/0",
"0/120/10/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/120/10/3",
"0/120/10/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Lesław Zimny|2018-10-07T18:00:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-08T08:01:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Alan ffm",
"range": [
"0/122/0/0/0/0",
"0/122/0/0/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/122/0/0/0/3",
"0/122/0/0/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Alan ffm|2018-10-08T08:01:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-08T16:33:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Jacek555",
"range": [
"0/122/0/2/0/0/0/0",
"0/122/0/2/0/0/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/122/0/2/0/0/0/1",
"0/122/0/2/0/0/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Jacek555|2018-10-08T16:33:00.000Z|1",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-08T16:33:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Jacek555",
"range": [
"0/124/0/0",
"0/124/0/8/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/124/0/5",
"0/124/0/8/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Jacek555|2018-10-08T16:33:00.000Z|2",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-16T17:40:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Wostr",
"range": [
"0/124/2/0",
"0/124/2/8/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/124/2/5",
"0/124/2/8/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Wostr|2018-10-16T17:40:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-16T17:53:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Jacek555",
"range": [
"0/126/0/0",
"0/126/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/126/0/1",
"0/126/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Jacek555|2018-10-16T17:53:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/128/0",
"0/128/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-16T10:55:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Pawelmhm",
"range": [
"0/130/0",
"0/130/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/130/1",
"0/130/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Pawelmhm|2018-10-16T10:55:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-16T11:30:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ironupiwada",
"range": [
"0/132/0/0",
"0/132/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/132/0/3",
"0/132/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ironupiwada|2018-10-16T11:30:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-16T12:01:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Pawelmhm",
"range": [
"0/132/2/0",
"0/132/2/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/132/2/3",
"0/132/2/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Pawelmhm|2018-10-16T12:01:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-16T12:14:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Tomasz Raburski",
"range": [
"0/132/4/0",
"0/132/4/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/132/4/1",
"0/132/4/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Tomasz Raburski|2018-10-16T12:14:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-16T13:48:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ciacho5",
"range": [
"0/132/6/0",
"0/132/6/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/132/6/1",
"0/132/6/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ciacho5|2018-10-16T13:48:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-16T14:57:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ironupiwada",
"range": [
"0/132/6/5/0/0",
"0/132/6/5/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/132/6/5/0/1",
"0/132/6/5/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ironupiwada|2018-10-16T14:57:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-17T06:56:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ciacho5",
"range": [
"0/132/6/5/0/5/0/0",
"0/132/6/5/0/5/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/132/6/5/0/5/0/3",
"0/132/6/5/0/5/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ciacho5|2018-10-17T06:56:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/134/0",
"0/134/1"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-17T06:39:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Gżdacz",
"range": [
"0/136/0",
"0/136/8/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/136/5",
"0/136/8/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Gżdacz|2018-10-17T06:39:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-17T07:16:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Michał Rosa",
"range": [
"0/138/0/0",
"0/138/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/138/0/3",
"0/138/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Michał Rosa|2018-10-17T07:16:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/140/0",
"0/140/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-11T17:25:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Piotr967",
"range": [
"0/142/0/0",
"0/142/9/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/142/6",
"0/142/9/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Piotr967|2018-10-11T17:25:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-12T11:17:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Bobek321",
"range": [
"0/144/0/0",
"0/144/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/144/0/3",
"0/144/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Bobek321|2018-10-12T11:17:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-12T18:22:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Piotr967",
"range": [
"0/146/0/0/0/0",
"0/146/0/0/0/8/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/146/0/0/0/5",
"0/146/0/0/0/8/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Piotr967|2018-10-12T18:22:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-12T18:51:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Kenraiz",
"range": [
"0/146/0/0/0/9/0/0",
"0/146/0/0/0/9/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/146/0/0/0/9/0/3",
"0/146/0/0/0/9/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Kenraiz|2018-10-12T18:51:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-15T22:47:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ented",
"range": [
"0/148/0/0",
"0/148/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/148/0/3",
"0/148/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ented|2018-10-15T22:47:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-17T19:08:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Bobek321",
"range": [
"0/148/2/0",
"0/148/2/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/148/2/1",
"0/148/2/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Bobek321|2018-10-17T19:08:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-17T19:25:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Piotr967",
"range": [
"0/150/0/0/0/0",
"0/150/0/0/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/150/0/0/0/1",
"0/150/0/0/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Piotr967|2018-10-17T19:25:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-17T19:49:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Malarz pl",
"range": [
"0/150/2/0",
"0/150/2/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/150/2/3",
"0/150/2/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Malarz pl|2018-10-17T19:49:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/152/0",
"0/152/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-18T10:29:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Pawelmhm",
"range": [
"0/154/0",
"0/154/14/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/154/11",
"0/154/14/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Pawelmhm|2018-10-18T10:29:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-18T11:05:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Tomasz Raburski",
"range": [
"0/156/0/0",
"0/156/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/156/0/1",
"0/156/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Tomasz Raburski|2018-10-18T11:05:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-18T12:04:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ciacho5",
"range": [
"0/156/2/0",
"0/156/2/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/156/2/3",
"0/156/2/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ciacho5|2018-10-18T12:04:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/158/0",
"0/158/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-19T01:41:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Demkoff",
"range": [
Only detect comments with real signatures Consequences of this are visible in the test cases: * (en) Tech News posts are not detected. Examples: "21:22, 1 July 2019 (UTC)", "21:42, 29 July 2019 (UTC)" * (en) Comments by users who customize the timestamp are not detected. Examples: "10:49, 28 June 2019 (UTC)", "21:34, 14 July 2019 (UTC)" * (en) Comments with signatures missing a username are not detected. This sometimes happens if a comment is accidentally signed with '~~~~~' (five tildes), which only inserts the timestamp. Examples: "17:17, 27 July 2019 (UTC)", "10:25, 29 July 2019 (UTC)" * (pl) A lone timestamp at the beginning of a thread is not detected. It's not part of a post, it was added to aid automatic archiving. Example: "21:03, 18 paź 2018 (CET)" Bug: T245692 Change-Id: I0767bb239a1800f2e538917b5995fc4f0fa4d043
2020-02-20 22:06:17 +00:00
"0/160/0/0/0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"0/164/0/10/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/164/0/7",
"0/164/0/10/26"
]
],
Only detect comments with real signatures Consequences of this are visible in the test cases: * (en) Tech News posts are not detected. Examples: "21:22, 1 July 2019 (UTC)", "21:42, 29 July 2019 (UTC)" * (en) Comments by users who customize the timestamp are not detected. Examples: "10:49, 28 June 2019 (UTC)", "21:34, 14 July 2019 (UTC)" * (en) Comments with signatures missing a username are not detected. This sometimes happens if a comment is accidentally signed with '~~~~~' (five tildes), which only inserts the timestamp. Examples: "17:17, 27 July 2019 (UTC)", "10:25, 29 July 2019 (UTC)" * (pl) A lone timestamp at the beginning of a thread is not detected. It's not part of a post, it was added to aid automatic archiving. Example: "21:03, 18 paź 2018 (CET)" Bug: T245692 Change-Id: I0767bb239a1800f2e538917b5995fc4f0fa4d043
2020-02-20 22:06:17 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Demkoff|2018-10-19T01:41:00.000Z|0",
Stop printing console warnings It was useful when I was debugging those parts of the code, but now it's usually annoying. The warnings can still sometimes be useful for understanding how the tool parses some discussion, though. To keep that functionality, add displaying warnings for each comment in the debug mode. Change-Id: I2d218a8a394f179bcc0990ff988a0567c275ccf2
2020-05-13 18:23:48 +00:00
"warnings": [
"Comment skips indentation level"
Allow updating the expected results when running PHP tests This is similar to the code we already have in JS tests, but instead of printing to the console where you have to copy-paste from, it just overwrites the files. Also, update all of the expected results by this method. Changes in the expected outputs: * In JSON files, the "warnings" are now always in the same place regardless of the type of the warning. * In all HTML files, self-closing tags now include the trailing slash, some characters are no longer encoded as entities when not necessary, and attributes may be single-quoted when that makes them shorter. * In Parsoid HTML files, the header is no longer terribly mangled. Other notes: * CommentParserTest.php: Change the output of serializeComments() to be in similar order as in JS, to reduce the diffs in this commit and because it's a better order for humans. * modifier.test.js: Remove some hacks that were working around small inconsistencies between the previous expected outputs and the actual outputs. Change-Id: I9f764640dae823321c0ac35898fa4db03f1ca364
2020-07-30 23:34:56 +00:00
],
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/166/0",
"0/166/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-02T20:26:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Paweł Ziemian",
"range": [
"0/168/0",
"0/168/18/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/168/15",
"0/168/18/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Paweł Ziemian|2018-10-02T20:26:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-02T22:16:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Matma Rex",
"range": [
"0/170/0/0",
"0/170/0/6/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/170/0/3",
"0/170/0/6/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Matma Rex|2018-10-02T22:16:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-19T12:09:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ashaio",
"range": [
"0/172/0",
"0/172/8/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/172/5",
"0/172/8/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ashaio|2018-10-19T12:09:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-19T20:23:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Paweł Ziemian",
"range": [
"0/174/0/0",
"0/174/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/174/0/3",
"0/174/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Paweł Ziemian|2018-10-19T20:23:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/176/0",
"0/176/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-18T13:45:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Vinsinna",
"range": [
"0/178/0",
"0/178/10/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/178/7",
"0/178/10/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Vinsinna|2018-10-18T13:45:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-18T15:07:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Kenraiz",
"range": [
"0/180/0/0",
"0/180/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/180/0/1",
"0/180/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Kenraiz|2018-10-18T15:07:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-18T17:12:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Vinsinna",
"range": [
"0/180/0/5/0/0",
"0/180/0/5/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/180/0/5/0/1",
"0/180/0/5/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Vinsinna|2018-10-18T17:12:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-18T15:24:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "WTM",
"range": [
"0/180/2/0",
"0/180/2/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/180/2/3",
"0/180/2/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "WTM|2018-10-18T15:24:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-18T17:11:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Vinsinna",
"range": [
"0/180/2/7/0/0",
"0/180/2/7/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/180/2/7/0/3",
"0/180/2/7/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Vinsinna|2018-10-18T17:11:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-18T18:39:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ented",
"range": [
"0/182/0/0",
"0/182/0/13/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/182/0/10",
"0/182/0/13/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ented|2018-10-18T18:39:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-18T18:45:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Kenraiz",
"range": [
"0/182/2/0",
"0/182/2/11/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/182/2/8",
"0/182/2/11/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Kenraiz|2018-10-18T18:45:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-19T19:10:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Vinsinna",
"range": [
"0/182/2/12/0/0",
"0/182/2/12/0/12/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/182/2/12/0/9",
"0/182/2/12/0/12/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Vinsinna|2018-10-19T19:10:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-19T19:21:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Kenraiz",
"range": [
"0/182/2/12/0/13/0/0",
"0/182/2/12/0/13/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/182/2/12/0/13/0/1",
"0/182/2/12/0/13/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Kenraiz|2018-10-19T19:21:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-21T12:40:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Vinsinna",
"range": [
"0/182/2/12/0/13/2/0",
"0/182/2/12/0/13/2/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/182/2/12/0/13/2/3",
"0/182/2/12/0/13/2/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Vinsinna|2018-10-21T12:40:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/184/0",
"0/184/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-21T12:45:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Czyz1",
"range": [
"0/186/0",
"0/186/12/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/186/9",
"0/186/12/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Czyz1|2018-10-21T12:45:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-21T17:12:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Teukros",
"range": [
"0/188/0/0",
"0/188/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/188/0/3",
"0/188/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Teukros|2018-10-21T17:12:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-21T19:09:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Czyz1",
"range": [
"0/188/0/7/0/0",
"0/188/0/7/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/188/0/7/0/1",
"0/188/0/7/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Czyz1|2018-10-21T19:09:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-21T19:25:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Mike210381",
"range": [
"0/188/2/0",
"0/188/2/8/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/188/2/5",
"0/188/2/8/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Mike210381|2018-10-21T19:25:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-22T15:26:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Aotearoa",
"range": [
"0/188/4/0",
"0/188/4/8/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/188/4/5",
"0/188/4/8/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Aotearoa|2018-10-22T15:26:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T10:29:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Czyz1",
"range": [
"0/188/4/9/0/0",
"0/188/4/9/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/188/4/9/0/3",
"0/188/4/9/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Czyz1|2018-10-23T10:29:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T16:44:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Eurohunter",
"range": [
"0/188/6/0",
"0/188/6/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/188/6/1",
"0/188/6/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Eurohunter|2018-10-23T16:44:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/190/0",
"0/190/1"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T19:16:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Stok",
"range": [
"0/192/0",
"0/194/3/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/194/0",
"0/194/3/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Stok|2018-10-23T19:16:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/196/0",
"0/196/1"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T21:59:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Eurohunter",
"range": [
"0/198/0",
"0/198/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/198/1",
"0/198/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Eurohunter|2018-10-23T21:59:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/200/0",
"0/200/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-25T07:59:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Agrezt",
"range": [
"0/202/0",
"0/203/3/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/203/0",
"0/203/3/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Agrezt|2018-10-25T07:59:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-25T08:15:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ciacho5",
"range": [
"0/205/0/0",
"0/205/0/10/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/205/0/7",
"0/205/0/10/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ciacho5|2018-10-25T08:15:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/207/0",
"0/207/1"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-14T19:29:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Andrzej1993",
"range": [
"0/209/0",
"0/215/3/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/215/0",
"0/215/3/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Andrzej1993|2018-10-14T19:29:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-25T12:59:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "KamilK7",
"range": [
"0/217/0/0",
"0/217/0/8/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/217/0/5",
"0/217/0/8/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "KamilK7|2018-10-25T12:59:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/219/0",
"0/219/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-25T20:40:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Karol Szapsza",
"range": [
"0/221/0",
"0/221/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/221/3",
"0/221/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Karol Szapsza|2018-10-25T20:40:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/224/0",
"0/224/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T16:01:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Piotr967",
"range": [
"0/226/0",
"0/226/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/226/3",
"0/226/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Piotr967|2018-10-23T16:01:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T16:43:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Eurohunter",
"range": [
"0/228/0/0",
"0/228/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/228/0/1",
"0/228/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Eurohunter|2018-10-23T16:43:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T16:46:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Tokyotown8",
"range": [
"0/230/0/0",
"0/230/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/230/0/1",
"0/230/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Tokyotown8|2018-10-23T16:46:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T16:52:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Piotr967",
"range": [
"0/232/0/0/0/0",
"0/232/0/0/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/232/0/0/0/1",
"0/232/0/0/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Piotr967|2018-10-23T16:52:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T17:16:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Tokyotown8",
"range": [
"0/232/0/0/0/5/0/0",
"0/232/0/0/0/5/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/232/0/0/0/5/0/1",
"0/232/0/0/0/5/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Tokyotown8|2018-10-23T17:16:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T17:40:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Mpn",
"range": [
"0/232/0/0/0/5/2/0",
"0/232/0/0/0/5/2/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/232/0/0/0/5/2/1",
"0/232/0/0/0/5/2/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 4,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Mpn|2018-10-23T17:40:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T17:44:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Szoltys",
"range": [
"0/232/0/0/0/5/2/5/0/0",
"0/232/0/0/0/5/2/5/0/2/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/232/0/0/0/5/2/5/0/1",
"0/232/0/0/0/5/2/5/0/2/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 5,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Szoltys|2018-10-23T17:44:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T17:56:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "109.233.47.132",
"range": [
"0/234/0/0",
"0/234/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/234/0/1",
"0/234/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "109.233.47.132|2018-10-23T17:56:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T20:50:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Panek",
"range": [
"0/234/2/0",
"0/234/2/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/234/2/1",
"0/234/2/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Panek|2018-10-23T20:50:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-23T21:36:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Kenraiz",
"range": [
"0/234/4/0",
"0/234/4/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/234/4/1",
"0/234/4/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Kenraiz|2018-10-23T21:36:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-25T12:09:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "KamilK7",
"range": [
"0/234/6/0",
"0/234/6/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/234/6/1",
"0/234/6/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "KamilK7|2018-10-25T12:09:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-25T17:14:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "BasileusAutokratorPL",
"range": [
"0/236/0",
"0/236/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/236/1",
"0/236/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "BasileusAutokratorPL|2018-10-25T17:14:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-25T18:43:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Żyrafał",
"range": [
"0/238/0/0",
"0/238/0/10/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/238/0/7",
"0/238/0/10/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Żyrafał|2018-10-25T18:43:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-26T05:36:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Piolodiusz",
"range": [
"0/240/0/0",
"0/240/0/8/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/240/0/5",
"0/240/0/8/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Piolodiusz|2018-10-26T05:36:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-26T16:09:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Żyrafał",
"range": [
"0/240/0/9/0/0",
"0/240/0/9/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/240/0/9/0/3",
"0/240/0/9/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Żyrafał|2018-10-26T16:09:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-26T16:13:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Michalwadas",
"range": [
"0/242/0/0",
"0/242/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/242/0/1",
"0/242/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Michalwadas|2018-10-26T16:13:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/244/0",
"0/244/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-26T17:17:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "WTM",
"range": [
"0/246/0",
"0/248/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/248/0/3",
"0/248/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Allow updating the expected results when running PHP tests This is similar to the code we already have in JS tests, but instead of printing to the console where you have to copy-paste from, it just overwrites the files. Also, update all of the expected results by this method. Changes in the expected outputs: * In JSON files, the "warnings" are now always in the same place regardless of the type of the warning. * In all HTML files, self-closing tags now include the trailing slash, some characters are no longer encoded as entities when not necessary, and attributes may be single-quoted when that makes them shorter. * In Parsoid HTML files, the header is no longer terribly mangled. Other notes: * CommentParserTest.php: Change the output of serializeComments() to be in similar order as in JS, to reduce the diffs in this commit and because it's a better order for humans. * modifier.test.js: Remove some hacks that were working around small inconsistencies between the previous expected outputs and the actual outputs. Change-Id: I9f764640dae823321c0ac35898fa4db03f1ca364
2020-07-30 23:34:56 +00:00
"id": "WTM|2018-10-26T17:17:00.000Z|0",
Stop printing console warnings It was useful when I was debugging those parts of the code, but now it's usually annoying. The warnings can still sometimes be useful for understanding how the tool parses some discussion, though. To keep that functionality, add displaying warnings for each comment in the debug mode. Change-Id: I2d218a8a394f179bcc0990ff988a0567c275ccf2
2020-05-13 18:23:48 +00:00
"warnings": [
"Comment starts and ends with different indentation"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/250/0",
"0/250/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-26T17:07:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "BasileusAutokratorPL",
"range": [
"0/251/0",
"0/254/8/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/254/5",
"0/254/8/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "BasileusAutokratorPL|2018-10-26T17:07:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-26T17:27:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ciacho5",
"range": [
"0/256/0/0",
"0/256/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/256/0/1",
"0/256/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ciacho5|2018-10-26T17:27:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-26T20:19:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Mitrovitz",
"range": [
"0/256/2/0",
"0/256/2/12/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/256/2/9",
"0/256/2/12/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Mitrovitz|2018-10-26T20:19:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-26T21:21:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Vinsinna",
"range": [
"0/256/2/13/0/0",
"0/256/2/13/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/256/2/13/0/1",
"0/256/2/13/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Vinsinna|2018-10-26T21:21:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-26T22:01:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Piotr967",
"range": [
"0/256/4/0",
"0/256/4/8/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/256/4/1",
"0/256/4/4/26"
],
[
"0/256/4/5",
"0/256/4/8/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
parser: Merge multiple comments on one line Even when you have multiple signatures by multiple users in one paragraph (or list item), it's still basically a single comment. We don't want to offer multiple buttons to reply to it. The changed parser test cases are illustrative: * All affected comments in the "pl" example are comments with a "post-scriptum", which is now more intuitively treated as part of the main comment. * The first comment in the "en" example would probably have been better if it wasn't merged, but a weird use of the outdent template causes us to not be able to distinguish that the two parts of the comment display on separate lines. * The last comment in the "en" example (isn't that neat?) was previously incorrectly treated as two comments, because there's a timestamp in the middle of it (the user is referring to another comment). * Remaining affected comments in the "en" example are also comments with a "post-scriptum" and their treatment is clearly better now. It also accidentally fixes some problems with modifier tests (but not all), where previously <dl> nodes would be inserted in the middle of <p> nodes, to reply to the comments which are now merged. Bug: T240640 Change-Id: I0f2d9238aff75d78286250affd323cd145661a11
2020-01-22 00:00:18 +00:00
"id": "Piotr967|2018-10-26T22:01:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-26T22:10:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ented",
"range": [
"0/256/6/0",
"0/256/6/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/256/6/1",
"0/256/6/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ented|2018-10-26T22:10:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/258/0",
"0/258/1"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-20T18:23:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Wiktoryn",
"range": [
"0/260/0",
"0/260/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/260/3",
"0/260/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Wiktoryn|2018-10-20T18:23:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-28T17:53:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Malarz pl",
"range": [
"0/262/0/0",
"0/262/0/6/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/262/0/3",
"0/262/0/6/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Malarz pl|2018-10-28T17:53:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-28T18:50:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Elfhelm",
"range": [
"0/262/2/0",
"0/262/2/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/262/2/1",
"0/262/2/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Elfhelm|2018-10-28T18:50:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/264/0",
"0/264/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-29T08:12:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Arvedui89",
"range": [
"0/266/0",
"0/266/6/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/266/3",
"0/266/6/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Arvedui89|2018-10-29T08:12:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-29T10:20:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ciacho5",
"range": [
"0/268/0/0",
"0/268/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/268/0/1",
"0/268/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ciacho5|2018-10-29T10:20:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-29T10:49:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Malarz pl",
"range": [
"0/268/2/0",
"0/268/2/7/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/268/2/4",
"0/268/2/7/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Malarz pl|2018-10-29T10:49:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/270/0",
"0/270/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-24T01:36:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Smyrwa",
"range": [
"0/272/0",
"0/290/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/290/1",
"0/290/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Smyrwa|2018-10-24T01:36:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-24T06:35:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Gżdacz",
"range": [
"0/292/0/0",
"0/292/0/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/292/0/1",
"0/292/0/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Gżdacz|2018-10-24T06:35:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-24T15:14:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Pbk",
"range": [
"0/292/2/0",
"0/296/10/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/296/1",
"0/296/4/27"
],
[
Fix signatureRanges overlapping for some comments If two signatures for a single comment were near each other, we would sometimes treat them as one huge signature. Change-Id: Ied4b3aa535a9ca6bebef8a004ae48b7d5a8f2f9b
2020-03-06 16:51:59 +00:00
"0/296/7",
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"0/296/10/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Allow updating the expected results when running PHP tests This is similar to the code we already have in JS tests, but instead of printing to the console where you have to copy-paste from, it just overwrites the files. Also, update all of the expected results by this method. Changes in the expected outputs: * In JSON files, the "warnings" are now always in the same place regardless of the type of the warning. * In all HTML files, self-closing tags now include the trailing slash, some characters are no longer encoded as entities when not necessary, and attributes may be single-quoted when that makes them shorter. * In Parsoid HTML files, the header is no longer terribly mangled. Other notes: * CommentParserTest.php: Change the output of serializeComments() to be in similar order as in JS, to reduce the diffs in this commit and because it's a better order for humans. * modifier.test.js: Remove some hacks that were working around small inconsistencies between the previous expected outputs and the actual outputs. Change-Id: I9f764640dae823321c0ac35898fa4db03f1ca364
2020-07-30 23:34:56 +00:00
"id": "Pbk|2018-10-24T15:14:00.000Z|0",
Stop printing console warnings It was useful when I was debugging those parts of the code, but now it's usually annoying. The warnings can still sometimes be useful for understanding how the tool parses some discussion, though. To keep that functionality, add displaying warnings for each comment in the debug mode. Change-Id: I2d218a8a394f179bcc0990ff988a0567c275ccf2
2020-05-13 18:23:48 +00:00
"warnings": [
"Comment starts and ends with different indentation"
],
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-30T14:58:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Smyrwa",
"range": [
"0/298/0/0/0/0",
"0/300/0/0/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/300/0/0/0/3",
"0/300/0/0/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Smyrwa|2018-10-30T14:58:00.000Z|0",
Stop printing console warnings It was useful when I was debugging those parts of the code, but now it's usually annoying. The warnings can still sometimes be useful for understanding how the tool parses some discussion, though. To keep that functionality, add displaying warnings for each comment in the debug mode. Change-Id: I2d218a8a394f179bcc0990ff988a0567c275ccf2
2020-05-13 18:23:48 +00:00
"warnings": [
"Comment skips indentation level"
Allow updating the expected results when running PHP tests This is similar to the code we already have in JS tests, but instead of printing to the console where you have to copy-paste from, it just overwrites the files. Also, update all of the expected results by this method. Changes in the expected outputs: * In JSON files, the "warnings" are now always in the same place regardless of the type of the warning. * In all HTML files, self-closing tags now include the trailing slash, some characters are no longer encoded as entities when not necessary, and attributes may be single-quoted when that makes them shorter. * In Parsoid HTML files, the header is no longer terribly mangled. Other notes: * CommentParserTest.php: Change the output of serializeComments() to be in similar order as in JS, to reduce the diffs in this commit and because it's a better order for humans. * modifier.test.js: Remove some hacks that were working around small inconsistencies between the previous expected outputs and the actual outputs. Change-Id: I9f764640dae823321c0ac35898fa4db03f1ca364
2020-07-30 23:34:56 +00:00
],
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-25T10:50:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Andrzei111",
"range": [
"0/302/0/0",
"0/302/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/302/0/3",
"0/302/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Andrzei111|2018-10-25T10:50:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-30T14:58:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Smyrwa",
"range": [
"0/304/0/0/0/0",
"0/304/0/0/0/6/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/304/0/0/0/3",
"0/304/0/0/0/6/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Smyrwa|2018-10-30T14:58:00.000Z|1",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-25T10:59:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Felis domestica",
"range": [
"0/306/0/0",
"0/306/0/6/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/306/0/3",
"0/306/0/6/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Felis domestica|2018-10-25T10:59:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-25T20:03:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "BasileusAutokratorPL",
"range": [
"0/308/0",
"0/308/4/27"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/308/1",
"0/308/4/27"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "BasileusAutokratorPL|2018-10-25T20:03:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-30T14:58:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Smyrwa",
"range": [
"0/310/0/0/0/0",
"0/310/0/0/0/4/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/310/0/0/0/1",
"0/310/0/0/0/4/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 3,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Smyrwa|2018-10-30T14:58:00.000Z|2",
Stop printing console warnings It was useful when I was debugging those parts of the code, but now it's usually annoying. The warnings can still sometimes be useful for understanding how the tool parses some discussion, though. To keep that functionality, add displaying warnings for each comment in the debug mode. Change-Id: I2d218a8a394f179bcc0990ff988a0567c275ccf2
2020-05-13 18:23:48 +00:00
"warnings": [
"Comment skips indentation level"
Allow updating the expected results when running PHP tests This is similar to the code we already have in JS tests, but instead of printing to the console where you have to copy-paste from, it just overwrites the files. Also, update all of the expected results by this method. Changes in the expected outputs: * In JSON files, the "warnings" are now always in the same place regardless of the type of the warning. * In all HTML files, self-closing tags now include the trailing slash, some characters are no longer encoded as entities when not necessary, and attributes may be single-quoted when that makes them shorter. * In Parsoid HTML files, the header is no longer terribly mangled. Other notes: * CommentParserTest.php: Change the output of serializeComments() to be in similar order as in JS, to reduce the diffs in this commit and because it's a better order for humans. * modifier.test.js: Remove some hacks that were working around small inconsistencies between the previous expected outputs and the actual outputs. Change-Id: I9f764640dae823321c0ac35898fa4db03f1ca364
2020-07-30 23:34:56 +00:00
],
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
},
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "heading",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"range": [
"0/312/0",
"0/312/2"
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 0,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": null,
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-31T13:57:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Ciacho5",
"range": [
"0/314/0",
"0/314/8/26"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/314/5",
"0/314/8/26"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 1,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Ciacho5|2018-10-31T13:57:00.000Z|0",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"replies": [
{
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"type": "comment",
"timestamp": "2018-10-31T14:55:00.000Z",
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
"author": "Malarz pl",
"range": [
"0/316/0/0",
"0/316/0/4/25"
],
parser: Return signature and timestamp ranges Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac
2020-03-04 16:14:47 +00:00
"signatureRanges": [
[
"0/316/0/1",
"0/316/0/4/25"
]
],
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"level": 2,
Identify comments by username+timestamp+seq Possible use cases: * Matching comments between PHP and Parsoid HTML [implemented here] * Finding the same comment in a different revision of a page (e.g. while resolving an edit conflict, or to allow resuming composition of autosaved comments) [implemented for highlighting user's own posted comment only] * Permanent links to comments [future] The reasoning for this form of ID is: * _Timestamp_ by itself is a nearly unique identifier, so it's a good thing to start with * Users may post multiple comments in one edit (or in many edits in one minute), so we need the _sequential number_ to distinguish them * _Username_ is probably not required, but it may reduce the need for sequential numbers, and will help with human-readability if we add permanent links The ID remains stable when a new comment is added anywhere by anyone (excepts comments within the same minute by the same user), or when a section is renamed. It's not always stable when a comment is moved or when an entire section is moved or deleted (archived), but you can't have everything. Change-Id: Idaae6427d659d12b82e37f1791bd03833632c7c0
2019-11-24 15:39:52 +00:00
"id": "Malarz pl|2018-10-31T14:55:00.000Z|0",
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
"replies": []
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
Document how to update the test JSON files (And rebuild them using this method, the properties are in different order, it's actually nice for readability to have 'replies' last) Change-Id: Ib586e1081fa36cb9125db1b0b1d41f092350641c
2019-11-24 16:28:01 +00:00
]
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0
2019-10-24 12:59:42 +00:00
}
]
Reference in a new issue Copy permalink